From: Len Brown <lenb@kernel.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Vegard Nossum <vegard.nossum@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org, Zhao Yakui <yakui.zhao@intel.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Alexey Starikovskiy <astarikovskiy@suse.de>,
Yinghai Lu <yhlu.kernel@gmail.com>
Subject: Re: [PATCH] ACPI: add standard linux WARN() output to ACPI warnings
Date: Wed, 25 Jun 2008 23:57:54 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0806252357300.3279@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.1.10.0806242310000.3014@localhost.localdomain>
On Tue, 24 Jun 2008, Len Brown wrote:
>
>
> > Please do not use warn_on_slowpath() directly!
> > Please use WARN_ON() or WARN(). The later has printk semantics so this
> > could turn into
> >
> > WARN(1, "ACPI Error (%s-%0d): \n", module_name, line_number);
>
> >
> > and kerneloops.org and various other tools will pick up the printk like
> > arguments as part of the warning message.
>
> cool, will do.
that is, will do when WARN() actually gets upstream:-)
next prev parent reply other threads:[~2008-06-26 3:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 9:52 [bug, acpi] BUG: spinlock bad magic on CPU#0, swapper/1, ACPI Exception (utmutex-0263): AE_BAD_PARAMETER Ingo Molnar
2008-06-20 13:11 ` Vegard Nossum
2008-06-20 13:56 ` [PATCH] ACPI: don't walk tables if ACPI was disabled Vegard Nossum
2008-06-20 14:22 ` Ingo Molnar
2008-06-25 2:34 ` [PATCH] ACPI: add standard linux WARN() output to ACPI warnings Len Brown
2008-06-25 2:49 ` Arjan van de Ven
2008-06-25 3:10 ` Len Brown
2008-06-26 3:57 ` Len Brown [this message]
2008-06-20 19:00 ` [PATCH] ACPI: don't walk tables if ACPI was disabled Len Brown
2008-06-20 20:40 ` Vegard Nossum
2008-06-20 21:27 ` Vegard Nossum
2008-06-21 8:19 ` Vegard Nossum
2008-06-24 11:41 ` Ingo Molnar
2008-06-24 11:52 ` Vegard Nossum
2008-06-24 15:22 ` Bjorn Helgaas
2008-06-25 1:37 ` Zhao Yakui
2008-06-25 15:08 ` Bjorn Helgaas
2008-06-26 3:02 ` Zhao Yakui
2008-06-26 16:44 ` Bjorn Helgaas
2008-06-25 2:41 ` Len Brown
2008-06-25 7:07 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0806252357300.3279@localhost.localdomain \
--to=lenb@kernel.org \
--cc=arjan@infradead.org \
--cc=astarikovskiy@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=vegard.nossum@gmail.com \
--cc=yakui.zhao@intel.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox