[Resend][2.6.27-git-a447c093244] BUG: spinlock bad magic on CPU#0, setserial/3527

[Resend][2.6.27-git-a447c093244] BUG: spinlock bad magic on CPU#0, setserial/3527

[Rafael J. Wysocki]

[Sorry, I had a wrong address of Dmitry, resending.]

Hi,

The Linus' tree from today on Asus L5D:

BUG: spinlock bad magic on CPU#0, setserial/3527
 lock: ffffffff80dae020, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0
Pid: 3527, comm: setserial Not tainted 2.6.27-git #57
Call Trace:
 [<ffffffff80345aae>] spin_bug+0xde/0xf0
 [<ffffffff80345bd6>] _raw_spin_lock+0x86/0x140
 [<ffffffff804823ca>] _spin_lock_irq+0x3a/0x50
 [<ffffffff803ae89d>] ? serial8250_startup+0x13d/0x610
 [<ffffffff803ae89d>] serial8250_startup+0x13d/0x610
 [<ffffffff803abd9a>] uart_startup+0x6a/0x1a0
 [<ffffffff803acca5>] uart_open+0x115/0x4a0
 [<ffffffff80482286>] ? _spin_unlock+0x26/0x30
 [<ffffffff8038d271>] ? check_tty_count+0x21/0xc0
 [<ffffffff8039067a>] tty_open+0x1ea/0x440
 [<ffffffff802a8490>] chrdev_open+0xa0/0x1c0
 [<ffffffff802a385c>] __dentry_open+0xcc/0x2c0
 [<ffffffff802a83f0>] ? chrdev_open+0x0/0x1c0
 [<ffffffff802a3a94>] nameidata_to_filp+0x44/0x60
 [<ffffffff802b052d>] do_filp_open+0x1fd/0x8f0
 [<ffffffff802add86>] ? getname+0x36/0x210
 [<ffffffff802bda06>] ? alloc_fd+0x106/0x130
 [<ffffffff802a36ae>] do_sys_open+0x5e/0xf0
 [<ffffffff802a376b>] sys_open+0x1b/0x20
 [<ffffffff8020b66b>] system_call_fastpath+0x16/0x1b

Do I have to bisect? :-)

Rafael

Re: [Resend][2.6.27-git-a447c093244] BUG: spinlock bad magic on CPU#0, setserial/3527

[Linus Torvalds]

If this started today, then the most likely culprit is Alan's series of 80 
serial patches.

Alan? I can only assume it's one of the

	spin_lock_irq(&up->port.lock);

in serial8250_startup() (or quite likely in one of the functions it calls 
that get inlined by the compiler, like enable_rsa()).

And it sounds like it didn't get initialized.

		Linus

On Tue, 14 Oct 2008, Rafael J. Wysocki wrote:
>
> [Sorry, I had a wrong address of Dmitry, resending.]
> 
> Hi,
> 
> The Linus' tree from today on Asus L5D:
> 
> BUG: spinlock bad magic on CPU#0, setserial/3527
>  lock: ffffffff80dae020, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0
> Pid: 3527, comm: setserial Not tainted 2.6.27-git #57
> Call Trace:
>  [<ffffffff80345aae>] spin_bug+0xde/0xf0
>  [<ffffffff80345bd6>] _raw_spin_lock+0x86/0x140
>  [<ffffffff804823ca>] _spin_lock_irq+0x3a/0x50
>  [<ffffffff803ae89d>] ? serial8250_startup+0x13d/0x610
>  [<ffffffff803ae89d>] serial8250_startup+0x13d/0x610
>  [<ffffffff803abd9a>] uart_startup+0x6a/0x1a0
>  [<ffffffff803acca5>] uart_open+0x115/0x4a0
>  [<ffffffff80482286>] ? _spin_unlock+0x26/0x30
>  [<ffffffff8038d271>] ? check_tty_count+0x21/0xc0
>  [<ffffffff8039067a>] tty_open+0x1ea/0x440
>  [<ffffffff802a8490>] chrdev_open+0xa0/0x1c0
>  [<ffffffff802a385c>] __dentry_open+0xcc/0x2c0
>  [<ffffffff802a83f0>] ? chrdev_open+0x0/0x1c0
>  [<ffffffff802a3a94>] nameidata_to_filp+0x44/0x60
>  [<ffffffff802b052d>] do_filp_open+0x1fd/0x8f0
>  [<ffffffff802add86>] ? getname+0x36/0x210
>  [<ffffffff802bda06>] ? alloc_fd+0x106/0x130
>  [<ffffffff802a36ae>] do_sys_open+0x5e/0xf0
>  [<ffffffff802a376b>] sys_open+0x1b/0x20
>  [<ffffffff8020b66b>] system_call_fastpath+0x16/0x1b
> 
> Do I have to bisect? :-)
> 
> Rafael
> 

Re: [Resend][2.6.27-git-a447c093244] BUG: spinlock bad magic on CPU#0, setserial/3527

[Alan Cox]

On Mon, 13 Oct 2008 16:10:14 -0700 (PDT)
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> 
> If this started today, then the most likely culprit is Alan's series of 80 
> serial patches.
> 
> Alan? I can only assume it's one of the
> 
> 	spin_lock_irq(&up->port.lock);
> 
> in serial8250_startup() (or quite likely in one of the functions it calls 
> that get inlined by the compiler, like enable_rsa()).
> 
> And it sounds like it didn't get initialized.

Yeah I know whats going on I think. When I dropped out the NR_IRQ changes
I didn't drop back in the spin lock init. Will sort it tomorrow (actually
'later today' as its midnight here)

Alan