The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	mtk.manpages@gmail.com,
	kernel list <linux-kernel@vger.kernel.org>,
	Ulrich Drepper <drepper@redhat.com>,
	Vegard Nossum <vegard.nossum@gmail.com>,
	"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>
Subject: Re: [PATCH] sys_waitid: return -EFAULT for NULL
Date: Tue, 13 Jan 2009 16:33:01 -0800 (PST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0901131629220.6528@localhost.localdomain> (raw)
In-Reply-To: <20090113224941.36F19FC3DD@magilla.sf.frob.com>



On Tue, 13 Jan 2009, Roland McGrath wrote:
>
> It's always been invalid to call waitid() with a NULL pointer.  It was an
> oversight that it was allowed (and acts like a wait4() call instead).

I'm not going to take this. 

If it was some new system call, of if there was some downside to out 
behavior, I might be interested. As it is, our behaviour has zero 
downside, and changing existing interfaces simply isn't worth it.

The alleged "downsides" are bogus:

 - POSIX is not that strict. EFAULT is one of the odd error cases anyway, 
   and even explicit requirements are irrelevant: if somebody wants to get 
   strict conformance paperwork done, you just need to tell where you 
   differ, and you're basically done. But perhaps more important, nobody 
   cares.

 - The "portability" argument is totally bogus, since it's not like you 
   compile programs without even testing to another UNIX _anyway_. 

So I'm simply not going to potentially break binaries over something that 
is so _totally_ irrelevant. Document it in the man-page instead.

		Linus

  parent reply	other threads:[~2009-01-14  0:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cfd18e0f0901131436ud2cf61bkf0e6b00f4b765bb5@mail.gmail.com>
2009-01-13 22:38 ` waitid() return value strangeness when infop is NULL Michael Kerrisk
2009-01-13 22:43   ` Michael Kerrisk
2009-01-13 22:47   ` Roland McGrath
2009-01-13 22:49     ` [PATCH] sys_waitid: return -EFAULT for NULL Roland McGrath
2009-01-13 23:14       ` Michael Kerrisk
2009-01-13 23:24         ` Andrew Morton
2009-01-13 23:36           ` Michael Kerrisk
2009-01-13 23:47           ` Roland McGrath
2009-01-14  0:13             ` Michael Kerrisk
2009-01-14  0:24               ` Ulrich Drepper
2009-01-14  0:33       ` Linus Torvalds [this message]
2009-01-14  0:53         ` Michael Kerrisk
2009-01-14  0:57           ` Linus Torvalds
2009-01-14  1:39             ` Michael Kerrisk
2009-01-14  2:10               ` Linus Torvalds
2009-01-14  2:28                 ` Michael Kerrisk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0901131629220.6528@localhost.localdomain \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=drepper@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=roland@redhat.com \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox