From: John Kacur <jkacur@redhat.com>
To: linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Vincent Sanders <vince@simtec.co.uk>, Ingo Molnar <mingo@elte.hu>,
Christoph Hellwig <hch@infradead.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Mike Frysinger <vapier@gentoo.org>,
David Howells <dhowells@redhat.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Roman Zippel <zippel@linux-m68k.org>,
Greg Ungerer <gerg@uclinux.org>,
David Howells <dhowells@redhat.com>,
Koichi Yasutake <yasutake.koichi@jp.panasonic.com>
Subject: [PATCH 1/6 RFC] arch/blackfin/kernel/process.c: Remove the BKL from sys_execve
Date: Tue, 13 Oct 2009 00:33:21 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.0910130007240.3658@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.0910122350140.3658@localhost.localdomain>
>From b9b41b5a546ed0202c099f0d973da4df9aea314a Mon Sep 17 00:00:00 2001
From: John Kacur <jkacur@redhat.com>
Date: Mon, 12 Oct 2009 22:44:40 +0200
Subject: [PATCH] arch/blackfin/kernel/process.c: Remove the BKL from sys_execve
This looks like a cut-and-paste job.
For example, compare this function to sys_execve in
arch/x86/kernel/process_64.c
and it is almost line by line the same, except the one in x86 nolonger has the
big kernel lock. All of the functions called between the lock are generic
and not specific to blackfin - thus, I believe it is safe to remove the
bkl here.
Signed-off-by: John Kacur <jkacur@redhat.com>
---
arch/blackfin/kernel/process.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c
index 430ae39..7d9c975 100644
--- a/arch/blackfin/kernel/process.c
+++ b/arch/blackfin/kernel/process.c
@@ -215,22 +215,18 @@ copy_thread(unsigned long clone_flags,
/*
* sys_execve() executes a new program.
*/
-
asmlinkage int sys_execve(char __user *name, char __user * __user *argv, char __user * __user *envp)
{
int error;
char *filename;
struct pt_regs *regs = (struct pt_regs *)((&name) + 6);
- lock_kernel();
filename = getname(name);
error = PTR_ERR(filename);
if (IS_ERR(filename))
- goto out;
+ return error;
error = do_execve(filename, argv, envp, regs);
putname(filename);
- out:
- unlock_kernel();
return error;
}
--
1.6.0.6
next parent reply other threads:[~2009-10-12 22:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.2.00.0910122350140.3658@localhost.localdomain>
2009-10-12 22:33 ` John Kacur [this message]
2009-10-12 22:33 ` [PATCH 2/6 RFC] arch/frv/kernel/process.c: Remove the BKL from sys_execve John Kacur
2009-10-12 22:34 ` [PATCH 3/6 RFC] arch/h83000/kernel/process.c: Remove " John Kacur
2009-10-12 22:34 ` [PATCH 4/6 RFC] arch/m68k/kernel/process.c: Remove the " John Kacur
2009-10-12 22:34 ` [PATCH 5/6 RFC] arch/m68knommu/kernel/process.c: " John Kacur
2009-10-12 22:35 ` [PATCH 6/6 RFC] arch/mn10300/kernel/process.c: " John Kacur
2009-10-13 16:45 ` David Howells
2009-10-14 15:47 ` [tip:bkl/arch] mn10300: " tip-bot for John Kacur
2009-10-13 10:44 ` [PATCH 5/6 RFC] arch/m68knommu/kernel/process.c: " Greg Ungerer
2009-10-13 11:30 ` John Kacur
2009-10-14 15:06 ` Thomas Gleixner
2009-10-14 23:39 ` Greg Ungerer
2009-10-14 15:47 ` [tip:bkl/arch] m68knommu: " tip-bot for John Kacur
2009-10-14 15:46 ` [tip:bkl/arch] m68k: " tip-bot for John Kacur
2009-10-14 15:46 ` [tip:bkl/arch] h83000: Remove " tip-bot for John Kacur
2009-10-13 16:26 ` [PATCH 2/6 RFC] arch/frv/kernel/process.c: Remove the " David Howells
2009-10-14 15:46 ` [tip:bkl/arch] frv: " tip-bot for John Kacur
2009-10-12 22:45 ` [PATCH 1/6 RFC] arch/blackfin/kernel/process.c: " Frederic Weisbecker
2009-10-13 7:54 ` Mike Frysinger
2009-10-13 8:27 ` John Kacur
2009-10-13 8:35 ` Mike Frysinger
2009-10-13 8:41 ` John Kacur
2009-10-14 0:30 ` Mike Frysinger
2009-10-14 15:46 ` [tip:bkl/arch] blackfin: " tip-bot for John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0910130007240.3658@localhost.localdomain \
--to=jkacur@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=fweisbec@gmail.com \
--cc=gerg@uclinux.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
--cc=vince@simtec.co.uk \
--cc=yasutake.koichi@jp.panasonic.com \
--cc=ysato@users.sourceforge.jp \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox