The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: John Kacur <jkacur@redhat.com>
To: linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Vincent Sanders <vince@simtec.co.uk>, Ingo Molnar <mingo@elte.hu>,
	Christoph Hellwig <hch@infradead.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Mike Frysinger <vapier@gentoo.org>,
	David Howells <dhowells@redhat.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Roman Zippel <zippel@linux-m68k.org>,
	Greg Ungerer <gerg@uclinux.org>,
	David Howells <dhowells@redhat.com>,
	Koichi Yasutake <yasutake.koichi@jp.panasonic.com>
Subject: [PATCH 6/6 RFC] arch/mn10300/kernel/process.c: Remove the BKL from sys_execve
Date: Tue, 13 Oct 2009 00:35:06 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0910130016540.3658@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.0910130014520.3658@localhost.localdomain>

>From f05f8e3a2f5210e5274e758f66e33a9d168eacde Mon Sep 17 00:00:00 2001
From: John Kacur <jkacur@redhat.com>
Date: Mon, 12 Oct 2009 23:41:55 +0200
Subject: [PATCH] arch/mn10300/kernel/process.c: Remove the BKL from sys_execve

This looks like a cut-and-paste from functionality that no-longer needs the bkl
Just remove it. Also, rewrite slightly so that it looks closer to sys_execve
on other architectures.

Signed-off-by: John Kacur <jkacur@redhat.com>
---
 arch/mn10300/kernel/process.c |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/arch/mn10300/kernel/process.c b/arch/mn10300/kernel/process.c
index 892cce8..ec8a21d 100644
--- a/arch/mn10300/kernel/process.c
+++ b/arch/mn10300/kernel/process.c
@@ -275,16 +275,12 @@ asmlinkage long sys_execve(char __user *name,
 	char *filename;
 	int error;
 
-	lock_kernel();
-
 	filename = getname(name);
 	error = PTR_ERR(filename);
-	if (!IS_ERR(filename)) {
-		error = do_execve(filename, argv, envp, __frame);
-		putname(filename);
-	}
-
-	unlock_kernel();
+	if (IS_ERR(filename))
+		return error;
+	error = do_execve(filename, argv, envp, __frame);
+	putname(filename);
 	return error;
 }
 
-- 
1.6.0.6



  reply	other threads:[~2009-10-12 22:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <alpine.LFD.2.00.0910122350140.3658@localhost.localdomain>
2009-10-12 22:33 ` [PATCH 1/6 RFC] arch/blackfin/kernel/process.c: Remove the BKL from sys_execve John Kacur
2009-10-12 22:33   ` [PATCH 2/6 RFC] arch/frv/kernel/process.c: " John Kacur
2009-10-12 22:34     ` [PATCH 3/6 RFC] arch/h83000/kernel/process.c: Remove " John Kacur
2009-10-12 22:34       ` [PATCH 4/6 RFC] arch/m68k/kernel/process.c: Remove the " John Kacur
2009-10-12 22:34         ` [PATCH 5/6 RFC] arch/m68knommu/kernel/process.c: " John Kacur
2009-10-12 22:35           ` John Kacur [this message]
2009-10-13 16:45             ` [PATCH 6/6 RFC] arch/mn10300/kernel/process.c: " David Howells
2009-10-14 15:47             ` [tip:bkl/arch] mn10300: " tip-bot for John Kacur
2009-10-13 10:44           ` [PATCH 5/6 RFC] arch/m68knommu/kernel/process.c: " Greg Ungerer
2009-10-13 11:30             ` John Kacur
2009-10-14 15:06             ` Thomas Gleixner
2009-10-14 23:39               ` Greg Ungerer
2009-10-14 15:47           ` [tip:bkl/arch] m68knommu: " tip-bot for John Kacur
2009-10-14 15:46         ` [tip:bkl/arch] m68k: " tip-bot for John Kacur
2009-10-14 15:46       ` [tip:bkl/arch] h83000: Remove " tip-bot for John Kacur
2009-10-13 16:26     ` [PATCH 2/6 RFC] arch/frv/kernel/process.c: Remove the " David Howells
2009-10-14 15:46     ` [tip:bkl/arch] frv: " tip-bot for John Kacur
2009-10-12 22:45   ` [PATCH 1/6 RFC] arch/blackfin/kernel/process.c: " Frederic Weisbecker
2009-10-13  7:54   ` Mike Frysinger
2009-10-13  8:27     ` John Kacur
2009-10-13  8:35       ` Mike Frysinger
2009-10-13  8:41         ` John Kacur
2009-10-14  0:30           ` Mike Frysinger
2009-10-14 15:46   ` [tip:bkl/arch] blackfin: " tip-bot for John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0910130016540.3658@localhost.localdomain \
    --to=jkacur@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=corbet@lwn.net \
    --cc=dhowells@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=gerg@uclinux.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=vapier@gentoo.org \
    --cc=vince@simtec.co.uk \
    --cc=yasutake.koichi@jp.panasonic.com \
    --cc=ysato@users.sourceforge.jp \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox