* [PATCH] IRQ CORE: irq_work_queue function return value not used.
@ 2012-11-02 13:24 anish kumar
2012-11-02 13:43 ` Steven Rostedt
0 siblings, 1 reply; 7+ messages in thread
From: anish kumar @ 2012-11-02 13:24 UTC (permalink / raw)
To: rostedt, linux-kernel, peterz, akpm, paul.gortmaker, tglx, mingo,
fweisbec
Cc: anish kumar
From: anish kumar <anish198519851985@gmail.com>
As no one is using the return value of irq_work_queue function
it is better to just make it void.
Signed-off-by: anish kumar <anish198519851985@gmail.com>
---
kernel/irq_work.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index 1588e3b..a85c4b3 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -79,17 +79,17 @@ static void __irq_work_queue(struct irq_work *work)
*
* Can be re-enqueued while the callback is still in progress.
*/
-bool irq_work_queue(struct irq_work *work)
+void irq_work_queue(struct irq_work *work)
{
if (!irq_work_claim(work)) {
/*
* Already enqueued, can't do!
*/
- return false;
+ return;
}
__irq_work_queue(work);
- return true;
+ return;
}
EXPORT_SYMBOL_GPL(irq_work_queue);
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] IRQ CORE: irq_work_queue function return value not used.
2012-11-02 13:24 [PATCH] IRQ CORE: irq_work_queue function return value not used anish kumar
@ 2012-11-02 13:43 ` Steven Rostedt
2012-11-02 21:49 ` Thomas Gleixner
0 siblings, 1 reply; 7+ messages in thread
From: Steven Rostedt @ 2012-11-02 13:43 UTC (permalink / raw)
To: anish kumar
Cc: linux-kernel, peterz, akpm, paul.gortmaker, tglx, mingo, fweisbec
On Fri, 2012-11-02 at 22:24 +0900, anish kumar wrote:
> From: anish kumar <anish198519851985@gmail.com>
>
> As no one is using the return value of irq_work_queue function
> it is better to just make it void.
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Peter, like to take this patch? Or is there a reason you have for
irq_work_queue() returning a value?
-- Steve
> Signed-off-by: anish kumar <anish198519851985@gmail.com>
> ---
> kernel/irq_work.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> index 1588e3b..a85c4b3 100644
> --- a/kernel/irq_work.c
> +++ b/kernel/irq_work.c
> @@ -79,17 +79,17 @@ static void __irq_work_queue(struct irq_work *work)
> *
> * Can be re-enqueued while the callback is still in progress.
> */
> -bool irq_work_queue(struct irq_work *work)
> +void irq_work_queue(struct irq_work *work)
> {
> if (!irq_work_claim(work)) {
> /*
> * Already enqueued, can't do!
> */
> - return false;
> + return;
> }
>
> __irq_work_queue(work);
> - return true;
> + return;
> }
> EXPORT_SYMBOL_GPL(irq_work_queue);
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] IRQ CORE: irq_work_queue function return value not used.
2012-11-02 13:43 ` Steven Rostedt
@ 2012-11-02 21:49 ` Thomas Gleixner
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Gleixner @ 2012-11-02 21:49 UTC (permalink / raw)
To: Steven Rostedt
Cc: anish kumar, linux-kernel, peterz, akpm, paul.gortmaker, mingo,
fweisbec
On Fri, 2 Nov 2012, Steven Rostedt wrote:
> On Fri, 2012-11-02 at 22:24 +0900, anish kumar wrote:
> > From: anish kumar <anish198519851985@gmail.com>
> >
> > As no one is using the return value of irq_work_queue function
> > it is better to just make it void.
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
>
> Peter, like to take this patch? Or is there a reason you have for
> irq_work_queue() returning a value?
>
> -- Steve
>
> > Signed-off-by: anish kumar <anish198519851985@gmail.com>
> > ---
> > kernel/irq_work.c | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> > index 1588e3b..a85c4b3 100644
> > --- a/kernel/irq_work.c
> > +++ b/kernel/irq_work.c
> > @@ -79,17 +79,17 @@ static void __irq_work_queue(struct irq_work *work)
> > *
> > * Can be re-enqueued while the callback is still in progress.
> > */
> > -bool irq_work_queue(struct irq_work *work)
> > +void irq_work_queue(struct irq_work *work)
> > {
> > if (!irq_work_claim(work)) {
> > /*
> > * Already enqueued, can't do!
> > */
> > - return false;
> > + return;
> > }
> >
> > __irq_work_queue(work);
> > - return true;
> > + return;
And while at it please zap that pointless "return;" statement.
> > }
> > EXPORT_SYMBOL_GPL(irq_work_queue);
> >
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] IRQ CORE: irq_work_queue function return value not used.
@ 2012-11-03 8:57 anish kumar
2013-01-26 16:24 ` Frederic Weisbecker
0 siblings, 1 reply; 7+ messages in thread
From: anish kumar @ 2012-11-03 8:57 UTC (permalink / raw)
To: rostedt, linux-kernel, peterz, akpm, paul.gortmaker, tglx, mingo,
fweisbec
Cc: anish kumar
From: anish kumar <anish198519851985@gmail.com>
As no one is using the return value of irq_work_queue function
it is better to just make it void.
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: anish kumar <anish198519851985@gmail.com>
---
kernel/irq_work.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index 1588e3b..4829a31 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -79,17 +79,16 @@ static void __irq_work_queue(struct irq_work *work)
*
* Can be re-enqueued while the callback is still in progress.
*/
-bool irq_work_queue(struct irq_work *work)
+void irq_work_queue(struct irq_work *work)
{
if (!irq_work_claim(work)) {
/*
* Already enqueued, can't do!
*/
- return false;
+ return;
}
__irq_work_queue(work);
- return true;
}
EXPORT_SYMBOL_GPL(irq_work_queue);
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] IRQ CORE: irq_work_queue function return value not used.
2012-11-03 8:57 anish kumar
@ 2013-01-26 16:24 ` Frederic Weisbecker
2013-02-02 3:14 ` anish kumar
0 siblings, 1 reply; 7+ messages in thread
From: Frederic Weisbecker @ 2013-01-26 16:24 UTC (permalink / raw)
To: anish kumar
Cc: rostedt, linux-kernel, peterz, akpm, paul.gortmaker, tglx, mingo
2012/11/3 anish kumar <anish198519851985@gmail.com>:
> From: anish kumar <anish198519851985@gmail.com>
>
> As no one is using the return value of irq_work_queue function
> it is better to just make it void.
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: anish kumar <anish198519851985@gmail.com>
> ---
> kernel/irq_work.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> index 1588e3b..4829a31 100644
> --- a/kernel/irq_work.c
> +++ b/kernel/irq_work.c
> @@ -79,17 +79,16 @@ static void __irq_work_queue(struct irq_work *work)
> *
> * Can be re-enqueued while the callback is still in progress.
> */
> -bool irq_work_queue(struct irq_work *work)
> +void irq_work_queue(struct irq_work *work)
Please also update the headers in include/linux/irq_work.h accordingly.
Thanks.
> {
> if (!irq_work_claim(work)) {
> /*
> * Already enqueued, can't do!
> */
> - return false;
> + return;
> }
>
> __irq_work_queue(work);
> - return true;
> }
> EXPORT_SYMBOL_GPL(irq_work_queue);
>
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] IRQ CORE: irq_work_queue function return value not used.
2013-01-26 16:24 ` Frederic Weisbecker
@ 2013-02-02 3:14 ` anish kumar
2013-02-02 4:33 ` Frederic Weisbecker
0 siblings, 1 reply; 7+ messages in thread
From: anish kumar @ 2013-02-02 3:14 UTC (permalink / raw)
To: Frederic Weisbecker
Cc: rostedt, linux-kernel, peterz, akpm, paul.gortmaker, tglx, mingo
On Sat, 2013-01-26 at 17:24 +0100, Frederic Weisbecker wrote:
> 2012/11/3 anish kumar <anish198519851985@gmail.com>:
> > From: anish kumar <anish198519851985@gmail.com>
> >
> > As no one is using the return value of irq_work_queue function
> > it is better to just make it void.
> >
> > Acked-by: Steven Rostedt <rostedt@goodmis.org>
> > Signed-off-by: anish kumar <anish198519851985@gmail.com>
> > ---
> > kernel/irq_work.c | 5 ++---
> > 1 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> > index 1588e3b..4829a31 100644
> > --- a/kernel/irq_work.c
> > +++ b/kernel/irq_work.c
> > @@ -79,17 +79,16 @@ static void __irq_work_queue(struct irq_work *work)
> > *
> > * Can be re-enqueued while the callback is still in progress.
> > */
> > -bool irq_work_queue(struct irq_work *work)
> > +void irq_work_queue(struct irq_work *work)
>
> Please also update the headers in include/linux/irq_work.h accordingly.
I have sent the patch again(some time back).Is it picked up?
http://www.gossamer-threads.com/lists/linux/kernel/1667796
>
> Thanks.
>
> > {
> > if (!irq_work_claim(work)) {
> > /*
> > * Already enqueued, can't do!
> > */
> > - return false;
> > + return;
> > }
> >
> > __irq_work_queue(work);
> > - return true;
> > }
> > EXPORT_SYMBOL_GPL(irq_work_queue);
> >
> > --
> > 1.7.1
> >
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] IRQ CORE: irq_work_queue function return value not used.
2013-02-02 3:14 ` anish kumar
@ 2013-02-02 4:33 ` Frederic Weisbecker
0 siblings, 0 replies; 7+ messages in thread
From: Frederic Weisbecker @ 2013-02-02 4:33 UTC (permalink / raw)
To: anish kumar
Cc: rostedt, linux-kernel, peterz, akpm, paul.gortmaker, tglx, mingo
2013/2/2 anish kumar <anish198519851985@gmail.com>:
> On Sat, 2013-01-26 at 17:24 +0100, Frederic Weisbecker wrote:
>> 2012/11/3 anish kumar <anish198519851985@gmail.com>:
>> > From: anish kumar <anish198519851985@gmail.com>
>> >
>> > As no one is using the return value of irq_work_queue function
>> > it is better to just make it void.
>> >
>> > Acked-by: Steven Rostedt <rostedt@goodmis.org>
>> > Signed-off-by: anish kumar <anish198519851985@gmail.com>
>> > ---
>> > kernel/irq_work.c | 5 ++---
>> > 1 files changed, 2 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/kernel/irq_work.c b/kernel/irq_work.c
>> > index 1588e3b..4829a31 100644
>> > --- a/kernel/irq_work.c
>> > +++ b/kernel/irq_work.c
>> > @@ -79,17 +79,16 @@ static void __irq_work_queue(struct irq_work *work)
>> > *
>> > * Can be re-enqueued while the callback is still in progress.
>> > */
>> > -bool irq_work_queue(struct irq_work *work)
>> > +void irq_work_queue(struct irq_work *work)
>>
>> Please also update the headers in include/linux/irq_work.h accordingly.
> I have sent the patch again(some time back).Is it picked up?
> http://www.gossamer-threads.com/lists/linux/kernel/1667796
Yep, I'm applying it and if it passes basic tests I'll relay it to Ingo.
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-02-02 4:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-02 13:24 [PATCH] IRQ CORE: irq_work_queue function return value not used anish kumar
2012-11-02 13:43 ` Steven Rostedt
2012-11-02 21:49 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2012-11-03 8:57 anish kumar
2013-01-26 16:24 ` Frederic Weisbecker
2013-02-02 3:14 ` anish kumar
2013-02-02 4:33 ` Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox