From: Keith Busch <keith.busch@intel.com>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: Nicholas Krause <xerofoify@gmail.com>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] block:Remove including of the header file, linux/mm.h for the file,nvme-core.c
Date: Wed, 13 May 2015 17:12:10 +0000 (UTC) [thread overview]
Message-ID: <alpine.LNX.2.00.1505131704410.15930@localhost.lm.intel.com> (raw)
In-Reply-To: <20150513164945.GX4003@linux.intel.com>
On Wed, 13 May 2015, Matthew Wilcox wrote:
> On Wed, May 13, 2015 at 12:21:18PM -0400, Nicholas Krause wrote:
>> This removes the include statement for including the header file,
>> linux/mm.h in the file, nvme-core.c due this driver file never
>> calling any functions from the header file, linux/mm.h and
>> only adding bloat to this driver by including this unnessary
>> header file.
>
> Nick, I'm not going to apply this patch, simply because the effort of
> verifying that you haven't made a mistake is greater than the gain we
> might get from applying it.
The driver does use functions defined in linux/mm.h: get_user_pages_fast
is one of them. It compiles without including the header because another
we include includes mm.h, but we don't want to depend on that!
Don't worry, I didn't waste time checking; I just happened to know that
one off the top.
prev parent reply other threads:[~2015-05-13 17:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1431534078-17740-1-git-send-email-xerofoify@gmail.com>
2015-05-13 16:49 ` [PATCH] block:Remove including of the header file, linux/mm.h for the file,nvme-core.c Matthew Wilcox
2015-05-13 17:12 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1505131704410.15930@localhost.lm.intel.com \
--to=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=willy@linux.intel.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox