* Re: [PATCH] block:Remove including of the header file, linux/mm.h for the file,nvme-core.c [not found] <1431534078-17740-1-git-send-email-xerofoify@gmail.com> @ 2015-05-13 16:49 ` Matthew Wilcox 2015-05-13 17:12 ` Keith Busch 0 siblings, 1 reply; 2+ messages in thread From: Matthew Wilcox @ 2015-05-13 16:49 UTC (permalink / raw) To: Nicholas Krause; +Cc: linux-nvme, linux-kernel On Wed, May 13, 2015 at 12:21:18PM -0400, Nicholas Krause wrote: > This removes the include statement for including the header file, > linux/mm.h in the file, nvme-core.c due this driver file never > calling any functions from the header file, linux/mm.h and > only adding bloat to this driver by including this unnessary > header file. Nick, I'm not going to apply this patch, simply because the effort of verifying that you haven't made a mistake is greater than the gain we might get from applying it. Your earlier patch shows that you haven't actually learned anything since I first heard about your patches. Please, continue learning before submitting more patches. ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] block:Remove including of the header file, linux/mm.h for the file,nvme-core.c 2015-05-13 16:49 ` [PATCH] block:Remove including of the header file, linux/mm.h for the file,nvme-core.c Matthew Wilcox @ 2015-05-13 17:12 ` Keith Busch 0 siblings, 0 replies; 2+ messages in thread From: Keith Busch @ 2015-05-13 17:12 UTC (permalink / raw) To: Matthew Wilcox; +Cc: Nicholas Krause, linux-kernel, linux-nvme On Wed, 13 May 2015, Matthew Wilcox wrote: > On Wed, May 13, 2015 at 12:21:18PM -0400, Nicholas Krause wrote: >> This removes the include statement for including the header file, >> linux/mm.h in the file, nvme-core.c due this driver file never >> calling any functions from the header file, linux/mm.h and >> only adding bloat to this driver by including this unnessary >> header file. > > Nick, I'm not going to apply this patch, simply because the effort of > verifying that you haven't made a mistake is greater than the gain we > might get from applying it. The driver does use functions defined in linux/mm.h: get_user_pages_fast is one of them. It compiles without including the header because another we include includes mm.h, but we don't want to depend on that! Don't worry, I didn't waste time checking; I just happened to know that one off the top. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-13 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1431534078-17740-1-git-send-email-xerofoify@gmail.com>
2015-05-13 16:49 ` [PATCH] block:Remove including of the header file, linux/mm.h for the file,nvme-core.c Matthew Wilcox
2015-05-13 17:12 ` Keith Busch
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox