* [PATCH v3] Documentation/core-api: min_heap: remove documented but unimplemented min_heap_empty()
@ 2026-07-21 18:43 Jyun-An Chen
2026-07-21 20:12 ` Randy Dunlap
2026-07-22 4:19 ` Kuan-Wei Chiu
0 siblings, 2 replies; 3+ messages in thread
From: Jyun-An Chen @ 2026-07-21 18:43 UTC (permalink / raw)
To: Kuan-Wei Chiu
Cc: Jyun-An Chen, Jonathan Corbet, Shuah Khan, open list:MIN HEAP,
open list:DOCUMENTATION
min_heap_empty()/min_heap_empty_inline() are documented as part of
the Min Heap API, but no such functions or macros exist in
include/linux/min_heap.h or lib/min_heap.c. Remove the stale
description instead of adding unused API surface.
Signed-off-by: Jyun-An Chen <jun930436@gmail.com>
Acked-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
Changes since v2:
- Fixed subject line.
Documentation/core-api/min_heap.rst | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/Documentation/core-api/min_heap.rst b/Documentation/core-api/min_heap.rst
index 9f57766581df..919dcf1bdec7 100644
--- a/Documentation/core-api/min_heap.rst
+++ b/Documentation/core-api/min_heap.rst
@@ -240,19 +240,6 @@ This macro returns `true` if the heap is full, otherwise `false`.
**Inline Version:** min_heap_full_inline(heap)
-- **min_heap_empty(heap)**: Checks whether the heap is empty.
- Complexity: **O(1)**.
-
-.. code-block:: c
-
- bool empty = min_heap_empty(heap);
-
-- `heap`: A pointer to the min-heap to check.
-
-This macro returns `true` if the heap is empty, otherwise `false`.
-
-**Inline Version:** min_heap_empty_inline(heap)
-
Example Usage
=============
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] Documentation/core-api: min_heap: remove documented but unimplemented min_heap_empty()
2026-07-21 18:43 [PATCH v3] Documentation/core-api: min_heap: remove documented but unimplemented min_heap_empty() Jyun-An Chen
@ 2026-07-21 20:12 ` Randy Dunlap
2026-07-22 4:19 ` Kuan-Wei Chiu
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2026-07-21 20:12 UTC (permalink / raw)
To: Jyun-An Chen, Kuan-Wei Chiu
Cc: Jonathan Corbet, Shuah Khan, open list:MIN HEAP,
open list:DOCUMENTATION
On 7/21/26 11:43 AM, Jyun-An Chen wrote:
> min_heap_empty()/min_heap_empty_inline() are documented as part of
> the Min Heap API, but no such functions or macros exist in
> include/linux/min_heap.h or lib/min_heap.c. Remove the stale
> description instead of adding unused API surface.
>
> Signed-off-by: Jyun-An Chen <jun930436@gmail.com>
> Acked-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> Changes since v2:
> - Fixed subject line.
>
> Documentation/core-api/min_heap.rst | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/Documentation/core-api/min_heap.rst b/Documentation/core-api/min_heap.rst
> index 9f57766581df..919dcf1bdec7 100644
> --- a/Documentation/core-api/min_heap.rst
> +++ b/Documentation/core-api/min_heap.rst
> @@ -240,19 +240,6 @@ This macro returns `true` if the heap is full, otherwise `false`.
>
> **Inline Version:** min_heap_full_inline(heap)
>
> -- **min_heap_empty(heap)**: Checks whether the heap is empty.
> - Complexity: **O(1)**.
> -
> -.. code-block:: c
> -
> - bool empty = min_heap_empty(heap);
> -
> -- `heap`: A pointer to the min-heap to check.
> -
> -This macro returns `true` if the heap is empty, otherwise `false`.
> -
> -**Inline Version:** min_heap_empty_inline(heap)
> -
> Example Usage
> =============
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] Documentation/core-api: min_heap: remove documented but unimplemented min_heap_empty()
2026-07-21 18:43 [PATCH v3] Documentation/core-api: min_heap: remove documented but unimplemented min_heap_empty() Jyun-An Chen
2026-07-21 20:12 ` Randy Dunlap
@ 2026-07-22 4:19 ` Kuan-Wei Chiu
1 sibling, 0 replies; 3+ messages in thread
From: Kuan-Wei Chiu @ 2026-07-22 4:19 UTC (permalink / raw)
To: Jyun-An Chen
Cc: Jonathan Corbet, Shuah Khan, open list:MIN HEAP,
open list:DOCUMENTATION
On Tue, Jul 21, 2026 at 06:43:34PM +0000, Jyun-An Chen wrote:
> min_heap_empty()/min_heap_empty_inline() are documented as part of
> the Min Heap API, but no such functions or macros exist in
> include/linux/min_heap.h or lib/min_heap.c. Remove the stale
> description instead of adding unused API surface.
I think we can drop the last clause "instead of adding unused API
surface". It reads like unnecessary AI generated text.
Regards,
Kuan-Wei
>
> Signed-off-by: Jyun-An Chen <jun930436@gmail.com>
> Acked-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> ---
> Changes since v2:
> - Fixed subject line.
>
> Documentation/core-api/min_heap.rst | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/Documentation/core-api/min_heap.rst b/Documentation/core-api/min_heap.rst
> index 9f57766581df..919dcf1bdec7 100644
> --- a/Documentation/core-api/min_heap.rst
> +++ b/Documentation/core-api/min_heap.rst
> @@ -240,19 +240,6 @@ This macro returns `true` if the heap is full, otherwise `false`.
>
> **Inline Version:** min_heap_full_inline(heap)
>
> -- **min_heap_empty(heap)**: Checks whether the heap is empty.
> - Complexity: **O(1)**.
> -
> -.. code-block:: c
> -
> - bool empty = min_heap_empty(heap);
> -
> -- `heap`: A pointer to the min-heap to check.
> -
> -This macro returns `true` if the heap is empty, otherwise `false`.
> -
> -**Inline Version:** min_heap_empty_inline(heap)
> -
> Example Usage
> =============
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-22 4:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-21 18:43 [PATCH v3] Documentation/core-api: min_heap: remove documented but unimplemented min_heap_empty() Jyun-An Chen
2026-07-21 20:12 ` Randy Dunlap
2026-07-22 4:19 ` Kuan-Wei Chiu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox