* [PATCH] Input: psxpad-spi - set driver data before use
@ 2026-07-21 5:55 Linmao Li
2026-07-25 1:46 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Linmao Li @ 2026-07-21 5:55 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Haotian Zhang, Tomohiro Yoshidomi, David Rheinsberg, linux-input,
linux-kernel, Linmao Li, stable
psxpad_spi_suspend() retrieves the controller state with
spi_get_drvdata(), but probe never stores it, so suspend dereferences a
NULL pointer. Store it during probe.
Fixes: 8be193c7b1f4 ("Input: add support for PlayStation 1/2 joypads connected via SPI")
Cc: stable@vger.kernel.org
Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
---
drivers/input/joystick/psxpad-spi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/joystick/psxpad-spi.c b/drivers/input/joystick/psxpad-spi.c
index f902a56d011f..b1ab2486bb0d 100644
--- a/drivers/input/joystick/psxpad-spi.c
+++ b/drivers/input/joystick/psxpad-spi.c
@@ -301,6 +301,7 @@ static int psxpad_spi_probe(struct spi_device *spi)
/* input poll device settings */
pad->idev = idev;
pad->spi = spi;
+ spi_set_drvdata(spi, pad);
/* input device settings */
input_set_drvdata(idev, pad);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: psxpad-spi - set driver data before use
2026-07-21 5:55 [PATCH] Input: psxpad-spi - set driver data before use Linmao Li
@ 2026-07-25 1:46 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2026-07-25 1:46 UTC (permalink / raw)
To: Linmao Li
Cc: Haotian Zhang, Tomohiro Yoshidomi, David Rheinsberg, linux-input,
linux-kernel, stable
Hi Linmao,
On Tue, Jul 21, 2026 at 01:55:51PM +0800, Linmao Li wrote:
> psxpad_spi_suspend() retrieves the controller state with
> spi_get_drvdata(), but probe never stores it, so suspend dereferences a
> NULL pointer. Store it during probe.
>
> Fixes: 8be193c7b1f4 ("Input: add support for PlayStation 1/2 joypads connected via SPI")
> Cc: stable@vger.kernel.org
> Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
> ---
> drivers/input/joystick/psxpad-spi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/joystick/psxpad-spi.c b/drivers/input/joystick/psxpad-spi.c
> index f902a56d011f..b1ab2486bb0d 100644
> --- a/drivers/input/joystick/psxpad-spi.c
> +++ b/drivers/input/joystick/psxpad-spi.c
> @@ -301,6 +301,7 @@ static int psxpad_spi_probe(struct spi_device *spi)
> /* input poll device settings */
> pad->idev = idev;
> pad->spi = spi;
> + spi_set_drvdata(spi, pad);
I moved the assignment to the end of probe and applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-25 1:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-21 5:55 [PATCH] Input: psxpad-spi - set driver data before use Linmao Li
2026-07-25 1:46 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox