From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Zhefu Zhang <a723356@gmail.com>
Cc: Andrew Zhou <zhoulol888@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Input: atkbd - skip deactivate for Xiaomi Book Pro 14's internal keyboard
Date: Sun, 2 Aug 2026 15:44:46 -0700 [thread overview]
Message-ID: <am_IWayJyJYhMJnb@google.com> (raw)
In-Reply-To: <20260802031559.19701-1-a723356@gmail.com>
On Sun, Aug 02, 2026 at 03:15:59PM +1200, Zhefu Zhang wrote:
> The internal keyboard of the Xiaomi Book Pro 14 does not work unless
> atkbd skips deactivating it at the end of atkbd_probe().
>
> Using 'i8042.dumbkbd=1' also makes the keyboard work, but then the driver
> never writes to the keyboard at all, so the Caps Lock LED is lost. The
> atkbd_deactivate_fixup quirk fixes both without a boot parameter.
>
> DMI: XIAOMI Xiaomi Book Pro 14/TM2424, BIOS XMAPT4B0P0909 05/06/2026
>
> Signed-off-by: Zhefu Zhang <a723356@gmail.com>
> Reviewed-by: Andrew Zhou <zhoulol888@gmail.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2026-08-02 22:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 10:19 [PATCH] Input: atkbd - skip deactivate for Xiaomi Book Pro 14's internal keyboard Zhefu Zhang
2026-08-02 3:15 ` [PATCH v2] " Zhefu Zhang
2026-08-02 22:44 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=am_IWayJyJYhMJnb@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=a723356@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhoulol888@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox