* linux-next: build failure after merge of the paulmck tree
@ 2024-06-19 13:49 Mark Brown
2024-06-19 17:29 ` Paul E. McKenney
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2024-06-19 13:49 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1901 bytes --]
Hi all,
After merging the paulmck tree, today's linux-next build (arm64
defconfig) failed like this:
/tmp/next/build/kernel/time/clocksource.c: In function '__clocksource_update_freq_scale':
/tmp/next/build/kernel/time/clocksource.c:136:25: error: 'CONFIG_CLOCKSOURCE_WATCHDOG_MAX_SKEW_US' undeclared (first use in this function)
136 | #define MAX_SKEW_USEC CONFIG_CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/next/build/kernel/time/clocksource.c:136:25: note: in definition of macro 'MAX_SKEW_USEC'
136 | #define MAX_SKEW_USEC CONFIG_CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/next/build/kernel/time/clocksource.c:1167:50: note: in expansion of macro 'WATCHDOG_MAX_SKEW'
1167 | if (cs->uncertainty_margin < 2 * WATCHDOG_MAX_SKEW)
| ^~~~~~~~~~~~~~~~~
/tmp/next/build/kernel/time/clocksource.c:136:25: note: each undeclared identifier is reported only once for each function it appears in
136 | #define MAX_SKEW_USEC CONFIG_CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/next/build/kernel/time/clocksource.c:136:25: note: in definition of macro 'MAX_SKEW_USEC'
136 | #define MAX_SKEW_USEC CONFIG_CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/next/build/kernel/time/clocksource.c:1167:50: note: in expansion of macro 'WATCHDOG_MAX_SKEW'
1167 | if (cs->uncertainty_margin < 2 * WATCHDOG_MAX_SKEW)
| ^~~~~~~~~~~~~~~~~
Caused by commit
5800c05045dbfe ("clocksource: Take advantage of always-defined CLOCKSOURCE_WATCHDOG_MAX_SKEW_US")
I have used the tree from yesterday instead.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build failure after merge of the paulmck tree
2024-06-19 13:49 Mark Brown
@ 2024-06-19 17:29 ` Paul E. McKenney
0 siblings, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2024-06-19 17:29 UTC (permalink / raw)
To: Mark Brown; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
On Wed, Jun 19, 2024 at 02:49:30PM +0100, Mark Brown wrote:
> Hi all,
>
> After merging the paulmck tree, today's linux-next build (arm64
> defconfig) failed like this:
>
> /tmp/next/build/kernel/time/clocksource.c: In function '__clocksource_update_freq_scale':
> /tmp/next/build/kernel/time/clocksource.c:136:25: error: 'CONFIG_CLOCKSOURCE_WATCHDOG_MAX_SKEW_US' undeclared (first use in this function)
> 136 | #define MAX_SKEW_USEC CONFIG_CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/kernel/time/clocksource.c:136:25: note: in definition of macro 'MAX_SKEW_USEC'
> 136 | #define MAX_SKEW_USEC CONFIG_CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/kernel/time/clocksource.c:1167:50: note: in expansion of macro 'WATCHDOG_MAX_SKEW'
> 1167 | if (cs->uncertainty_margin < 2 * WATCHDOG_MAX_SKEW)
> | ^~~~~~~~~~~~~~~~~
> /tmp/next/build/kernel/time/clocksource.c:136:25: note: each undeclared identifier is reported only once for each function it appears in
> 136 | #define MAX_SKEW_USEC CONFIG_CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/kernel/time/clocksource.c:136:25: note: in definition of macro 'MAX_SKEW_USEC'
> 136 | #define MAX_SKEW_USEC CONFIG_CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/kernel/time/clocksource.c:1167:50: note: in expansion of macro 'WATCHDOG_MAX_SKEW'
> 1167 | if (cs->uncertainty_margin < 2 * WATCHDOG_MAX_SKEW)
> | ^~~~~~~~~~~~~~~~~
>
>
> Caused by commit
>
> 5800c05045dbfe ("clocksource: Take advantage of always-defined CLOCKSOURCE_WATCHDOG_MAX_SKEW_US")
>
> I have used the tree from yesterday instead.
And that commit looked so good! ;-)
Thank you for catching this. I have dropped that commit. I missed that
WATCHDOG_MAX_SKEW is used even when the clocksource watchdog is not
enabled. :-/
Thanx, Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* linux-next: build failure after merge of the paulmck tree
@ 2026-07-31 14:49 Mark Brown
2026-07-31 16:15 ` Paul E. McKenney
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2026-07-31 14:49 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 5653 bytes --]
Hi all,
After merging the paulmck tree, today's linux-next build
(arm64 allnoconfig) failed like this:
In file included from /tmp/next/build/arch/arm64/include/asm/rwonce.h:81,
from /tmp/next/build/include/linux/compiler.h:369,
from /tmp/next/build/include/linux/proc_fs.h:8,
from /tmp/next/build/kernel/time/timer_list.c:8:
/tmp/next/build/kernel/time/timer_list.c: In function 'print_base':
/tmp/next/build/include/asm-generic/rwonce.h:44:71: error: lvalue required as unary '&' operand
44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
| ^
/tmp/next/build/include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
50 | __READ_ONCE(x); \
| ^~~~~~~~~~~
/tmp/next/build/kernel/time/timer_list.c:102:52: note: in expansion of macro 'READ_ONCE'
102 | SEQ_printf(m, " .resolution: %u nsecs\n", READ_ONCE(hrtimer_resolution));
| ^~~~~~~~~
make[5]: *** [/tmp/next/build/scripts/Makefile.build:290: kernel/time/timer_list.o] Error 1
make[5]: *** Waiting for unfinished jobs....
In file included from /tmp/next/build/arch/arm64/include/asm/rwonce.h:81,
from /tmp/next/build/include/linux/compiler.h:369,
from /tmp/next/build/include/linux/build_bug.h:5,
from /tmp/next/build/include/linux/bits.h:30,
from /tmp/next/build/include/linux/bitops.h:6,
from /tmp/next/build/arch/arm64/include/asm/cache.h:40,
from /tmp/next/build/include/vdso/cache.h:5,
from /tmp/next/build/include/linux/cache.h:6,
from /tmp/next/build/include/linux/time.h:5,
from /tmp/next/build/kernel/time/alarmtimer.c:15:
/tmp/next/build/kernel/time/alarmtimer.c: In function 'alarm_clock_getres':
/tmp/next/build/include/asm-generic/rwonce.h:44:71: error: lvalue required as unary '&' operand
44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
| ^
/tmp/next/build/include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
50 | __READ_ONCE(x); \
| ^~~~~~~~~~~
/tmp/next/build/kernel/time/alarmtimer.c:606:23: note: in expansion of macro 'READ_ONCE'
606 | tp->tv_nsec = READ_ONCE(hrtimer_resolution);
| ^~~~~~~~~
make[5]: *** [/tmp/next/build/scripts/Makefile.build:290: kernel/time/alarmtimer.o] Error 1
In file included from /tmp/next/build/arch/arm64/include/asm/rwonce.h:81,
from /tmp/next/build/include/linux/compiler.h:369,
from /tmp/next/build/include/linux/dev_printk.h:14,
from /tmp/next/build/include/linux/device.h:15,
from /tmp/next/build/include/linux/node.h:18,
from /tmp/next/build/include/linux/cpu.h:17,
from /tmp/next/build/kernel/time/hrtimer.c:25:
/tmp/next/build/kernel/time/hrtimer.c: In function 'hrtimer_forward':
/tmp/next/build/include/asm-generic/rwonce.h:44:71: error: lvalue required as unary '&' operand
44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
| ^
/tmp/next/build/include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
50 | __READ_ONCE(x); \
| ^~~~~~~~~~~
/tmp/next/build/kernel/time/hrtimer.c:1100:15: note: in expansion of macro 'READ_ONCE'
1100 | res = READ_ONCE(hrtimer_resolution);
| ^~~~~~~~~
make[5]: *** [/tmp/next/build/scripts/Makefile.build:290: kernel/time/hrtimer.o] Error 1
In file included from /tmp/next/build/arch/arm64/include/asm/rwonce.h:81,
from /tmp/next/build/include/linux/compiler.h:369,
from /tmp/next/build/include/linux/build_bug.h:5,
from /tmp/next/build/include/linux/bits.h:30,
from /tmp/next/build/include/linux/bitops.h:6,
from /tmp/next/build/arch/arm64/include/asm/cache.h:40,
from /tmp/next/build/include/vdso/cache.h:5,
from /tmp/next/build/include/linux/cache.h:6,
from /tmp/next/build/include/linux/time.h:5,
from /tmp/next/build/include/linux/compat.h:10,
from /tmp/next/build/kernel/time/posix-timers.c:12:
/tmp/next/build/kernel/time/posix-timers.c: In function 'posix_get_hrtimer_res':
/tmp/next/build/include/asm-generic/rwonce.h:44:71: error: lvalue required as unary '&' operand
44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
| ^
/tmp/next/build/include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
50 | __READ_ONCE(x); \
| ^~~~~~~~~~~
/tmp/next/build/kernel/time/posix-timers.c:275:23: note: in expansion of macro 'READ_ONCE'
275 | tp->tv_nsec = READ_ONCE(hrtimer_resolution);
| ^~~~~~~~~
Caused by commit
84f2a4fba1353 (hrtimer: Apply {READ,WRITE}_ONCE() to hrtimer_resolution accesses)
I used the tree from next-20260730 instead.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build failure after merge of the paulmck tree
2026-07-31 14:49 linux-next: build failure after merge of the paulmck tree Mark Brown
@ 2026-07-31 16:15 ` Paul E. McKenney
0 siblings, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2026-07-31 16:15 UTC (permalink / raw)
To: Mark Brown; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
On Fri, Jul 31, 2026 at 03:49:38PM +0100, Mark Brown wrote:
> Hi all,
>
> After merging the paulmck tree, today's linux-next build
> (arm64 allnoconfig) failed like this:
>
> In file included from /tmp/next/build/arch/arm64/include/asm/rwonce.h:81,
> from /tmp/next/build/include/linux/compiler.h:369,
> from /tmp/next/build/include/linux/proc_fs.h:8,
> from /tmp/next/build/kernel/time/timer_list.c:8:
> /tmp/next/build/kernel/time/timer_list.c: In function 'print_base':
> /tmp/next/build/include/asm-generic/rwonce.h:44:71: error: lvalue required as unary '&' operand
> 44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
> | ^
> /tmp/next/build/include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
> 50 | __READ_ONCE(x); \
> | ^~~~~~~~~~~
> /tmp/next/build/kernel/time/timer_list.c:102:52: note: in expansion of macro 'READ_ONCE'
> 102 | SEQ_printf(m, " .resolution: %u nsecs\n", READ_ONCE(hrtimer_resolution));
> | ^~~~~~~~~
> make[5]: *** [/tmp/next/build/scripts/Makefile.build:290: kernel/time/timer_list.o] Error 1
> make[5]: *** Waiting for unfinished jobs....
> In file included from /tmp/next/build/arch/arm64/include/asm/rwonce.h:81,
> from /tmp/next/build/include/linux/compiler.h:369,
> from /tmp/next/build/include/linux/build_bug.h:5,
> from /tmp/next/build/include/linux/bits.h:30,
> from /tmp/next/build/include/linux/bitops.h:6,
> from /tmp/next/build/arch/arm64/include/asm/cache.h:40,
> from /tmp/next/build/include/vdso/cache.h:5,
> from /tmp/next/build/include/linux/cache.h:6,
> from /tmp/next/build/include/linux/time.h:5,
> from /tmp/next/build/kernel/time/alarmtimer.c:15:
> /tmp/next/build/kernel/time/alarmtimer.c: In function 'alarm_clock_getres':
> /tmp/next/build/include/asm-generic/rwonce.h:44:71: error: lvalue required as unary '&' operand
> 44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
> | ^
> /tmp/next/build/include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
> 50 | __READ_ONCE(x); \
> | ^~~~~~~~~~~
> /tmp/next/build/kernel/time/alarmtimer.c:606:23: note: in expansion of macro 'READ_ONCE'
> 606 | tp->tv_nsec = READ_ONCE(hrtimer_resolution);
> | ^~~~~~~~~
> make[5]: *** [/tmp/next/build/scripts/Makefile.build:290: kernel/time/alarmtimer.o] Error 1
> In file included from /tmp/next/build/arch/arm64/include/asm/rwonce.h:81,
> from /tmp/next/build/include/linux/compiler.h:369,
> from /tmp/next/build/include/linux/dev_printk.h:14,
> from /tmp/next/build/include/linux/device.h:15,
> from /tmp/next/build/include/linux/node.h:18,
> from /tmp/next/build/include/linux/cpu.h:17,
> from /tmp/next/build/kernel/time/hrtimer.c:25:
> /tmp/next/build/kernel/time/hrtimer.c: In function 'hrtimer_forward':
> /tmp/next/build/include/asm-generic/rwonce.h:44:71: error: lvalue required as unary '&' operand
> 44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
> | ^
> /tmp/next/build/include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
> 50 | __READ_ONCE(x); \
> | ^~~~~~~~~~~
> /tmp/next/build/kernel/time/hrtimer.c:1100:15: note: in expansion of macro 'READ_ONCE'
> 1100 | res = READ_ONCE(hrtimer_resolution);
> | ^~~~~~~~~
> make[5]: *** [/tmp/next/build/scripts/Makefile.build:290: kernel/time/hrtimer.o] Error 1
> In file included from /tmp/next/build/arch/arm64/include/asm/rwonce.h:81,
> from /tmp/next/build/include/linux/compiler.h:369,
> from /tmp/next/build/include/linux/build_bug.h:5,
> from /tmp/next/build/include/linux/bits.h:30,
> from /tmp/next/build/include/linux/bitops.h:6,
> from /tmp/next/build/arch/arm64/include/asm/cache.h:40,
> from /tmp/next/build/include/vdso/cache.h:5,
> from /tmp/next/build/include/linux/cache.h:6,
> from /tmp/next/build/include/linux/time.h:5,
> from /tmp/next/build/include/linux/compat.h:10,
> from /tmp/next/build/kernel/time/posix-timers.c:12:
> /tmp/next/build/kernel/time/posix-timers.c: In function 'posix_get_hrtimer_res':
> /tmp/next/build/include/asm-generic/rwonce.h:44:71: error: lvalue required as unary '&' operand
> 44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
> | ^
> /tmp/next/build/include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
> 50 | __READ_ONCE(x); \
> | ^~~~~~~~~~~
> /tmp/next/build/kernel/time/posix-timers.c:275:23: note: in expansion of macro 'READ_ONCE'
> 275 | tp->tv_nsec = READ_ONCE(hrtimer_resolution);
> | ^~~~~~~~~
>
> Caused by commit
>
> 84f2a4fba1353 (hrtimer: Apply {READ,WRITE}_ONCE() to hrtimer_resolution accesses)
>
> I used the tree from next-20260730 instead.
I will drop/fix this one, apologies.
Thanx, Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-07-31 16:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-31 14:49 linux-next: build failure after merge of the paulmck tree Mark Brown
2026-07-31 16:15 ` Paul E. McKenney
-- strict thread matches above, loose matches on Subject: below --
2024-06-19 13:49 Mark Brown
2024-06-19 17:29 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox