The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] drm/xe: tests: fix error message in xe_migrate_sanity_test()
@ 2026-08-13  7:09 Dan Carpenter
  2026-08-13 13:39 ` Rodrigo Vivi
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2026-08-13  7:09 UTC (permalink / raw)
  To: Matthew Brost
  Cc: Thomas Hellström, Rodrigo Vivi, David Airlie, Simona Vetter,
	Matt Roper, Matthew Auld, Xin Wang, Balasubramani Vivekanandan,
	intel-xe, dri-devel, linux-kernel, kernel-janitors

This is supposed to print the error code but there is a copy and
paste bug so it prints "bo" instead of "err".

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
 drivers/gpu/drm/xe/tests/xe_migrate.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/tests/xe_migrate.c b/drivers/gpu/drm/xe/tests/xe_migrate.c
index 3c1be809be82..f10d9513747b 100644
--- a/drivers/gpu/drm/xe/tests/xe_migrate.c
+++ b/drivers/gpu/drm/xe/tests/xe_migrate.c
@@ -198,8 +198,7 @@ static void xe_migrate_sanity_test(struct xe_migrate *m, struct kunit *test,
 
 	err = xe_bo_vmap(bo);
 	if (err) {
-		KUNIT_FAIL(test, "Failed to vmap our pagetables: %li\n",
-			   PTR_ERR(bo));
+		KUNIT_FAIL(test, "Failed to vmap our pagetables: %d\n", err);
 		return;
 	}
 
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/xe: tests: fix error message in xe_migrate_sanity_test()
  2026-08-13  7:09 [PATCH] drm/xe: tests: fix error message in xe_migrate_sanity_test() Dan Carpenter
@ 2026-08-13 13:39 ` Rodrigo Vivi
  0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Vivi @ 2026-08-13 13:39 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Matthew Brost, Thomas Hellström, David Airlie, Simona Vetter,
	Matt Roper, Matthew Auld, Xin Wang, Balasubramani Vivekanandan,
	intel-xe, dri-devel, linux-kernel, kernel-janitors

On Thu, Aug 13, 2026 at 10:09:47AM +0300, Dan Carpenter wrote:
> This is supposed to print the error code but there is a copy and
> paste bug so it prints "bo" instead of "err".
> 
> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
> Signed-off-by: Dan Carpenter <error27@gmail.com>

pushed, thanks for the fix

> ---
>  drivers/gpu/drm/xe/tests/xe_migrate.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/tests/xe_migrate.c b/drivers/gpu/drm/xe/tests/xe_migrate.c
> index 3c1be809be82..f10d9513747b 100644
> --- a/drivers/gpu/drm/xe/tests/xe_migrate.c
> +++ b/drivers/gpu/drm/xe/tests/xe_migrate.c
> @@ -198,8 +198,7 @@ static void xe_migrate_sanity_test(struct xe_migrate *m, struct kunit *test,
>  
>  	err = xe_bo_vmap(bo);
>  	if (err) {
> -		KUNIT_FAIL(test, "Failed to vmap our pagetables: %li\n",
> -			   PTR_ERR(bo));
> +		KUNIT_FAIL(test, "Failed to vmap our pagetables: %d\n", err);
>  		return;
>  	}
>  
> -- 
> 2.53.0
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-13 13:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-13  7:09 [PATCH] drm/xe: tests: fix error message in xe_migrate_sanity_test() Dan Carpenter
2026-08-13 13:39 ` Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox