The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Marcelo Mendes Spessoto Junior <marcelomspessoto@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Shuah Khan" <shuah@kernel.org>,
	"Andreas Färber" <afaerber@suse.de>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-actions@lists.infradead.org
Subject: Re: [PATCH net-next] selftests: net: separate ipv6_flowlabel_mgr test
Date: Fri, 14 Aug 2026 10:03:14 +0800	[thread overview]
Message-ID: <an53YmW_owzL5-_E@fedora> (raw)
In-Reply-To: <20260813030708.37609-1-marcelomspessoto@gmail.com>

On Thu, Aug 13, 2026 at 12:07:05AM -0300, Marcelo Mendes Spessoto Junior wrote:
> The ipv6_flowlabel_mgr used to be a component of a broader overall
> flow label test, defined in the ipv6_flowlabel.sh file. This wrapper
> script called tests defined on ipv6_flowlabel.c and
> ipv6_flowlabel_mgr.c files, using predefined parameters and enforcing
> the in_netns.sh helper to set network namespaces for each test env.
> 
> However, the ipv6_flowlabel_mgr.c was drastically changed recently.
> These modifications led to the mgr tests becoming a self contained and
> independent test suite, enforcing netns creation by itself and
> not relying on the ipv6_flowlabel.sh wrapper for proper test execution
> anymore. Therefore, remove the mgr tests from the wrapper and update
> the Makefile to handle it as a standalone test program instead.
> 
> Signed-off-by: Marcelo Mendes Spessoto Junior <marcelomspessoto@gmail.com>
> ---
>  tools/testing/selftests/net/Makefile          | 2 +-
>  tools/testing/selftests/net/ipv6_flowlabel.sh | 3 ---
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index ab890e6f79dd..0f5c178bc224 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -150,7 +150,6 @@ TEST_GEN_FILES := \
>  	ip_local_port_range \
>  	ipsec \
>  	ipv6_flowlabel \
> -	ipv6_flowlabel_mgr \
>  	msg_zerocopy \
>  	nettest \
>  	psock_fanout \
> @@ -183,6 +182,7 @@ TEST_GEN_PROGS := \
>  	epoll_busy_poll \
>  	getsockopt_iter \
>  	icmp_rfc4884 \
> +	ipv6_flowlabel_mgr \
>  	ipv6_fragmentation \
>  	proc_net_pktgen \
>  	reuseaddr_conflict \
> diff --git a/tools/testing/selftests/net/ipv6_flowlabel.sh b/tools/testing/selftests/net/ipv6_flowlabel.sh
> index 2eeda39bf64c..5d1b5464c54c 100755
> --- a/tools/testing/selftests/net/ipv6_flowlabel.sh
> +++ b/tools/testing/selftests/net/ipv6_flowlabel.sh
> @@ -7,9 +7,6 @@
>  
>  set -e
>  
> -echo "TEST management"
> -./ipv6_flowlabel_mgr
> -
>  echo "TEST datapath"
>  ./in_netns.sh \
>    sh -c 'sysctl -q -w net.ipv6.auto_flowlabels=0 && ./ipv6_flowlabel -l 1'
> -- 
> 2.55.0
> 

Reviewed-by: Hangbin Liu <liuhangbin@kylinos.cn>

      reply	other threads:[~2026-08-14  2:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13  3:07 [PATCH net-next] selftests: net: separate ipv6_flowlabel_mgr test Marcelo Mendes Spessoto Junior
2026-08-14  2:03 ` Hangbin Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=an53YmW_owzL5-_E@fedora \
    --to=liuhangbin@gmail.com \
    --cc=afaerber@suse.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-actions@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=marcelomspessoto@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox