The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH net-next] selftests: net: separate ipv6_flowlabel_mgr test
@ 2026-08-13  3:07 Marcelo Mendes Spessoto Junior
  2026-08-14  2:03 ` Hangbin Liu
  0 siblings, 1 reply; 2+ messages in thread
From: Marcelo Mendes Spessoto Junior @ 2026-08-13  3:07 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Simon Horman, Shuah Khan, Andreas Färber,
	Manivannan Sadhasivam, netdev, linux-kselftest, linux-kernel,
	linux-arm-kernel, linux-actions
  Cc: Marcelo Mendes Spessoto Junior

The ipv6_flowlabel_mgr used to be a component of a broader overall
flow label test, defined in the ipv6_flowlabel.sh file. This wrapper
script called tests defined on ipv6_flowlabel.c and
ipv6_flowlabel_mgr.c files, using predefined parameters and enforcing
the in_netns.sh helper to set network namespaces for each test env.

However, the ipv6_flowlabel_mgr.c was drastically changed recently.
These modifications led to the mgr tests becoming a self contained and
independent test suite, enforcing netns creation by itself and
not relying on the ipv6_flowlabel.sh wrapper for proper test execution
anymore. Therefore, remove the mgr tests from the wrapper and update
the Makefile to handle it as a standalone test program instead.

Signed-off-by: Marcelo Mendes Spessoto Junior <marcelomspessoto@gmail.com>
---
 tools/testing/selftests/net/Makefile          | 2 +-
 tools/testing/selftests/net/ipv6_flowlabel.sh | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index ab890e6f79dd..0f5c178bc224 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -150,7 +150,6 @@ TEST_GEN_FILES := \
 	ip_local_port_range \
 	ipsec \
 	ipv6_flowlabel \
-	ipv6_flowlabel_mgr \
 	msg_zerocopy \
 	nettest \
 	psock_fanout \
@@ -183,6 +182,7 @@ TEST_GEN_PROGS := \
 	epoll_busy_poll \
 	getsockopt_iter \
 	icmp_rfc4884 \
+	ipv6_flowlabel_mgr \
 	ipv6_fragmentation \
 	proc_net_pktgen \
 	reuseaddr_conflict \
diff --git a/tools/testing/selftests/net/ipv6_flowlabel.sh b/tools/testing/selftests/net/ipv6_flowlabel.sh
index 2eeda39bf64c..5d1b5464c54c 100755
--- a/tools/testing/selftests/net/ipv6_flowlabel.sh
+++ b/tools/testing/selftests/net/ipv6_flowlabel.sh
@@ -7,9 +7,6 @@
 
 set -e
 
-echo "TEST management"
-./ipv6_flowlabel_mgr
-
 echo "TEST datapath"
 ./in_netns.sh \
   sh -c 'sysctl -q -w net.ipv6.auto_flowlabels=0 && ./ipv6_flowlabel -l 1'
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] selftests: net: separate ipv6_flowlabel_mgr test
  2026-08-13  3:07 [PATCH net-next] selftests: net: separate ipv6_flowlabel_mgr test Marcelo Mendes Spessoto Junior
@ 2026-08-14  2:03 ` Hangbin Liu
  0 siblings, 0 replies; 2+ messages in thread
From: Hangbin Liu @ 2026-08-14  2:03 UTC (permalink / raw)
  To: Marcelo Mendes Spessoto Junior
  Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Simon Horman, Shuah Khan, Andreas Färber,
	Manivannan Sadhasivam, netdev, linux-kselftest, linux-kernel,
	linux-arm-kernel, linux-actions

On Thu, Aug 13, 2026 at 12:07:05AM -0300, Marcelo Mendes Spessoto Junior wrote:
> The ipv6_flowlabel_mgr used to be a component of a broader overall
> flow label test, defined in the ipv6_flowlabel.sh file. This wrapper
> script called tests defined on ipv6_flowlabel.c and
> ipv6_flowlabel_mgr.c files, using predefined parameters and enforcing
> the in_netns.sh helper to set network namespaces for each test env.
> 
> However, the ipv6_flowlabel_mgr.c was drastically changed recently.
> These modifications led to the mgr tests becoming a self contained and
> independent test suite, enforcing netns creation by itself and
> not relying on the ipv6_flowlabel.sh wrapper for proper test execution
> anymore. Therefore, remove the mgr tests from the wrapper and update
> the Makefile to handle it as a standalone test program instead.
> 
> Signed-off-by: Marcelo Mendes Spessoto Junior <marcelomspessoto@gmail.com>
> ---
>  tools/testing/selftests/net/Makefile          | 2 +-
>  tools/testing/selftests/net/ipv6_flowlabel.sh | 3 ---
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index ab890e6f79dd..0f5c178bc224 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -150,7 +150,6 @@ TEST_GEN_FILES := \
>  	ip_local_port_range \
>  	ipsec \
>  	ipv6_flowlabel \
> -	ipv6_flowlabel_mgr \
>  	msg_zerocopy \
>  	nettest \
>  	psock_fanout \
> @@ -183,6 +182,7 @@ TEST_GEN_PROGS := \
>  	epoll_busy_poll \
>  	getsockopt_iter \
>  	icmp_rfc4884 \
> +	ipv6_flowlabel_mgr \
>  	ipv6_fragmentation \
>  	proc_net_pktgen \
>  	reuseaddr_conflict \
> diff --git a/tools/testing/selftests/net/ipv6_flowlabel.sh b/tools/testing/selftests/net/ipv6_flowlabel.sh
> index 2eeda39bf64c..5d1b5464c54c 100755
> --- a/tools/testing/selftests/net/ipv6_flowlabel.sh
> +++ b/tools/testing/selftests/net/ipv6_flowlabel.sh
> @@ -7,9 +7,6 @@
>  
>  set -e
>  
> -echo "TEST management"
> -./ipv6_flowlabel_mgr
> -
>  echo "TEST datapath"
>  ./in_netns.sh \
>    sh -c 'sysctl -q -w net.ipv6.auto_flowlabels=0 && ./ipv6_flowlabel -l 1'
> -- 
> 2.55.0
> 

Reviewed-by: Hangbin Liu <liuhangbin@kylinos.cn>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-14  2:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-13  3:07 [PATCH net-next] selftests: net: separate ipv6_flowlabel_mgr test Marcelo Mendes Spessoto Junior
2026-08-14  2:03 ` Hangbin Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox