* Re: [PATCH] mips: remove dead select
[not found] <20260723104933.117413-1-julianbraha@gmail.com>
@ 2026-08-03 13:09 ` Thomas Bogendoerfer
0 siblings, 0 replies; only message in thread
From: Thomas Bogendoerfer @ 2026-08-03 13:09 UTC (permalink / raw)
To: Julian Braha; +Cc: arnd, linux-mips, linux-kernel
On Thu, Jul 23, 2026 at 11:49:33AM +0100, Julian Braha wrote:
> 'select' does not work on config options in a 'choice', so the current
> 'select CPU_BIG_ENDIAN' does nothing (dead code).
>
> However, ECONET already also selects SYS_SUPPORTS_BIG_ENDIAN so this
> means that CPU_BIG_ENDIAN will always be set.
>
> Let's remove the unnecessary 'select CPU_BIG_ENDIAN'.
>
> This dead select was found by kconfirm, a static analysis tool for
> Kconfig.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
> arch/mips/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index a06f24317306..e2eb9627bd14 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -395,7 +395,6 @@ config MACH_DECSTATION
> config ECONET
> bool "EcoNet MIPS family"
> select BOOT_RAW
> - select CPU_BIG_ENDIAN
> select DEBUG_ZBOOT if DEBUG_KERNEL
> select EARLY_PRINTK_8250
> select ECONET_EN751221_TIMER
> --
> 2.54.0
applied to mips-next
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] only message in thread