From: Boqun Feng <boqun@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Ingo Molnar" <mingo@kernel.org>, "Will Deacon" <will@kernel.org>,
"Waiman Long" <longman@redhat.com>, "Gary Guo" <gary@garyguo.net>,
"Alice Ryhl" <aliceryhl@google.com>,
"Lyude Paul" <lyude@redhat.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
"Boqun Feng" <boqun.feng@gmail.com>
Subject: Re: [PATCH 05/24] irq & spin_lock: Add counted interrupt disabling/enabling
Date: Tue, 4 Aug 2026 05:50:46 -0700 [thread overview]
Message-ID: <anHgJuGoRmTItBT2@tardis.local> (raw)
In-Reply-To: <20260804073316.GE788244@noisy.programming.kicks-ass.net>
On Tue, Aug 04, 2026 at 09:33:16AM +0200, Peter Zijlstra wrote:
> On Tue, Aug 04, 2026 at 09:26:40AM +0200, Peter Zijlstra wrote:
>
> > > > @@ -88,8 +89,17 @@ EXPORT_PER_CPU_SYMBOL_GPL(hardirqs_enabl
> > > > EXPORT_PER_CPU_SYMBOL_GPL(hardirq_context);
> > > > #endif
> > > >
> > > > -DEFINE_PER_CPU(struct interrupt_disable_state, local_interrupt_disable_state);
> > > > -EXPORT_PER_CPU_SYMBOL_GPL(local_interrupt_disable_state);
> > > > +DEFINE_PER_CPU(unsigned long, local_interrupt_disable_state);
> > > > +
> > > > +void _local_interrupt_disable(void)
> > > > +{
> > > > + __local_interrupt_disable();
> > > > +}
> > > > +
> > > > +void _local_interrupt_enable(void)
> > > > +{
> > > > + __local_interrupt_enable();
> > > > +}
> > > >
> > >
> > > We need to EXPORT_SYMBOL_GPL() for these two functions.
> > >
> > > Right?
> >
> > Quite so.
>
> Although, I suspect people will come and complain that this should be
> !GPL, it being something 'trivial' and all that nonsense, but we'll get
> there when we get there I suppose.
I haven't thought about the GPL part, but after a look, I think we
could do EXPORT_SYMBOL() (similar __local_bh_disable_ip) from the
get-go.
Regards,
Boqun
next prev parent reply other threads:[~2026-08-04 12:50 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 20:30 [GIT PULL] [PATCH 00/24] Rust synchronization changes for v7.3 Boqun Feng
2026-07-31 20:30 ` [PATCH 01/24] preempt: Track NMI nesting to separate per-CPU counter Boqun Feng
2026-07-31 20:30 ` [PATCH 02/24] preempt: Introduce HARDIRQ_DISABLE_BITS Boqun Feng
2026-08-03 9:10 ` Peter Zijlstra
2026-07-31 20:30 ` [PATCH 03/24] preempt: Introduce __preempt_count_{sub, add}_return() Boqun Feng
2026-07-31 20:30 ` [PATCH 04/24] openrisc: Include <linux/cpumask.h> in smp.h Boqun Feng
2026-07-31 20:30 ` [PATCH 05/24] irq & spin_lock: Add counted interrupt disabling/enabling Boqun Feng
2026-08-03 9:19 ` Peter Zijlstra
2026-08-03 13:33 ` Boqun Feng
2026-08-03 9:29 ` Peter Zijlstra
2026-08-03 10:43 ` Peter Zijlstra
2026-08-04 4:41 ` Boqun Feng
2026-08-04 7:26 ` Peter Zijlstra
2026-08-04 7:33 ` Peter Zijlstra
2026-08-04 12:50 ` Boqun Feng [this message]
2026-08-04 12:52 ` Boqun Feng
2026-08-03 10:16 ` Peter Zijlstra
2026-08-03 10:21 ` Peter Zijlstra
2026-08-03 14:06 ` Boqun Feng
2026-08-03 14:21 ` Peter Zijlstra
2026-08-03 14:33 ` Peter Zijlstra
2026-08-03 14:34 ` Peter Zijlstra
2026-08-03 14:39 ` Boqun Feng
2026-08-03 15:06 ` Peter Zijlstra
2026-08-03 19:09 ` Ingo Molnar
2026-08-03 19:47 ` Boqun Feng
2026-08-03 20:40 ` Boqun Feng
2026-07-31 20:30 ` [PATCH 06/24] irq: Add KUnit test for refcounted interrupt enable/disable Boqun Feng
2026-07-31 20:30 ` [PATCH 07/24] locking: Switch to _irq_{disable,enable}() variants in cleanup guards Boqun Feng
2026-08-03 9:34 ` Peter Zijlstra
2026-08-03 13:46 ` Boqun Feng
2026-08-03 13:55 ` Peter Zijlstra
2026-08-03 14:09 ` Boqun Feng
2026-07-31 20:30 ` [PATCH 08/24] sched: Remove the unused preempt_offset parameter of __cant_sleep() Boqun Feng
2026-07-31 20:30 ` [PATCH 09/24] sched: Avoid signed comparison of preempt_count() in __cant_migrate() Boqun Feng
2026-07-31 20:30 ` [PATCH 10/24] preempt: Introduce HAS_SEPARATE_PREEMPT_RESCHED_BITS Boqun Feng
2026-08-03 11:38 ` Peter Zijlstra
2026-08-03 15:04 ` Boqun Feng
2026-08-03 15:19 ` Peter Zijlstra
2026-08-03 15:55 ` Boqun Feng
2026-07-31 20:30 ` [PATCH 11/24] arm64: sched/preempt: Enable HAS_SEPARATE_PREEMPT_RESCHED_BITS Boqun Feng
2026-07-31 20:30 ` [PATCH 12/24] s390/preempt: " Boqun Feng
2026-08-03 11:40 ` Peter Zijlstra
2026-08-03 12:42 ` Heiko Carstens
2026-08-03 17:15 ` Boqun Feng
2026-07-31 20:30 ` [PATCH 13/24] irq: Optimize reschedule check in local_interrupt_enable() Boqun Feng
2026-08-03 11:41 ` Peter Zijlstra
2026-08-03 17:09 ` Boqun Feng
2026-07-31 20:30 ` [PATCH 14/24] rust: Introduce interrupt module Boqun Feng
2026-07-31 20:30 ` [PATCH 15/24] rust: helper: Add spin_{un,}lock_irq_{enable,disable}() helpers Boqun Feng
2026-07-31 20:30 ` [PATCH 16/24] rust: sync: use super::* in spinlock.rs Boqun Feng
2026-07-31 20:30 ` [PATCH 17/24] rust: sync: Add SpinLockIrq Boqun Feng
2026-07-31 20:30 ` [PATCH 18/24] rust: sync: Introduce SpinLockIrq::lock_with() and friends Boqun Feng
2026-07-31 20:30 ` [PATCH 19/24] rust: sync: Add abstraction for synchronize_rcu() Boqun Feng
2026-07-31 20:30 ` [PATCH 20/24] rust: revocable: Use safe synchronize_rcu() abstraction Boqun Feng
2026-07-31 20:30 ` [PATCH 21/24] rust: sync: Use safe synchronize_rcu() abstraction in poll Boqun Feng
2026-07-31 20:30 ` [PATCH 22/24] rust: sync: Add helpers for mb, dma_mb and friends Boqun Feng
2026-07-31 20:30 ` [PATCH 23/24] rust: sync: Add generic memory barriers Boqun Feng
2026-07-31 20:30 ` [PATCH 24/24] rust: revocable: Use LKMM atomics instead of Rust atomics Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anHgJuGoRmTItBT2@tardis.local \
--to=boqun@kernel.org \
--cc=aliceryhl@google.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=lyude@redhat.com \
--cc=mingo@kernel.org \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=will@kernel.org \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox