The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Youngjun Park <youngjun.park@lge.com>
To: Barry Song <baohua@kernel.org>
Cc: Youngjun Park <her0gyugyu@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Chris Li <chrisl@kernel.org>, Kairui Song <kasong@tencent.com>,
	Kemeng Shi <shikemeng@huaweicloud.com>,
	Nhat Pham <nphamcs@gmail.com>, Baoquan He <baoquan.he@linux.dev>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/swap: fix stale comment on swap_info_struct::cluster_info
Date: Wed, 5 Aug 2026 01:33:20 +0900	[thread overview]
Message-ID: <anIUUOCkwf85DFVJ@yjaykim-PowerEdge-T330> (raw)
In-Reply-To: <CAGsJ_4wvWMm4O=OBCQgpT=OWudgZ5D8E0Ri_B7xS6+6nQX7vjg@mail.gmail.com>

On Tue, Aug 04, 2026 at 05:51:52PM +0800, Barry Song wrote:
> On Tue, Jul 28, 2026 at 11:59 PM Youngjun Park <her0gyugyu@gmail.com> wrote:
> >
> > From: Youngjun Park <her0gyugyu@gmail.com>
> >
> > From: Youngjun Park <youngjun.park@lge.com>
> >
> > setup_swap_clusters_info() allocates cluster_info for every swap area,
> > not only for SSDs.
> >
> > Signed-off-by: Youngjun Park <youngjun.park@lge.com>
> > ---
> >  include/linux/swap.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/swap.h b/include/linux/swap.h
> > index 2cb1d29307c5..e12c73891b48 100644
> > --- a/include/linux/swap.h
> > +++ b/include/linux/swap.h
> > @@ -246,7 +246,7 @@ struct swap_info_struct {
> >         struct plist_node list;         /* entry in swap_active_head */
> >         signed char     type;           /* strange name for an index */
> >         unsigned int    max;            /* size of this swap device */
> > -       struct swap_cluster_info *cluster_info; /* cluster info. Only for SSD */
> > +       struct swap_cluster_info *cluster_info; /* one per cluster, on every device */
> 
> Do we still need "on every device", since it is on every device?
> 
> Thanks
> Barry

Hi Barry!

Right, Will trim it to /* one per cluster *

Youngjun

  reply	other threads:[~2026-08-04 17:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28 15:59 [PATCH 0/2] mm/swap: skip empty clusters in the swapoff scan Youngjun Park
2026-07-28 15:59 ` [PATCH 1/2] mm/swap: fix stale comment on swap_info_struct::cluster_info Youngjun Park
2026-08-04  9:48   ` Kairui Song
2026-08-04 16:36     ` Youngjun Park
2026-08-04  9:51   ` Barry Song
2026-08-04 16:33     ` Youngjun Park [this message]
2026-07-28 15:59 ` [PATCH 2/2] mm/swap: scan by cluster in find_next_to_unuse() Youngjun Park
2026-08-04 16:51   ` Kairui Song
2026-08-05 14:23     ` Youngjun Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anIUUOCkwf85DFVJ@yjaykim-PowerEdge-T330 \
    --to=youngjun.park@lge.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baoquan.he@linux.dev \
    --cc=chrisl@kernel.org \
    --cc=her0gyugyu@gmail.com \
    --cc=kasong@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=shikemeng@huaweicloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox