* [PATCH v1] clk: samsung: Don't include <linux/mod_devicetable.h>
@ 2026-08-06 13:00 Uwe Kleine-König (The Capable Hub)
2026-08-06 14:17 ` Brian Masney
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-08-06 13:00 UTC (permalink / raw)
To: Krzysztof Kozlowski, Sylwester Nawrocki, Chanwoo Choi,
Peter Griffin, Stephen Boyd, Brian Masney
Cc: Alim Akhtar, linux-samsung-soc, linux-clk, linux-kernel
All users of drivers/clk/samsung/clk.h live in drivers/clk/samsung (see
git grep samsung/clk.h
). All these are only using of_device_id from
the set of structures defined by this include (see
{ git grep -l clk\\.h drivers/clk/samsung/; echo drivers/clk/samsung/clk.h; } | xargs grep -oh -E "\<(acpi_device_id|amba_id|ap_device_id|apr_device_id|auxiliary_device_id|bcma_device_id|ccw_device_id|cdx_device_id|coreboot_device_id|css_device_id|dfl_device_id|dmi_(device|system)_id|eisa_device_id|fsl_mc_device_id|hda_device_id|hid_device_id|hv_vmbus_device_id|i2c_device_id|i3c_device_id|ieee1394_device_id|input_device_id|ipack_device_id|isapnp_device_id|ishtp_device_id|mcb_device_id|mdio_device_id|mei_cl_device_id|mhi_device_id|mips_cdmm_device_id|of_device_id|parisc_device_id|pci_device_id|pci_epf_device_id|pcmcia_device_id|platform_device_id|pnp_(card_)?device_id|rio_device_id|rpmsg_device_id|sdio_device_id|sdw_device_id|serio_device_id|slim_device_id|spi_device_id|spmi_device_id|ssam_device_id|ssb_device_id|tb_service_id|tee_client_device_id|typec_device_id|ulpi_device_id|usb_device_id|vchiq_device_id|vio_device_id|virtio_device_id|wmi_device_id|x86_(cpu|device)_id|zorro_device_id|cpu_feature)\>" | sort | uniq -c
).
So <linux/mod_devicetable.h> can be replaced by <linux/device-id/of.h>
to get rid of another user of the former header.
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
Hello,
note that this patch depends on
ad428f5811bd7fb3d91fa002174de533f9da94d7. So if you want to apply it
without having that commit yet in your tree, I recommend pulling
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux device-id-rework
(or v7.2-rc2) first.
Best regards
Uwe
drivers/clk/samsung/clk.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/samsung/clk.h b/drivers/clk/samsung/clk.h
index b1192ca03db5..cc41cd4ad317 100644
--- a/drivers/clk/samsung/clk.h
+++ b/drivers/clk/samsung/clk.h
@@ -11,7 +11,7 @@
#define __SAMSUNG_CLK_H
#include <linux/clk-provider.h>
-#include <linux/mod_devicetable.h>
+#include <linux/device-id/of.h>
#include <linux/regmap.h>
#include "clk-pll.h"
#include "clk-cpu.h"
base-commit: ad428f5811bd7fb3d91fa002174de533f9da94d7
--
2.55.0.11.g153666a7d9bb
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] clk: samsung: Don't include <linux/mod_devicetable.h>
2026-08-06 13:00 [PATCH v1] clk: samsung: Don't include <linux/mod_devicetable.h> Uwe Kleine-König (The Capable Hub)
@ 2026-08-06 14:17 ` Brian Masney
0 siblings, 0 replies; 2+ messages in thread
From: Brian Masney @ 2026-08-06 14:17 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub)
Cc: Krzysztof Kozlowski, Sylwester Nawrocki, Chanwoo Choi,
Peter Griffin, Stephen Boyd, Alim Akhtar, linux-samsung-soc,
linux-clk, linux-kernel
On Thu, Aug 06, 2026 at 03:00:50PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> All users of drivers/clk/samsung/clk.h live in drivers/clk/samsung (see
>
> git grep samsung/clk.h
>
> ). All these are only using of_device_id from
> the set of structures defined by this include (see
>
> { git grep -l clk\\.h drivers/clk/samsung/; echo drivers/clk/samsung/clk.h; } | xargs grep -oh -E "\<(acpi_device_id|amba_id|ap_device_id|apr_device_id|auxiliary_device_id|bcma_device_id|ccw_device_id|cdx_device_id|coreboot_device_id|css_device_id|dfl_device_id|dmi_(device|system)_id|eisa_device_id|fsl_mc_device_id|hda_device_id|hid_device_id|hv_vmbus_device_id|i2c_device_id|i3c_device_id|ieee1394_device_id|input_device_id|ipack_device_id|isapnp_device_id|ishtp_device_id|mcb_device_id|mdio_device_id|mei_cl_device_id|mhi_device_id|mips_cdmm_device_id|of_device_id|parisc_device_id|pci_device_id|pci_epf_device_id|pcmcia_device_id|platform_device_id|pnp_(card_)?device_id|rio_device_id|rpmsg_device_id|sdio_device_id|sdw_device_id|serio_device_id|slim_device_id|spi_device_id|spmi_device_id|ssam_device_id|ssb_device_id|tb_service_id|tee_client_device_id|typec_device_id|ulpi_device_id|usb_device_id|vchiq_device_id|vio_device_id|virtio_device_id|wmi_device_id|x86_(cpu|device)_id|zorro_device_id|cpu_feature)\>" | sort | uniq -c
>
> ).
>
> So <linux/mod_devicetable.h> can be replaced by <linux/device-id/of.h>
> to get rid of another user of the former header.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Reviewed-by: Brian Masney <bmasney@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-06 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-06 13:00 [PATCH v1] clk: samsung: Don't include <linux/mod_devicetable.h> Uwe Kleine-König (The Capable Hub)
2026-08-06 14:17 ` Brian Masney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox