The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Karl Mehltretter <kmehltretter@gmail.com>
To: Wei-Lin Chang <weilin.chang@arm.com>
Cc: Marc Zyngier <maz@kernel.org>, Oliver Upton <oupton@kernel.org>,
	 Fuad Tabba <tabba@google.com>, Joey Gouly <joey.gouly@arm.com>,
	 Steffen Eiden <seiden@linux.ibm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	 Zenghui Yu <yuzenghui@huawei.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	 Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
	 linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	grayhat@foxmail.com
Subject: Re: [PATCH v2] KVM: arm64: nv: Keep the shadow S2 MMUs at fixed addresses
Date: Thu, 6 Aug 2026 20:00:49 +0200	[thread overview]
Message-ID: <anTJa-VDvgCE-Ax7@gmail.com> (raw)
In-Reply-To: <vhpuadbpqligv2pfol6wsxtwpdkdeorlq2k5ifurwgry5pbh5x@jdm5jqm57sp3>

On Thu, Aug 06, 2026 at 03:49:35PM +0100, Wei-Lin Chang wrote:
> 
> I felt the commit message needs to be tightened a bit, so I restructured
> it slightly and removed some information I found unneeded. Here is my
> attempt, feel free to use it if you find it better or further improve it:

Hi Wei-Lin,

Thanks for the review! This is clearer, I'll tighten the commit message.

> 
> > +	/* Allocate the fixed-size pointer table once per VM. */
> 
> This comment seems a bit redundant.
> 

Agreed, I will drop it.

> > -	for (int i = kvm->arch.nested_mmus_size; !ret && i < num_mmus; i++)
> > -		ret = init_nested_s2_mmu(kvm, &kvm->arch.nested_mmus[i]);
> > +	write_lock(&kvm->mmu_lock);
> 
> Opportunity to use guard() or scoped_guard() here.
> 

Good point. I seem to forget about guard. I will use it and send v3.

Thanks,
Karl

      reply	other threads:[~2026-08-06 18:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06  6:23 [PATCH v2] KVM: arm64: nv: Keep the shadow S2 MMUs at fixed addresses Karl Mehltretter
2026-08-06 14:49 ` Wei-Lin Chang
2026-08-06 18:00   ` Karl Mehltretter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anTJa-VDvgCE-Ax7@gmail.com \
    --to=kmehltretter@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=grayhat@foxmail.com \
    --cc=joey.gouly@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oupton@kernel.org \
    --cc=seiden@linux.ibm.com \
    --cc=stable@vger.kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tabba@google.com \
    --cc=weilin.chang@arm.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox