Fixes tags need work in the perf tree

Fixes tags need work in the perf tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

In commit

  841dbf4871c57 ("perf loongarch: Fix build failure with CONFIG_LIBDW_DWARF_UNWIND")

Fixes tag

  Fixes: e62fae9d9e8 ("perf unwind-libdw: Fix a cross-arch unwinding bug")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Fixes tags need work in the perf tree

[Namhyung Kim]

Hello,

On Wed, Apr 15, 2026 at 11:12:03AM +0100, Mark Brown wrote:
> In commit
> 
>   841dbf4871c57 ("perf loongarch: Fix build failure with CONFIG_LIBDW_DWARF_UNWIND")
> 
> Fixes tag
> 
>   Fixes: e62fae9d9e8 ("perf unwind-libdw: Fix a cross-arch unwinding bug")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").

Sorry for the trouble.  I already have the config in my git config but I
missed to check it in contributors' patch.  I'll update my b4 script -
I hope checkpatch would catch this kind of problem next time.

Thanks,
Namhyung

Fixes tags need work in the perf tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

In commit

  8782a10c74e85 ("perf trace-event: Fix integer truncation in do_read() and skip()")

Fixes tag

  Fixes: 454c407ec17a ("perf tools: Get rid of read_or_die() in trace-event-read.c")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Fixes tags need work in the perf tree

[Namhyung Kim]

Hello,

On Fri, Aug 07, 2026 at 03:37:18PM +0100, Mark Brown wrote:
> In commit
> 
>   8782a10c74e85 ("perf trace-event: Fix integer truncation in do_read() and skip()")
> 
> Fixes tag
> 
>   Fixes: 454c407ec17a ("perf tools: Get rid of read_or_die() in trace-event-read.c")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Sorry about this, I should have checked it more carefully.
I'll fix the tag and force push the branch soon.

Thanks,
Namhyung

Re: Fixes tags need work in the perf tree

[Tanushree Shah]

Apologies for the incorrect Fixes tag. Will be more careful next time.


Thanks
Tanushree Shah
On 07/08/26 22:09, Namhyung Kim wrote:
> Hello,
> 
> On Fri, Aug 07, 2026 at 03:37:18PM +0100, Mark Brown wrote:
>> In commit
>>
>>    8782a10c74e85 ("perf trace-event: Fix integer truncation in do_read() and skip()")
>>
>> Fixes tag
>>
>>    Fixes: 454c407ec17a ("perf tools: Get rid of read_or_die() in trace-event-read.c")
>>
>> has these problem(s):
>>
>>    - Subject does not match target commit subject
>>      Just use
>> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Sorry about this, I should have checked it more carefully.
> I'll fix the tag and force push the branch soon.
> 
> Thanks,
> Namhyung
> 

Re: Fixes tags need work in the perf tree

[Namhyung Kim]

On Fri, Aug 07, 2026 at 09:39:18AM -0700, Namhyung Kim wrote:
> Hello,
> 
> On Fri, Aug 07, 2026 at 03:37:18PM +0100, Mark Brown wrote:
> > In commit
> > 
> >   8782a10c74e85 ("perf trace-event: Fix integer truncation in do_read() and skip()")
> > 
> > Fixes tag
> > 
> >   Fixes: 454c407ec17a ("perf tools: Get rid of read_or_die() in trace-event-read.c")
> > 
> > has these problem(s):
> > 
> >   - Subject does not match target commit subject
> >     Just use
> > 	git log -1 --format='Fixes: %h ("%s")'
> 
> Sorry about this, I should have checked it more carefully.
> I'll fix the tag and force push the branch soon.

Done.

Thanks,
Namhyung