* [PATCH] clk: qcom: mmcc-msm8974: add GENPD_FLAG_NO_STAY_ON
@ 2026-08-09 18:58 Dmitry Baryshkov
2026-08-10 8:37 ` Stephan Gerhold
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Baryshkov @ 2026-08-09 18:58 UTC (permalink / raw)
To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Brian Masney,
Ulf Hansson
Cc: linux-arm-msm, linux-clk, linux-kernel
Commit 13a4b7fb6260 ("pmdomain: core: Leave powered-on genpds on until
late_initcall_sync") kept power-domains on longer during boot which is
causing DSI clock to get stuck and fail to acquire its configuration on
DSI bringup. While this is being investigated, add the flag
GENPD_FLAG_NO_STAY_ON for MDSS GDSC on MSM8974 to restore the previous
behaviour to fix this.
Fixes: 13a4b7fb6260 ("pmdomain: core: Leave powered-on genpds on until late_initcall_sync")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
drivers/clk/qcom/mmcc-msm8974.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c
index f2e802cf6afc..b04885864baf 100644
--- a/drivers/clk/qcom/mmcc-msm8974.c
+++ b/drivers/clk/qcom/mmcc-msm8974.c
@@ -2367,6 +2367,7 @@ static struct gdsc mdss_gdsc = {
.cxc_count = 2,
.pd = {
.name = "mdss",
+ .flags = GENPD_FLAG_NO_STAY_ON,
},
.pwrsts = PWRSTS_OFF_ON,
};
---
base-commit: 6b8c8af514d739d0335f5579b585e02babe8a727
change-id: 20260809-msm8974-mmcc-fix-c83b5fa916af
Best regards,
--
With best wishes
Dmitry
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: qcom: mmcc-msm8974: add GENPD_FLAG_NO_STAY_ON
2026-08-09 18:58 [PATCH] clk: qcom: mmcc-msm8974: add GENPD_FLAG_NO_STAY_ON Dmitry Baryshkov
@ 2026-08-10 8:37 ` Stephan Gerhold
2026-08-10 8:56 ` Dmitry Baryshkov
0 siblings, 1 reply; 3+ messages in thread
From: Stephan Gerhold @ 2026-08-10 8:37 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Michael Turquette, Stephen Boyd, Brian Masney,
Ulf Hansson, linux-arm-msm, linux-clk, linux-kernel
On Sun, Aug 09, 2026 at 09:58:37PM +0300, Dmitry Baryshkov wrote:
> Commit 13a4b7fb6260 ("pmdomain: core: Leave powered-on genpds on until
> late_initcall_sync") kept power-domains on longer during boot which is
> causing DSI clock to get stuck and fail to acquire its configuration on
> DSI bringup. While this is being investigated, add the flag
> GENPD_FLAG_NO_STAY_ON for MDSS GDSC on MSM8974 to restore the previous
> behaviour to fix this.
>
> Fixes: 13a4b7fb6260 ("pmdomain: core: Leave powered-on genpds on until late_initcall_sync")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Have you tried adding resets = <&mmcc MDSS_RESET>; to the &mdss node,
similar to the following patch for msm8916.dtsi?
https://lore.kernel.org/linux-arm-msm/20250915-msm8916-resets-v1-1-a5c705df0c45@linaro.org/
Thanks,
Stephan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: qcom: mmcc-msm8974: add GENPD_FLAG_NO_STAY_ON
2026-08-10 8:37 ` Stephan Gerhold
@ 2026-08-10 8:56 ` Dmitry Baryshkov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2026-08-10 8:56 UTC (permalink / raw)
To: Stephan Gerhold
Cc: Bjorn Andersson, Michael Turquette, Stephen Boyd, Brian Masney,
Ulf Hansson, linux-arm-msm, linux-clk, linux-kernel
On Mon, Aug 10, 2026 at 10:37:13AM +0200, Stephan Gerhold wrote:
> On Sun, Aug 09, 2026 at 09:58:37PM +0300, Dmitry Baryshkov wrote:
> > Commit 13a4b7fb6260 ("pmdomain: core: Leave powered-on genpds on until
> > late_initcall_sync") kept power-domains on longer during boot which is
> > causing DSI clock to get stuck and fail to acquire its configuration on
> > DSI bringup. While this is being investigated, add the flag
> > GENPD_FLAG_NO_STAY_ON for MDSS GDSC on MSM8974 to restore the previous
> > behaviour to fix this.
> >
> > Fixes: 13a4b7fb6260 ("pmdomain: core: Leave powered-on genpds on until late_initcall_sync")
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
> Have you tried adding resets = <&mmcc MDSS_RESET>; to the &mdss node,
> similar to the following patch for msm8916.dtsi?
> https://lore.kernel.org/linux-arm-msm/20250915-msm8916-resets-v1-1-a5c705df0c45@linaro.org/
Seems to work, thanks! Indeed, it's a better patch.
>
> Thanks,
> Stephan
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-10 8:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-09 18:58 [PATCH] clk: qcom: mmcc-msm8974: add GENPD_FLAG_NO_STAY_ON Dmitry Baryshkov
2026-08-10 8:37 ` Stephan Gerhold
2026-08-10 8:56 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox