* [PATCH] backlight: qcom-wled: Remove redundant dev_err()
@ 2026-07-22 6:57 Pan Chuang
2026-08-10 11:11 ` Daniel Thompson
0 siblings, 1 reply; 2+ messages in thread
From: Pan Chuang @ 2026-07-22 6:57 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller,
open list:ARM/QUALCOMM MAILING LIST,
open list:BACKLIGHT CLASS/SUBSYSTEM, open list:FRAMEBUFFER LAYER,
open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/video/backlight/qcom-wled.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
index 8054e4787725..650dd95f06ef 100644
--- a/drivers/video/backlight/qcom-wled.c
+++ b/drivers/video/backlight/qcom-wled.c
@@ -1639,8 +1639,6 @@ static int wled_configure_ovp_irq(struct wled *wled,
wled_ovp_irq_handler, IRQF_ONESHOT,
"wled_ovp_irq", wled);
if (rc < 0) {
- dev_err(wled->dev, "Unable to request ovp_irq (err:%d)\n",
- rc);
wled->ovp_irq = 0;
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] backlight: qcom-wled: Remove redundant dev_err()
2026-07-22 6:57 [PATCH] backlight: qcom-wled: Remove redundant dev_err() Pan Chuang
@ 2026-08-10 11:11 ` Daniel Thompson
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Thompson @ 2026-08-10 11:11 UTC (permalink / raw)
To: Pan Chuang
Cc: Lee Jones, Jingoo Han, Helge Deller,
open list:ARM/QUALCOMM MAILING LIST,
open list:BACKLIGHT CLASS/SUBSYSTEM, open list:FRAMEBUFFER LAYER,
open list
On Wed, Jul 22, 2026 at 02:57:08PM +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org>
Daniel.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-10 11:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-22 6:57 [PATCH] backlight: qcom-wled: Remove redundant dev_err() Pan Chuang
2026-08-10 11:11 ` Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox