[PATCH] drm/bridge: chipone-icn6211: use devm_mipi_dsi_attach

[PATCH] drm/bridge: chipone-icn6211: use devm_mipi_dsi_attach

[Osama Abdelkader]

Follow up on the previous devm_drm_bridge_add() conversion by
converting the remaining manual cleanup in chipone-icn6211 to the
managed helper.

Suggested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
 drivers/gpu/drm/bridge/chipone-icn6211.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
index e5957917ad88..d51d770060b6 100644
--- a/drivers/gpu/drm/bridge/chipone-icn6211.c
+++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
@@ -531,7 +531,7 @@ static int chipone_dsi_attach(struct chipone *icn)
 	dsi->hs_rate = 500000000;
 	dsi->lp_rate = 16000000;
 
-	ret = mipi_dsi_attach(dsi);
+	ret = devm_mipi_dsi_attach(dev, dsi);
 	if (ret < 0)
 		dev_err(icn->dev, "failed to attach dsi\n");
 
@@ -761,11 +761,6 @@ static int chipone_i2c_probe(struct i2c_client *client)
 	return chipone_dsi_host_attach(icn);
 }
 
-static void chipone_dsi_remove(struct mipi_dsi_device *dsi)
-{
-	mipi_dsi_detach(dsi);
-}
-
 static const struct of_device_id chipone_of_match[] = {
 	{ .compatible = "chipone,icn6211", },
 	{ /* sentinel */ }
@@ -774,7 +769,6 @@ MODULE_DEVICE_TABLE(of, chipone_of_match);
 
 static struct mipi_dsi_driver chipone_dsi_driver = {
 	.probe = chipone_dsi_probe,
-	.remove = chipone_dsi_remove,
 	.driver = {
 		.name = "chipone-icn6211",
 		.of_match_table = chipone_of_match,
-- 
2.43.0

Re: [PATCH] drm/bridge: chipone-icn6211: use devm_mipi_dsi_attach

[Osama Abdelkader]

On Thu, May 21, 2026 at 11:25:28PM +0200, Osama Abdelkader wrote:
> Follow up on the previous devm_drm_bridge_add() conversion by
> converting the remaining manual cleanup in chipone-icn6211 to the
> managed helper.
> 
> Suggested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
>  drivers/gpu/drm/bridge/chipone-icn6211.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
> index e5957917ad88..d51d770060b6 100644
> --- a/drivers/gpu/drm/bridge/chipone-icn6211.c
> +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
> @@ -531,7 +531,7 @@ static int chipone_dsi_attach(struct chipone *icn)
>  	dsi->hs_rate = 500000000;
>  	dsi->lp_rate = 16000000;
>  
> -	ret = mipi_dsi_attach(dsi);
> +	ret = devm_mipi_dsi_attach(dev, dsi);
>  	if (ret < 0)
>  		dev_err(icn->dev, "failed to attach dsi\n");
>  
> @@ -761,11 +761,6 @@ static int chipone_i2c_probe(struct i2c_client *client)
>  	return chipone_dsi_host_attach(icn);
>  }
>  
> -static void chipone_dsi_remove(struct mipi_dsi_device *dsi)
> -{
> -	mipi_dsi_detach(dsi);
> -}
> -
>  static const struct of_device_id chipone_of_match[] = {
>  	{ .compatible = "chipone,icn6211", },
>  	{ /* sentinel */ }
> @@ -774,7 +769,6 @@ MODULE_DEVICE_TABLE(of, chipone_of_match);
>  
>  static struct mipi_dsi_driver chipone_dsi_driver = {
>  	.probe = chipone_dsi_probe,
> -	.remove = chipone_dsi_remove,
>  	.driver = {
>  		.name = "chipone-icn6211",
>  		.of_match_table = chipone_of_match,
> -- 
> 2.43.0
> 
ping.