From: Christoph Hellwig <hch@infradead.org>
To: Lance Yang <lance.yang@linux.dev>
Cc: pfalcato@suse.de, kas@kernel.org, usama.arif@linux.dev,
hughd@google.com, akpm@linux-foundation.org, baohua@kernel.org,
baolin.wang@linux.alibaba.com, david@kernel.org,
dev.jain@arm.com, liam@infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, ljs@kernel.org,
nico.pache@linux.dev, ryan.roberts@arm.com, ziy@nvidia.com,
nphamcs@gmail.com, hannes@cmpxchg.org, riel@surriel.com,
shakeel.butt@linux.dev, kernel-team@meta.com,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/huge_memory: transfer the pmd dirty bit to the folio on zap
Date: Mon, 24 Aug 2026 22:57:01 -0700 [thread overview]
Message-ID: <ao0urQFF6IOFAorx@infradead.org> (raw)
In-Reply-To: <20260820061337.24669-1-lance.yang@linux.dev>
On Thu, Aug 20, 2026 at 02:13:37PM +0800, Lance Yang wrote:
> XFS installs the huge-fault, regular-fault, and page_mkwrite callbacks
> in the same vm_ops:
>
> static const struct vm_operations_struct xfs_file_vm_ops = {
> .fault = xfs_filemap_fault,
> .huge_fault = xfs_filemap_huge_fault,
> ...
> .page_mkwrite = xfs_filemap_page_mkwrite,
> ...
> };
>
> On the fallback path, handle_pte_fault() leaves an empty PMD without a
> PTE and calls do_pte_missing():
Just a reminder that it would be extremely helpful if we could refactor
the vm_operations_struct so that file systems could register one single
fault handler to cover all these (plus .pfn_mkwrite) to remove all
the annoying boilerplate code in the file system and the confusing
fallback logic in the VM.
next prev parent reply other threads:[~2026-08-25 5:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 10:12 [PATCH] mm/huge_memory: transfer the pmd dirty bit to the folio on zap Usama Arif
2026-08-19 14:13 ` David Hildenbrand (Arm)
2026-08-19 14:13 ` David Hildenbrand (Arm)
2026-08-19 14:31 ` Kiryl Shutsemau
2026-08-19 16:17 ` Lance Yang
2026-08-19 16:32 ` Usama Arif
2026-08-20 13:05 ` Usama Arif
2026-08-19 16:35 ` Pedro Falcato
2026-08-20 6:13 ` Lance Yang
2026-08-20 12:12 ` Pedro Falcato
2026-08-20 13:20 ` Kiryl Shutsemau
2026-08-20 14:10 ` Pedro Falcato
2026-08-20 16:53 ` Lance Yang
2026-08-20 22:20 ` Pedro Falcato
2026-08-25 5:59 ` Christoph Hellwig
2026-08-25 8:04 ` David Hildenbrand (Arm)
2026-08-25 8:40 ` Pedro Falcato
2026-08-26 4:42 ` Christoph Hellwig
2026-08-25 5:57 ` Christoph Hellwig [this message]
2026-08-19 20:33 ` Hugh Dickins
2026-08-19 15:10 ` Lance Yang
2026-08-19 15:31 ` Zi Yan
2026-08-19 16:09 ` Lorenzo Stoakes (ARM)
2026-08-20 2:06 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao0urQFF6IOFAorx@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kas@kernel.org \
--cc=kernel-team@meta.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=nico.pache@linux.dev \
--cc=nphamcs@gmail.com \
--cc=pfalcato@suse.de \
--cc=riel@surriel.com \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=stable@vger.kernel.org \
--cc=usama.arif@linux.dev \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox