* [PATCH] setlocalversion: make tag local to try_tag()
@ 2026-08-23 9:49 Yuntao Wang
2026-08-25 13:49 ` Nicolas Schier
0 siblings, 1 reply; 2+ messages in thread
From: Yuntao Wang @ 2026-08-23 9:49 UTC (permalink / raw)
To: linux-kbuild, linux-kernel
Cc: Masahiro Yamada, Nathan Chancellor, Nicolas Schier,
Rasmus Villemoes, Yuntao Wang
The tag variable is only used by try_tag(), but is currently declared
local to scm_version() and modified by try_tag().
Make tag local to try_tag() instead and remove the unused declaration
from scm_version().
No functional changes.
Signed-off-by: Yuntao Wang <yuntao.wang@linux.dev>
---
scripts/setlocalversion | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/setlocalversion b/scripts/setlocalversion
index 28169d7e143b..f264c2460ad7 100755
--- a/scripts/setlocalversion
+++ b/scripts/setlocalversion
@@ -33,7 +33,7 @@ if test $# -gt 0 -o ! -d "$srctree"; then
fi
try_tag() {
- tag="$1"
+ local tag="$1"
# Is $tag an annotated tag?
if [ "$(git cat-file -t "$tag" 2> /dev/null)" != tag ]; then
@@ -59,7 +59,6 @@ scm_version()
{
local short=false
local no_dirty=false
- local tag
while [ $# -gt 0 ];
do
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] setlocalversion: make tag local to try_tag()
2026-08-23 9:49 [PATCH] setlocalversion: make tag local to try_tag() Yuntao Wang
@ 2026-08-25 13:49 ` Nicolas Schier
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Schier @ 2026-08-25 13:49 UTC (permalink / raw)
To: Yuntao Wang
Cc: linux-kbuild, linux-kernel, Masahiro Yamada, Nathan Chancellor,
Rasmus Villemoes
On Sun, Aug 23, 2026 at 05:49:13PM +0800, Yuntao Wang wrote:
> The tag variable is only used by try_tag(), but is currently declared
> local to scm_version() and modified by try_tag().
>
> Make tag local to try_tag() instead and remove the unused declaration
> from scm_version().
>
> No functional changes.
>
> Signed-off-by: Yuntao Wang <yuntao.wang@linux.dev>
> ---
> scripts/setlocalversion | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Nicolas Schier <nsc@kernel.org>
--
Nicolas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-25 17:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-23 9:49 [PATCH] setlocalversion: make tag local to try_tag() Yuntao Wang
2026-08-25 13:49 ` Nicolas Schier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox