From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Triet Hoang <triet.hoang.dev@gmail.com>
Cc: andy@kernel.org, bleung@chromium.org,
chrome-platform@lists.linux.dev, dlechner@baylibre.com,
groeck@chromium.org, jic23@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, nuno.sa@analog.com
Subject: Re: [PATCH] iio: cros_ec: Convert to DEFINE_SIMPLE_DEV_PM_OPS()
Date: Fri, 21 Aug 2026 19:01:25 +0300 [thread overview]
Message-ID: <aoh2VZ5nrZIPQUt2@ashevche-desk.local> (raw)
In-Reply-To: <20260821140451.3969-1-triet.hoang.dev@gmail.com>
On Fri, Aug 21, 2026 at 02:04:50PM +0000, Triet Hoang wrote:
> On Fri, 21 Aug 2026 16:37:18 +0300, Andy Shevchenko wrote:
> > There is a macro that combines DEFINE + EXPORT.
>
> Thanks for reviewing. Should I send the v2 with the update?
v2 should incorporate the requested changes.
> > There is room on the lines to make them longer a bit.
> >
> > Convert the deprecated SIMPLE_DEV_PM_OPS to DEFINE_SIMPLE_DEV_PM_OPS
> > and pm_sleep_ptr().
> >
> > This lets us drop the __maybe_unused annotations from the resume callbacks,
> > and reduces kernel size in case CONFIG_PM or CONFIG_PM_SLEEP is disabled.
>
> With the new commit that you have suggested.
It should be a new version of the same change, but with the comments being
addressed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-21 16:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 1:44 [PATCH] iio: cros_ec: Convert to DEFINE_SIMPLE_DEV_PM_OPS() Triet Hoang
2026-08-21 1:54 ` Jonathan Cameron
2026-08-21 2:10 ` Triet Hoang
2026-08-21 16:02 ` Jonathan Cameron
2026-08-21 13:37 ` Andy Shevchenko
2026-08-21 14:04 ` Triet Hoang
2026-08-21 16:01 ` Andy Shevchenko [this message]
2026-08-25 1:27 ` [PATCH v2] " Triet Hoang
2026-08-25 1:52 ` Tzung-Bi Shih
2026-08-25 2:32 ` Triet Hoang
2026-08-25 9:15 ` Andy Shevchenko
2026-08-25 9:14 ` Andy Shevchenko
2026-08-25 9:35 ` [PATCH v3] " Triet Hoang
2026-08-25 9:42 ` Joshua Crofts
2026-08-25 10:51 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoh2VZ5nrZIPQUt2@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dlechner@baylibre.com \
--cc=groeck@chromium.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=triet.hoang.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox