* [PATCH] usb: typec: qcom-pmic: cancel reset_work on stop
@ 2026-08-19 16:14 Fan Wu
2026-08-20 8:17 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fan Wu @ 2026-08-19 16:14 UTC (permalink / raw)
To: linux-usb
Cc: bryan.odonoghue, heikki.krogerus, gregkh, linux-arm-msm,
linux-kernel, stable, Fan Wu
pdphy_stop() disables IRQs but leaves reset_work pending. If the IRQ
handler schedules it just before disable_irq(), the work runs after
remove() frees the struct via devm.
Call cancel_work_sync() after disabling IRQs to close the window.
This issue was found by an in-house static analysis tool.
Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
Cc: stable@vger.kernel.org
Assisted-by: Codex:gpt-5.6
Signed-off-by: Fan Wu <fanwu01@zju.edu.cn>
---
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
index c8b1463e6..abb9d0321 100644
--- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
+++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
@@ -544,6 +544,8 @@ static void qcom_pmic_typec_pdphy_stop(struct pmic_typec *tcpm)
for (i = 0; i < pmic_typec_pdphy->nr_irqs; i++)
disable_irq(pmic_typec_pdphy->irq_data[i].irq);
+ cancel_work_sync(&pmic_typec_pdphy->reset_work);
+
qcom_pmic_typec_pdphy_reset_on(pmic_typec_pdphy);
regulator_disable(pmic_typec_pdphy->vdd_pdphy);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: typec: qcom-pmic: cancel reset_work on stop
2026-08-19 16:14 [PATCH] usb: typec: qcom-pmic: cancel reset_work on stop Fan Wu
@ 2026-08-20 8:17 ` Konrad Dybcio
2026-08-20 10:15 ` Bryan O'Donoghue
2026-08-24 11:22 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2026-08-20 8:17 UTC (permalink / raw)
To: Fan Wu, linux-usb
Cc: bryan.odonoghue, heikki.krogerus, gregkh, linux-arm-msm,
linux-kernel, stable
On 8/19/26 6:14 PM, Fan Wu wrote:
> pdphy_stop() disables IRQs but leaves reset_work pending. If the IRQ
> handler schedules it just before disable_irq(), the work runs after
> remove() frees the struct via devm.
>
> Call cancel_work_sync() after disabling IRQs to close the window.
>
> This issue was found by an in-house static analysis tool.
>
> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
> Cc: stable@vger.kernel.org
> Assisted-by: Codex:gpt-5.6
> Signed-off-by: Fan Wu <fanwu01@zju.edu.cn>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: typec: qcom-pmic: cancel reset_work on stop
2026-08-19 16:14 [PATCH] usb: typec: qcom-pmic: cancel reset_work on stop Fan Wu
2026-08-20 8:17 ` Konrad Dybcio
@ 2026-08-20 10:15 ` Bryan O'Donoghue
2026-08-24 11:22 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Bryan O'Donoghue @ 2026-08-20 10:15 UTC (permalink / raw)
To: Fan Wu, linux-usb
Cc: heikki.krogerus, gregkh, linux-arm-msm, linux-kernel, stable
On 19/08/2026 17:14, Fan Wu wrote:
> pdphy_stop() disables IRQs but leaves reset_work pending. If the IRQ
> handler schedules it just before disable_irq(), the work runs after
> remove() frees the struct via devm.
>
> Call cancel_work_sync() after disabling IRQs to close the window.
>
> This issue was found by an in-house static analysis tool.
>
> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
> Cc: stable@vger.kernel.org
> Assisted-by: Codex:gpt-5.6
> Signed-off-by: Fan Wu <fanwu01@zju.edu.cn>
> ---
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> index c8b1463e6..abb9d0321 100644
> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> @@ -544,6 +544,8 @@ static void qcom_pmic_typec_pdphy_stop(struct pmic_typec *tcpm)
> for (i = 0; i < pmic_typec_pdphy->nr_irqs; i++)
> disable_irq(pmic_typec_pdphy->irq_data[i].irq);
>
> + cancel_work_sync(&pmic_typec_pdphy->reset_work);
> +
> qcom_pmic_typec_pdphy_reset_on(pmic_typec_pdphy);
>
> regulator_disable(pmic_typec_pdphy->vdd_pdphy);
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: typec: qcom-pmic: cancel reset_work on stop
2026-08-19 16:14 [PATCH] usb: typec: qcom-pmic: cancel reset_work on stop Fan Wu
2026-08-20 8:17 ` Konrad Dybcio
2026-08-20 10:15 ` Bryan O'Donoghue
@ 2026-08-24 11:22 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2026-08-24 11:22 UTC (permalink / raw)
To: Fan Wu
Cc: linux-usb, bryan.odonoghue, gregkh, linux-arm-msm, linux-kernel,
stable
On Wed, Aug 19, 2026 at 04:14:48PM +0000, Fan Wu wrote:
> pdphy_stop() disables IRQs but leaves reset_work pending. If the IRQ
> handler schedules it just before disable_irq(), the work runs after
> remove() frees the struct via devm.
>
> Call cancel_work_sync() after disabling IRQs to close the window.
>
> This issue was found by an in-house static analysis tool.
>
> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
> Cc: stable@vger.kernel.org
> Assisted-by: Codex:gpt-5.6
> Signed-off-by: Fan Wu <fanwu01@zju.edu.cn>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> index c8b1463e6..abb9d0321 100644
> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> @@ -544,6 +544,8 @@ static void qcom_pmic_typec_pdphy_stop(struct pmic_typec *tcpm)
> for (i = 0; i < pmic_typec_pdphy->nr_irqs; i++)
> disable_irq(pmic_typec_pdphy->irq_data[i].irq);
>
> + cancel_work_sync(&pmic_typec_pdphy->reset_work);
> +
> qcom_pmic_typec_pdphy_reset_on(pmic_typec_pdphy);
>
> regulator_disable(pmic_typec_pdphy->vdd_pdphy);
--
heikki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-24 11:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-19 16:14 [PATCH] usb: typec: qcom-pmic: cancel reset_work on stop Fan Wu
2026-08-20 8:17 ` Konrad Dybcio
2026-08-20 10:15 ` Bryan O'Donoghue
2026-08-24 11:22 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox