The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	James Clark <james.clark@linaro.org>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Clark Williams <williams@redhat.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH v6 07/13] perf tests: Exercise data type resolution from a register
Date: Tue, 17 Nov 2026 23:16:20 -0800	[thread overview]
Message-ID: <av1QxJZA36xcbcEL@google.com> (raw)
In-Reply-To: <20261117200433.45174-8-acme@kernel.org>

On Tue, Nov 17, 2026 at 05:04:25PM -0300, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> At -O2 a struct pointer lives in a register (with DWARF describing it with
> a register location on register-argument ABIs), while the unoptimized
> workloads the data type tests profile keep their variables on the stack.
> 
> Add a regptr workload with a noinline function that takes the pointer from
> a volatile global, so the compiler cannot constant-propagate the object
> address, and check that its three member accesses are resolved from that
> register.

Thanks for adding the workloads for data type profiling.  I was unsure
if it's ok to add since it'd requires many test cases to cover various
aspect of binary patterns or compiler/language differences.  But having
a seperate repo for the test programs would be cumbersome too.

Thanks,
Namhyung

> 
> Reviewed-by: Ian Rogers <irogers@google.com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/tests/builtin-test.c              |  1 +
>  tools/perf/tests/shell/data_type_register.sh | 60 +++++++++++++++++++
>  tools/perf/tests/tests.h                     |  1 +
>  tools/perf/tests/workloads/Build             |  2 +
>  tools/perf/tests/workloads/regptr.c          | 61 ++++++++++++++++++++
>  5 files changed, 125 insertions(+)
>  create mode 100755 tools/perf/tests/shell/data_type_register.sh
>  create mode 100644 tools/perf/tests/workloads/regptr.c
> 
> diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> index 8fc425d470c17dbf..fe4d4cd54f85d502 100644
> --- a/tools/perf/tests/builtin-test.c
> +++ b/tools/perf/tests/builtin-test.c
> @@ -215,6 +215,7 @@ static struct test_workload *workloads[] = {
>  	&workload__false_sharing,
>  	&workload__global_data,
>  	&workload__flex_array,
> +	&workload__regptr,
>  
>  #ifdef HAVE_RUST_SUPPORT
>  	&workload__code_with_type,
> diff --git a/tools/perf/tests/shell/data_type_register.sh b/tools/perf/tests/shell/data_type_register.sh
> new file mode 100755
> index 0000000000000000..0d4a420cad9475cd
> --- /dev/null
> +++ b/tools/perf/tests/shell/data_type_register.sh
> @@ -0,0 +1,60 @@
> +#!/bin/bash
> +# perf data type profiling tests for register variables
> +# SPDX-License-Identifier: GPL-2.0
> +
> +set -e
> +
> +perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
> +perfout=$(mktemp /tmp/__perf_test.perf.out.XXXXX)
> +
> +cleanup()
> +{
> +	rm -f "$perfdata" "$perfout"
> +	trap - EXIT TERM INT
> +}
> +
> +trap_cleanup()
> +{
> +	echo "Unexpected signal in ${FUNCNAME[1]}"
> +	cleanup
> +	exit 1
> +}
> +trap trap_cleanup EXIT TERM INT
> +
> +if ! perf check feature -q dwarf; then
> +	echo "Skip: no DWARF (libdw) support"
> +	cleanup
> +	exit 2
> +fi
> +
> +# No point in recording if the PMU cannot do memory events.
> +if ! perf mem record -o /dev/null -- true 2>/dev/null; then
> +	echo "Skip: cannot record memory events on this PMU"
> +	cleanup
> +	exit 2
> +fi
> +
> +if ! perf mem record -o "$perfdata" -- perf test -w regptr 1 > /dev/null 2>&1; then
> +	echo "FAIL: perf mem record"
> +	cleanup
> +	exit 1
> +fi
> +
> +if ! perf annotate --code-with-type -i "$perfdata" --stdio \
> +		--percent-limit 1 > "$perfout"; then
> +	echo "FAIL: perf annotate"
> +	cleanup
> +	exit 1
> +fi
> +
> +for member in "+0 (a)" "+0x8 (b)" "+0x10 (c)"; do
> +	if ! grep -Fq "# data-type: struct node ${member}" "$perfout"; then
> +		echo "FAIL: member ${member} not resolved from the register"
> +		tail -n 30 "$perfout"
> +		cleanup
> +		exit 1
> +	fi
> +done
> +
> +echo "register held access resolved"
> +cleanup
> diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
> index 0cf33d91804f19c4..b03c56d5e4c98aaf 100644
> --- a/tools/perf/tests/tests.h
> +++ b/tools/perf/tests/tests.h
> @@ -275,6 +275,7 @@ DECLARE_WORKLOAD(callchain);
>  DECLARE_WORKLOAD(false_sharing);
>  DECLARE_WORKLOAD(global_data);
>  DECLARE_WORKLOAD(flex_array);
> +DECLARE_WORKLOAD(regptr);
>  
>  #ifdef HAVE_RUST_SUPPORT
>  DECLARE_WORKLOAD(code_with_type);
> diff --git a/tools/perf/tests/workloads/Build b/tools/perf/tests/workloads/Build
> index 74a0cbe49dc93533..17189458032c0a17 100644
> --- a/tools/perf/tests/workloads/Build
> +++ b/tools/perf/tests/workloads/Build
> @@ -19,6 +19,7 @@ perf-test-y += callchain.o
>  perf-test-y += false_sharing.o
>  perf-test-y += global_data.o
>  perf-test-y += flex_array.o
> +perf-test-y += regptr.o
>  
>  ifeq ($(CONFIG_RUST_SUPPORT),y)
>      perf-test-y += code_with_type.o
> @@ -39,3 +40,4 @@ CFLAGS_callchain.o        = -g -O0 -fno-inline -U_FORTIFY_SOURCE
>  CFLAGS_false_sharing.o    = -g -O0 -fno-inline -U_FORTIFY_SOURCE
>  CFLAGS_global_data.o      = -g -O0 -fno-inline -U_FORTIFY_SOURCE
>  CFLAGS_flex_array.o       = -g -O0 -fno-inline -U_FORTIFY_SOURCE
> +CFLAGS_regptr.o           = -g -O2
> diff --git a/tools/perf/tests/workloads/regptr.c b/tools/perf/tests/workloads/regptr.c
> new file mode 100644
> index 0000000000000000..441202b61ae7b2e6
> --- /dev/null
> +++ b/tools/perf/tests/workloads/regptr.c
> @@ -0,0 +1,61 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * A struct pointer that -O2 keeps in a register, so the member accesses
> + * have to be resolved from the register's type state and not from a
> + * stack slot.
> + *
> + * See tests/shell/data_type_register.sh.
> + */
> +#include <signal.h>
> +#include <stdlib.h>
> +#include <unistd.h>
> +#include <linux/compiler.h>
> +#include "../tests.h"
> +
> +struct node {
> +	long long a;
> +	long long b;
> +	long long c;
> +};
> +
> +static struct node n;
> +static struct node *volatile vp;
> +static volatile unsigned long long reg_sink;
> +static volatile sig_atomic_t done;
> +
> +static void sighandler(int sig __maybe_unused)
> +{
> +	done = 1;
> +}
> +
> +static noinline long long touch(struct node *p)
> +{
> +	long long sum = 0;
> +
> +	sum += p->a;
> +	/* A load too, or a load-only PMU never resolves b. */
> +	p->b += sum;
> +	sum += p->c;
> +	return sum;
> +}
> +
> +static int regptr(int argc, const char **argv)
> +{
> +	unsigned long long sum = 0;
> +	int sec = 1;
> +
> +	if (argc > 0)
> +		sec = atoi(argv[0]);
> +
> +	vp = &n;
> +	signal(SIGINT, sighandler);
> +	signal(SIGALRM, sighandler);
> +	alarm(sec);
> +
> +	while (!done)
> +		sum += touch(vp);
> +	reg_sink = sum;
> +	return 0;
> +}
> +
> +DEFINE_WORKLOAD(regptr);
> -- 
> 2.56.0
> 

  reply	other threads:[~2026-11-18  7:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 20:04 [PATCH v6 0/13] perf coverage: A harness for perf, and the fixes it found Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 01/13] perf jvmti: Link the agent with EXTRA_CFLAGS Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 02/13] perf scripts: Add a coverage harness for perf Arnaldo Carvalho de Melo
2026-11-18  6:56   ` Namhyung Kim
2026-11-17 20:04 ` [PATCH v6 03/13] perf annotate: Handle absolute addressing in data type profiling Arnaldo Carvalho de Melo
2026-11-18  7:08   ` Namhyung Kim
2026-11-17 20:04 ` [PATCH v6 04/13] perf tests: Exercise DW_OP_addrx global variables Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 05/13] perf tests: Exercise the flexible array member path Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 06/13] perf annotate-data: Count flexible array accesses for the whole struct Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 07/13] perf tests: Exercise data type resolution from a register Arnaldo Carvalho de Melo
2026-11-18  7:16   ` Namhyung Kim [this message]
2026-11-17 20:04 ` [PATCH v6 08/13] perf annotate: Print the stats after the annotations Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 09/13] perf tests: Silence the libbfd probe in build-test Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 10/13] perf build: Record the display-only features in FEATURE-DUMP Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 11/13] perf tests: Fix the Intel PT virtual LBR check Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 12/13] perf test: Drop samples without an IP in the dlfilter test Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 13/13] perf test: Skip the LBR inline unwinding check when unsupported Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av1QxJZA36xcbcEL@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox