From: Brian Masney <masneyb@kernel.org>
To: Andrew Goodbody <andrew.goodbody@linaro.org>
Cc: Ettore Chimenti <ettore.chimenti@linaro.org>,
Tero Kristo <kristo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Michael Turquette <mturquette@linaro.org>,
Rouven Czerwinski <rouven.czerwinski@linaro.org>,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] clk: ti: fapll: Fix clock speed calculation
Date: Thu, 12 Nov 2026 13:44:49 -0500 [thread overview]
Message-ID: <avYJIZrFu19Ivcbz@x1g10> (raw)
In-Reply-To: <38a09248-032a-4144-9e56-6d52eef8c077@linaro.org>
On Thu, Nov 12, 2026 at 05:24:41PM +0000, Andrew Goodbody wrote:
> On 12/11/2026 01:12, Brian Masney wrote:
> > Hi Ettore,
> >
> > > The fractional part of the divider was being treated as 1/10000000
> > > whereas it is in fact 1/2^24 (1/16777216). This led to incorrect clock
> > > speeds being reported when a fractional divider was in use. Correct it.
> > > As well as fixing the clock speed calculation when read, also update the
> > > calculation on set in a similar manner.
> > >
> > > Fixes: 163152cbbe32 ("clk: ti: Add support for FAPLL on dm816x")
> > > Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
> >
> > Should there be a Co-Developed-By here and on the other patches?
>
> Not sure about that. This is my patch but is being submitted by Ettore in a
> series of patches that affect the clk system. We were working together on a
> project and at times each produced patches. Ettore has collected together
> this series for submission.
OK, I see. That makes sense. Thanks for confirming.
Brian
next prev parent reply other threads:[~2026-11-12 18:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 15:53 [PATCH v2 0/4] clk: ti: fapll/dm816x: clock tree and calculation fixes Ettore Chimenti
2026-10-28 15:53 ` [PATCH v2 1/4] clk: ti: fapll: remove ti_dt_clk_name helper Ettore Chimenti
2026-11-12 1:12 ` Brian Masney
2026-11-12 18:12 ` Andrew Goodbody
2026-10-28 15:53 ` [PATCH v2 2/4] clk: ti: fapll: Fix clock speed calculation Ettore Chimenti
2026-11-12 1:12 ` Brian Masney
2026-11-12 17:24 ` Andrew Goodbody
2026-11-12 18:44 ` Brian Masney [this message]
2026-10-28 15:53 ` [PATCH v2 3/4] clk: ti: fapll: print clock name that fails to register Ettore Chimenti
2026-10-28 15:53 ` [PATCH v2 4/4] clk-816x: add sys_ck clock as sys_clkin_ck alias Ettore Chimenti
2026-10-30 10:48 ` Ettore Chimenti
2026-11-11 18:53 ` Brian Masney
2026-11-12 0:01 ` Ettore Chimenti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avYJIZrFu19Ivcbz@x1g10 \
--to=masneyb@kernel.org \
--cc=andrew.goodbody@linaro.org \
--cc=bmasney+clk@redhat.com \
--cc=ettore.chimenti@linaro.org \
--cc=jbrunet+clk@baylibre.com \
--cc=kristo@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=rouven.czerwinski@linaro.org \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).