The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] dmaengine: qcom: hidma: avoid world-writable channel sysfs files
@ 2026-11-07 22:15 Hungyu Lin
  2026-11-16 20:54 ` Frank Li
  0 siblings, 1 reply; 2+ messages in thread
From: Hungyu Lin @ 2026-11-07 22:15 UTC (permalink / raw)
  To: okaya, vkoul
  Cc: Frank.Li, andy.shevchenko, linux-arm-kernel, linux-arm-msm,
	dmaengine, linux-kernel, dennylin0707

hidma_mgmt_init_sys() creates the per-channel priority and weight
attributes with S_IRUGO | S_IWUGO, so any local user can write them.
A write stores the new value and calls hidma_mgmt_setup(), which
programs it into the channel's QoS register.

Attributes declared with __ATTR() are checked at build time by
VERIFY_OCTAL_PERMISSIONS(), which rejects world-writable modes. These
two are created at runtime with a mode passed to
create_sysfs_entry_channel(), so the check does not reach them.

Make them writable by the owner only, the 0644 that __ATTR_RW() uses.

Fixes: 7f8f209fd6e0 ("dmaengine: add Qualcomm Technologies HIDMA management driver")
Cc: stable@vger.kernel.org
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
 drivers/dma/qcom/hidma_mgmt_sys.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/qcom/hidma_mgmt_sys.c b/drivers/dma/qcom/hidma_mgmt_sys.c
index 9672ef9ee8fc..53b991752e80 100644
--- a/drivers/dma/qcom/hidma_mgmt_sys.c
+++ b/drivers/dma/qcom/hidma_mgmt_sys.c
@@ -265,13 +265,13 @@ int hidma_mgmt_init_sys(struct hidma_mgmt_dev *mdev)
 	/* populate parameters that are per channel */
 	for (i = 0; i < mdev->dma_channels; i++) {
 		rc = create_sysfs_entry_channel(mdev, "priority",
-						(S_IRUGO | S_IWUGO), i,
+						0644, i,
 						mdev->chroots[i]);
 		if (rc)
 			return rc;
 
 		rc = create_sysfs_entry_channel(mdev, "weight",
-						(S_IRUGO | S_IWUGO), i,
+						0644, i,
 						mdev->chroots[i]);
 		if (rc)
 			return rc;
-- 
2.43.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dmaengine: qcom: hidma: avoid world-writable channel sysfs files
  2026-11-07 22:15 [PATCH] dmaengine: qcom: hidma: avoid world-writable channel sysfs files Hungyu Lin
@ 2026-11-16 20:54 ` Frank Li
  0 siblings, 0 replies; 2+ messages in thread
From: Frank Li @ 2026-11-16 20:54 UTC (permalink / raw)
  To: Hungyu Lin
  Cc: okaya, vkoul, Frank.Li, andy.shevchenko, linux-arm-kernel,
	linux-arm-msm, dmaengine, linux-kernel

On Sat, Nov 07, 2026 at 10:15:00PM +0000, Hungyu Lin wrote:
> [You don't often get email from dennylin0707@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> hidma_mgmt_init_sys() creates the per-channel priority and weight
> attributes with S_IRUGO | S_IWUGO, so any local user can write them.
> A write stores the new value and calls hidma_mgmt_setup(), which
> programs it into the channel's QoS register.
>
> Attributes declared with __ATTR() are checked at build time by
> VERIFY_OCTAL_PERMISSIONS(), which rejects world-writable modes. These
> two are created at runtime with a mode passed to
> create_sysfs_entry_channel(), so the check does not reach them.
>
> Make them writable by the owner only, the 0644 that __ATTR_RW() uses.
>
> Fixes: 7f8f209fd6e0 ("dmaengine: add Qualcomm Technologies HIDMA management driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/qcom/hidma_mgmt_sys.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/qcom/hidma_mgmt_sys.c b/drivers/dma/qcom/hidma_mgmt_sys.c
> index 9672ef9ee8fc..53b991752e80 100644
> --- a/drivers/dma/qcom/hidma_mgmt_sys.c
> +++ b/drivers/dma/qcom/hidma_mgmt_sys.c
> @@ -265,13 +265,13 @@ int hidma_mgmt_init_sys(struct hidma_mgmt_dev *mdev)
>         /* populate parameters that are per channel */
>         for (i = 0; i < mdev->dma_channels; i++) {
>                 rc = create_sysfs_entry_channel(mdev, "priority",
> -                                               (S_IRUGO | S_IWUGO), i,
> +                                               0644, i,
>                                                 mdev->chroots[i]);
>                 if (rc)
>                         return rc;
>
>                 rc = create_sysfs_entry_channel(mdev, "weight",
> -                                               (S_IRUGO | S_IWUGO), i,
> +                                               0644, i,
>                                                 mdev->chroots[i]);
>                 if (rc)
>                         return rc;
> --
> 2.43.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-16 20:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-07 22:15 [PATCH] dmaengine: qcom: hidma: avoid world-writable channel sysfs files Hungyu Lin
2026-11-16 20:54 ` Frank Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox