* [PATCH v3] tpm: xen-tpmfront: fix use-after-free in backend_changed()
@ 2026-11-20 4:26 Suyuan Wang via B4 Relay
2026-11-20 8:58 ` Jarkko Sakkinen
0 siblings, 1 reply; 3+ messages in thread
From: Suyuan Wang via B4 Relay @ 2026-11-20 4:26 UTC (permalink / raw)
To: jgg, jarkko; +Cc: sstabellini, jgross, xen-devel, linux-kernel, linux-integrity
From: Suyuan Wang <stevewong@hust.edu.cn>
When the backend moves to Closing or Closed, backend_changed()
unregisters the device and then keeps using it:
device_unregister(&dev->dev);
xenbus_frontend_closed(dev);
The xenbus watch callback that calls backend_changed() does not hold a
reference to the device. The tpm_chip registered by xen-tpmfront has dev
as its parent and holds a reference to it, but tpmfront_remove() drops
that reference when it unregisters the chip. So device_unregister() can
release the last reference and free the xenbus_device, and
xenbus_frontend_closed(dev) then accesses freed memory.
The stubdom based vTPM backend, the only one in use today, never
switches to Closing or Closed, so this path is not reached with it. It
is reached with any backend that follows the normal xenbus state
machine on shutdown.
Take a temporary reference before unregistering and drop it after
xenbus_frontend_closed(). This keeps dev alive for the last access and
keeps the existing order, in which TPM operations are stopped before
the frontend is marked Closed.
Found with a static analysis tool and checked by hand.
Co-developed-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
Signed-off-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
Signed-off-by: Suyuan Wang <stevewong@hust.edu.cn>
---
Changes in v3:
- Drop the Fixes tag (Jarkko). No code change.
Changes in v2:
- Say that the stubdom vTPM backend never reaches this path, and don't
ask for a stable backport (Juergen, Jarkko). No code change.
Compile tested on x86_64 (W=1, no new warnings). Not run with a Xen vTPM
backend.
v2: https://lore.kernel.org/all/20261119-xen-tpmfront-v2-1-e0e51c36360d@gmail.com/
v1: https://lore.kernel.org/all/20261119-xen-tpmfront-v1-1-bfabbbed462a@gmail.com/
---
drivers/char/tpm/xen-tpmfront.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
index 3c0cce57c4ae..1be925cca535 100644
--- a/drivers/char/tpm/xen-tpmfront.c
+++ b/drivers/char/tpm/xen-tpmfront.c
@@ -397,8 +397,11 @@ static void backend_changed(struct xenbus_device *dev,
case XenbusStateClosing:
case XenbusStateClosed:
+ /* device_unregister() can drop the last reference to dev */
+ get_device(&dev->dev);
device_unregister(&dev->dev);
xenbus_frontend_closed(dev);
+ put_device(&dev->dev);
break;
default:
break;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] tpm: xen-tpmfront: fix use-after-free in backend_changed()
2026-11-20 4:26 [PATCH v3] tpm: xen-tpmfront: fix use-after-free in backend_changed() Suyuan Wang via B4 Relay
@ 2026-11-20 8:58 ` Jarkko Sakkinen
2026-11-20 9:31 ` Wong Steve
0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Sakkinen @ 2026-11-20 8:58 UTC (permalink / raw)
To: shyckless
Cc: jgg, sstabellini, jgross, xen-devel, linux-kernel,
linux-integrity
On Fri, Nov 20, 2026 at 04:26:16AM +0000, Suyuan Wang via B4 Relay wrote:
> From: Suyuan Wang <stevewong@hust.edu.cn>
>
> When the backend moves to Closing or Closed, backend_changed()
> unregisters the device and then keeps using it:
>
> device_unregister(&dev->dev);
> xenbus_frontend_closed(dev);
>
> The xenbus watch callback that calls backend_changed() does not hold a
> reference to the device. The tpm_chip registered by xen-tpmfront has dev
> as its parent and holds a reference to it, but tpmfront_remove() drops
> that reference when it unregisters the chip. So device_unregister() can
> release the last reference and free the xenbus_device, and
> xenbus_frontend_closed(dev) then accesses freed memory.
>
> The stubdom based vTPM backend, the only one in use today, never
> switches to Closing or Closed, so this path is not reached with it. It
> is reached with any backend that follows the normal xenbus state
> machine on shutdown.
>
> Take a temporary reference before unregistering and drop it after
> xenbus_frontend_closed(). This keeps dev alive for the last access and
> keeps the existing order, in which TPM operations are stopped before
> the frontend is marked Closed.
>
> Found with a static analysis tool and checked by hand.
>
> Co-developed-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
> Signed-off-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
> Signed-off-by: Suyuan Wang <stevewong@hust.edu.cn>
> ---
> Changes in v3:
> - Drop the Fixes tag (Jarkko). No code change.
>
> Changes in v2:
> - Say that the stubdom vTPM backend never reaches this path, and don't
> ask for a stable backport (Juergen, Jarkko). No code change.
There's no use-after-free to fix.
Br, Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] tpm: xen-tpmfront: fix use-after-free in backend_changed()
2026-11-20 8:58 ` Jarkko Sakkinen
@ 2026-11-20 9:31 ` Wong Steve
0 siblings, 0 replies; 3+ messages in thread
From: Wong Steve @ 2026-11-20 9:31 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: jgg, sstabellini, jgross, xen-devel, linux-kernel,
linux-integrity
Hi Jarkko,
On Fri, Nov 20, 2026, Jarkko Sakkinen wrote:
> There's no use-after-free to fix.
OK, with the only backend in use never closing, there is nothing to
hit here. I'll drop this patch. Thanks to you and Juergen for looking
at it.
Thanks,
Suyuan
Jarkko Sakkinen <jarkko@kernel.org> 于2026年11月20日周五 16:58写道:
>
> On Fri, Nov 20, 2026 at 04:26:16AM +0000, Suyuan Wang via B4 Relay wrote:
> > From: Suyuan Wang <stevewong@hust.edu.cn>
> >
> > When the backend moves to Closing or Closed, backend_changed()
> > unregisters the device and then keeps using it:
> >
> > device_unregister(&dev->dev);
> > xenbus_frontend_closed(dev);
> >
> > The xenbus watch callback that calls backend_changed() does not hold a
> > reference to the device. The tpm_chip registered by xen-tpmfront has dev
> > as its parent and holds a reference to it, but tpmfront_remove() drops
> > that reference when it unregisters the chip. So device_unregister() can
> > release the last reference and free the xenbus_device, and
> > xenbus_frontend_closed(dev) then accesses freed memory.
> >
> > The stubdom based vTPM backend, the only one in use today, never
> > switches to Closing or Closed, so this path is not reached with it. It
> > is reached with any backend that follows the normal xenbus state
> > machine on shutdown.
> >
> > Take a temporary reference before unregistering and drop it after
> > xenbus_frontend_closed(). This keeps dev alive for the last access and
> > keeps the existing order, in which TPM operations are stopped before
> > the frontend is marked Closed.
> >
> > Found with a static analysis tool and checked by hand.
> >
> > Co-developed-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
> > Signed-off-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
> > Signed-off-by: Suyuan Wang <stevewong@hust.edu.cn>
> > ---
> > Changes in v3:
> > - Drop the Fixes tag (Jarkko). No code change.
> >
> > Changes in v2:
> > - Say that the stubdom vTPM backend never reaches this path, and don't
> > ask for a stable backport (Juergen, Jarkko). No code change.
>
> There's no use-after-free to fix.
>
> Br, Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-20 9:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 4:26 [PATCH v3] tpm: xen-tpmfront: fix use-after-free in backend_changed() Suyuan Wang via B4 Relay
2026-11-20 8:58 ` Jarkko Sakkinen
2026-11-20 9:31 ` Wong Steve
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox