linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Alexander Mikhalitsyn <alex@amutable.com>,
	Josef Bacik <josef@toxicpanda.com>,
	Christian Brauner <brauner@kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	David Howells <dhowells@redhat.com>, Jan Kara <jack@suse.cz>,
	Serge Hallyn <sergeh@kernel.org>, Kees Cook <kees@kernel.org>,
	Paul Moore <paul@paul-moore.com>,
	linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 00/13] Namespace for namespace roots
Date: Sat, 21 Nov 2026 00:35:56 +0200	[thread overview]
Message-ID: <awDLTJcDJnN0kgMS@kernel.org> (raw)
In-Reply-To: <CALCETrUnQjrWmSzL-FOqFF+_enxVsEM0On7orydXLCO-L2f23w@mail.gmail.com>

On Fri, Nov 20, 2026 at 11:53:30AM -0800, Andy Lutomirski wrote:
> >     nsfs: Support NS_USERNS_SET_IDMAP ioctl
> >
> >     Configuring UID, GID, and project ID mappings or disabling setgroups(2)
> >     for a user namespace currently requires writing to /proc/<pid>/uid_map,
> >     gid_map, projid_map, and setgroups, forcing container managers to spawn a
> >     live process before populating a filesystem owned by that user namespace.
> >
> >     Add the extensible NS_USERNS_SET_IDMAP ioctl on CLONE_NEWUSER nsfs file
> >     descriptors to atomically configure setgroups policy and UID, GID, and
> >     project ID mappings before any process enters the namespace. Enforce the
> >     same single-write and capability invariants against both current_cred()
> >     and filp->f_cred under userns_state_mutex.
> >
> >     Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> >
> 
> I'm highly in favor of this.  But maybe not as an ioctl.
> 
> If you have an nsfd for a userns and that nsfd is the "control" fd
> (however anyone decides this is formulated), why does f_cred matter?
> It should be possible to create a userns without privilege and
> SCM_RIGHTS the fd to a privileged uidmapd.  (I fixed the rather
> screwed up workflow for this in newuidmap/newgidmap a few weeks ago --
> this is remarkably easy to screw up.  It'll make it to a distro near
> you some day.  It's supposed to *work* even without CAP_SYS_ADMIN in
> the picture, and it did not.)

Sealing was part of my testing mostly to show that the flow itself
is robust for doing "whatever". I'm happier not to include it to the
patch set itself tbh.

+1 for syscall instead of ioctl routing.

I can also likely drop ROOTNS_WAIT and get that also through
pre-existing syscall path. Checking up a few things before
locking in but I think that this can be done.

I think this all is enough material for a single iteration, or I want
to see what world looks like after doing this. 

v4 did not produce anything from Sashiko so far, and I still fixed
couple of races too while doing this, so also on that side it makes
sense to iterate.

I skimmed your EPRIV email and get I get it yes but within the patch
set's scope I feel that it would go off the edge. So on that side, I'd
look compatibility of the features rather than bundle them into the
same patch set.

> 
> --Andy

Br, Jarkko

      reply	other threads:[~2026-11-20 22:36 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 23:13 [RFC PATCH v2 00/13] Namespace for namespace roots Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 01/13] nsproxy: Pass nsproxy to create_new_namespaces() Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 02/13] rootns: Add core infrastructure for root namespaces Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 03/13] rootns: Track init lifecycle via copy_process() and pid_namespace Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 04/13] rootns: Add rootns_create() system call Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 05/13] rootns: Add rootns_wait() " Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 06/13] rootns: Add rootns_kill() " Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 07/13] fork: Support CLONE_INTO_ROOTNS in clone3() Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 08/13] fs: Support FSCONFIG_SET_ROOTNS in fsconfig() Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 09/13] fs: Support installing rootns mount trees via move_mount() Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 10/13] arch: Wire up rootns system calls Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 11/13] docs: Document root namespace uAPI Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 12/13] selftests/rootns: Add root namespace test suite Jarkko Sakkinen
2026-11-17 23:13 ` [RFC PATCH v2 13/13] MAINTAINERS: Add entry for ROOT NAMESPACE Jarkko Sakkinen
2026-11-18 14:47 ` [RFC PATCH v2 00/13] Namespace for namespace roots Josef Bacik
2026-11-18 15:28   ` Jarkko Sakkinen
2026-11-18 15:39     ` Jarkko Sakkinen
2026-11-18 15:46       ` Jarkko Sakkinen
2026-11-18 16:59 ` Andy Lutomirski
2026-11-18 17:04   ` Jarkko Sakkinen
2026-11-18 17:08     ` Jarkko Sakkinen
2026-11-18 17:30       ` Jarkko Sakkinen
2026-11-18 17:46       ` Andy Lutomirski
2026-11-18 18:23         ` Jarkko Sakkinen
2026-11-19 17:30         ` Josef Bacik
2026-11-19 17:43           ` Jarkko Sakkinen
2026-11-19 17:51             ` Jarkko Sakkinen
2026-11-19 22:50           ` Andy Lutomirski
2026-11-19 23:27             ` Andy Lutomirski
2026-11-20 12:32               ` Alexander Mikhalitsyn
2026-11-20 13:13                 ` Jarkko Sakkinen
2026-11-20 13:24                   ` Alexander Mikhalitsyn
2026-11-20 13:57                     ` Jarkko Sakkinen
2026-11-20 19:35                       ` Jarkko Sakkinen
2026-11-20 19:47                         ` Andy Lutomirski
2026-11-20 19:48                         ` Jarkko Sakkinen
2026-11-20 19:53                           ` Andy Lutomirski
2026-11-20 22:35                             ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awDLTJcDJnN0kgMS@kernel.org \
    --to=jarkko@kernel.org \
    --cc=alex@amutable.com \
    --cc=brauner@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=jack@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=kees@kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=paul@paul-moore.com \
    --cc=sergeh@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).