The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: Add notification LED, vibrator, and UART support for Xiaomi Redmi 5A (riva)
@ 2026-08-10  6:26 kyufie
  2026-08-10  6:29 ` Krzysztof Kozlowski
  2026-08-10  7:08 ` Dmitry Baryshkov
  0 siblings, 2 replies; 3+ messages in thread
From: kyufie @ 2026-08-10  6:26 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, kyufie

This patch adds support for:
- Controlling the notification LED.
- Controlling the haptic vibrator.
- Communicating through serial port exposed as test points at the front and
  rear side of the phone's PCB.

Signed-off-by: kyufie <imkyufie@gmail.com>
---
 .../boot/dts/qcom/msm8917-xiaomi-riva.dts     | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
index 4ea4fbdb5..e74433f89 100644
--- a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
+++ b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
@@ -5,6 +5,7 @@
 
 /dts-v1/;
 
+#include <dt-bindings/leds/common.h>
 #include "msm8917-xiaomi-wingtech.dtsi"
 
 / {
@@ -13,6 +14,10 @@ / {
 
 	qcom,board-id = <0x1000b 1>, <0x1000b 2>;
 
+	chosen {
+		stdout-path = &blsp1_uart2;
+	};
+
 	battery: battery {
 		compatible = "simple-battery";
 		charge-full-design-microamp-hours = <3000000>;
@@ -23,6 +28,37 @@ battery: battery {
 		charge-term-current-microamp = <60000>;
 		voltage-min-design-microvolt = <3400000>;
 	};
+
+	vibrator {
+		compatible = "gpio-vibrator";
+		enable-gpios = <&tlmm 97 GPIO_ACTIVE_HIGH>;
+	};
+};
+
+&blsp1_i2c2 {
+	status = "okay";
+
+	led-controller@45 {
+		compatible = "awinic,aw2013";
+		reg = <0x45>;
+		vcc-supply = <&pm8937_l10>;
+		vio-supply = <&pm8937_l5>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		status = "okay";
+
+		led@0 {
+			reg = <0>;
+			led-max-microamp = <5000>;
+			function = LED_FUNCTION_INDICATOR;
+			color = <LED_COLOR_ID_WHITE>;
+		};
+	};
+};
+
+&blsp1_uart2 {
+	status = "okay";
 };
 
 &blsp2_i2c1 {

base-commit: 6b8c8af514d739d0335f5579b585e02babe8a727
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: Add notification LED, vibrator, and UART support for Xiaomi Redmi 5A (riva)
  2026-08-10  6:26 [PATCH] arm64: dts: qcom: Add notification LED, vibrator, and UART support for Xiaomi Redmi 5A (riva) kyufie
@ 2026-08-10  6:29 ` Krzysztof Kozlowski
  2026-08-10  7:08 ` Dmitry Baryshkov
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-10  6:29 UTC (permalink / raw)
  To: kyufie, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 10/08/2026 08:26, kyufie wrote:
> This patch adds support for:

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94

> - Controlling the notification LED.
> - Controlling the haptic vibrator.
> - Communicating through serial port exposed as test points at the front and
>   rear side of the phone's PCB.
> 
> Signed-off-by: kyufie <imkyufie@gmail.com>

Please read the entire submitting patches document, including how to
organize your changes and how to properly sign off your contributions.
We do not take anonymous contributions.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: Add notification LED, vibrator, and UART support for Xiaomi Redmi 5A (riva)
  2026-08-10  6:26 [PATCH] arm64: dts: qcom: Add notification LED, vibrator, and UART support for Xiaomi Redmi 5A (riva) kyufie
  2026-08-10  6:29 ` Krzysztof Kozlowski
@ 2026-08-10  7:08 ` Dmitry Baryshkov
  1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2026-08-10  7:08 UTC (permalink / raw)
  To: kyufie
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel

On Mon, Aug 10, 2026 at 01:26:12PM +0700, kyufie wrote:
> This patch adds support for:
> - Controlling the notification LED.
> - Controlling the haptic vibrator.
> - Communicating through serial port exposed as test points at the front and
>   rear side of the phone's PCB.
> 
> Signed-off-by: kyufie <imkyufie@gmail.com>

This should contain your name.

The patch itself LGTM.

> ---
>  .../boot/dts/qcom/msm8917-xiaomi-riva.dts     | 36 +++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-10  7:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-10  6:26 [PATCH] arm64: dts: qcom: Add notification LED, vibrator, and UART support for Xiaomi Redmi 5A (riva) kyufie
2026-08-10  6:29 ` Krzysztof Kozlowski
2026-08-10  7:08 ` Dmitry Baryshkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox