The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: justin.chen@broadcom.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: florian.fainelli@broadcom.com, conor+dt@kernel.org,
	krzk+dt@kernel.org, robh@kernel.org, jassisinghbrar@gmail.com,
	bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v3 1/2] dt-bindings: mailbox: Add support for bcm74110
Date: Sun, 6 Apr 2025 14:27:52 +0200	[thread overview]
Message-ID: <b32aa644-6984-476b-abc0-a5416f551bba@kernel.org> (raw)
In-Reply-To: <20250404222058.396134-2-justin.chen@broadcom.com>

On 05/04/2025 00:20, justin.chen@broadcom.com wrote:
> +
> +maintainers:
> +  - Justin Chen <justin.chen@broadcom.com>
> +  - Florian Fainelli <florian.fainelli@broadcom.com>
> +
> +description: Broadcom mailbox hardware first introduced with 74110
> +
> +properties:
> +  compatible:
> +    enum:
> +      - brcm,bcm74110-mbox
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    minItems: 1

Third version of patchset, third entirely different code.

Decide finally what is the hardware and send binding matching it.
Hardware did not change last one week three times.

Drop minItems or explain why this is flexible on the same SoC or between
boards using same SoC. You can always point me to upstream DTS, which
would solve many questions.

> +    items:
> +      - description: RX doorbell and watermark interrupts
> +      - description: TX doorbell and watermark interrupts
> +


Best regards,
Krzysztof

  reply	other threads:[~2025-04-06 12:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04 22:20 [PATCH v3 0/2] mailbox: Add support for bcm74110 justin.chen
2025-04-04 22:20 ` [PATCH v3 1/2] dt-bindings: " justin.chen
2025-04-06 12:27   ` Krzysztof Kozlowski [this message]
2025-04-07 20:57     ` Justin Chen
2025-04-08  6:05       ` Krzysztof Kozlowski
2025-04-10 18:44         ` Justin Chen
2025-04-25  6:28           ` Krzysztof Kozlowski
2025-04-04 22:20 ` [PATCH v3 2/2] " justin.chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b32aa644-6984-476b-abc0-a5416f551bba@kernel.org \
    --to=krzk@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=justin.chen@broadcom.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox