From: Justin Chen <justin.chen@broadcom.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: florian.fainelli@broadcom.com, conor+dt@kernel.org,
krzk+dt@kernel.org, robh@kernel.org, jassisinghbrar@gmail.com,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v3 1/2] dt-bindings: mailbox: Add support for bcm74110
Date: Thu, 10 Apr 2025 11:44:40 -0700 [thread overview]
Message-ID: <e0e7952b-a308-4fb7-8af6-d4802e7a5080@broadcom.com> (raw)
In-Reply-To: <8abcf2bf-77cb-4380-bdc4-95c3796a96f0@kernel.org>
On 4/7/25 11:05 PM, Krzysztof Kozlowski wrote:
> On 07/04/2025 22:57, Justin Chen wrote:
>
>
>> from v2 of my patch was copied from said generated DTS.
>>
>> Apologies as I navigate through the different yaml keywords here. The HW
>> isn't changing, I am just struggling with representing the HW using the
>> different keywords. And the different implications of using said keywords.
>>
>> Here is what I have for v4.
>> items:
>> - description: RX doorbell and watermark interrupts
>> - description: TX doorbell and watermark interrupts
>> + description:
>> + RX interrupts are required to notify the host of pending messages. TX
>> + interrupts are optional. The TX doorbell interrupt is not used by the
>> + host, but watermark interrupts may be used to notify a host
>> waiting on
>> + a full out queue.
> What does it mean optional? Board decides on SoC connections? Given SoC
> is fixed isn't it?
>
Maybe I misunderstand optional here. We have optional from the SoC
perspective and optional from a driver perspective. I was thinking if we
have a HW feature that the software may choose to use, it is considered
optional. If that is not the correct understanding, I can make
adjustments. I will remove minItems, which from understanding, means
both IRQs are required.
Thanks,
Justin
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2025-04-10 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 22:20 [PATCH v3 0/2] mailbox: Add support for bcm74110 justin.chen
2025-04-04 22:20 ` [PATCH v3 1/2] dt-bindings: " justin.chen
2025-04-06 12:27 ` Krzysztof Kozlowski
2025-04-07 20:57 ` Justin Chen
2025-04-08 6:05 ` Krzysztof Kozlowski
2025-04-10 18:44 ` Justin Chen [this message]
2025-04-25 6:28 ` Krzysztof Kozlowski
2025-04-04 22:20 ` [PATCH v3 2/2] " justin.chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0e7952b-a308-4fb7-8af6-d4802e7a5080@broadcom.com \
--to=justin.chen@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox