public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Diederik de Haas <diederik@cknow-tech.com>,
	Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Detlev Casanova <detlev.casanova@collabora.com>,
	kernel@collabora.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576
Date: Mon, 23 Feb 2026 19:07:42 +0200	[thread overview]
Message-ID: <b4eb3031-69e8-4a73-b4f1-91dd4192bb21@collabora.com> (raw)
In-Reply-To: <DGMF3IX3J3BP.1XT41P0G8P5OD@cknow-tech.com>

On 2/23/26 4:39 PM, Diederik de Haas wrote:
> On Mon Feb 23, 2026 at 3:31 PM CET, Sebastian Reichel wrote:
>> On Mon, Feb 23, 2026 at 02:25:05PM +0200, Cristian Ciocaltea wrote:
>>> When building device trees for the RK3576 based boards, DTC shows the
>>> following complaint:
>>>
>>>   rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg): /soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100"
>>>
>>> Provide the register blocks in the expected address-based order.
>>>
>>> Fixes: da0de806d8b4 ("arm64: dts: rockchip: Add the vdpu383 Video Decoder on rk3576")
>>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>>> ---
>>
>> This fixes this warning, but instead creates a new one, because the
>> reg-names order is fixed in the DT binding:
>>
>>    reg:
>>      minItems: 1
>>      items:
>>        - description: The function configuration registers base
>>        - description: The link table configuration registers base
>>        - description: The cache configuration registers base
>>   
>>    reg-names:
>>      items:
>>        - const: function
>>        - const: link
>>        - const: cache

Oh, right, missed to check the binding.. :-(

> 
> See also the prior discussion wrt this:
> https://lore.kernel.org/linux-rockchip/edabca63-594e-44ae-8a3d-0f60987a8664@collabora.com/

That's interesting, I'm also not able to trigger the warning on RK3588.

Regardless, the binding can be easily adjusted with the patch below.  Hence I'm
going to handle this in v2, unless there's a reason against moving further.

Thanks,
Cristian


--- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
@@ -34,10 +34,12 @@ properties:
       - description: The cache configuration registers base

   reg-names:
-    items:
+    oneOf:
       - const: function
-      - const: link
-      - const: cache
+      - items:
+          - const: link
+          - const: function
+          - const: cache

   interrupts:
     maxItems: 1


  reply	other threads:[~2026-02-23 17:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 12:25 [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576 Cristian Ciocaltea
2026-02-23 14:31 ` Sebastian Reichel
2026-02-23 14:39   ` Diederik de Haas
2026-02-23 17:07     ` Cristian Ciocaltea [this message]
2026-02-23 18:08       ` Nicolas Dufresne
2026-02-23 18:21       ` Sebastian Reichel
2026-02-23 18:29         ` Cristian Ciocaltea
2026-02-23 20:02           ` Cristian Ciocaltea
2026-02-23 14:51 ` Nicolas Dufresne
2026-02-23 17:19   ` Cristian Ciocaltea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4eb3031-69e8-4a73-b4f1-91dd4192bb21@collabora.com \
    --to=cristian.ciocaltea@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=detlev.casanova@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=diederik@cknow-tech.com \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox