The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [RESEND PATCH v2] x86/tsx: Set default TSX mode to auto
@ 2025-11-12 19:05 Nikolay Borisov
  2025-11-12 19:13 ` Dave Hansen
  2026-01-06 17:27 ` [tip: x86/cpu] " tip-bot2 for Nikolay Borisov
  0 siblings, 2 replies; 4+ messages in thread
From: Nikolay Borisov @ 2025-11-12 19:05 UTC (permalink / raw)
  To: x86; +Cc: dave.hansen, mhocko, asit.k.mallick, linux-kernel,
	Nikolay Borisov

At SUSE we've been releasing our kernels with TSX enabled for the past 6
years and some customers have started to rely on it. Furthermore, the last
known vulnerability concerning TSX was TAA (CVE-2019-11135) and a
significant amount time has passed since then without anyone reporting any
issues. Intel has released numerous processors which do not have the
TAA vulnerability (Cooper/Ice Lake, Sapphire/Emerald/Granite Rappids)
yet TSX remains being disabled by default.

The main aim of this patch is to reduce the divergence between SUSE's
configuration and the upstream by switching the default TSX mode to
auto. I believe this strikes the right balance between keeping it
enabled where appropriate (i.e every machine which doesn't contain the
TAA vulnerability) and disabling it preventively.

Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
---

Changes since v2:

 * Reworded the changelog log to hopefully make it clear that this has been in
 use for quite some time.
 arch/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index fa3b616af03a..83f5132e2212 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1812,7 +1812,7 @@ config ARCH_PKEY_BITS
 choice
 	prompt "TSX enable mode"
 	depends on CPU_SUP_INTEL
-	default X86_INTEL_TSX_MODE_OFF
+	default X86_INTEL_TSX_MODE_AUTO
 	help
 	  Intel's TSX (Transactional Synchronization Extensions) feature
 	  allows to optimize locking protocols through lock elision which
--
2.51.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [RESEND PATCH v2] x86/tsx: Set default TSX mode to auto
  2025-11-12 19:05 [RESEND PATCH v2] x86/tsx: Set default TSX mode to auto Nikolay Borisov
@ 2025-11-12 19:13 ` Dave Hansen
  2025-12-09  7:01   ` Nikolay Borisov
  2026-01-06 17:27 ` [tip: x86/cpu] " tip-bot2 for Nikolay Borisov
  1 sibling, 1 reply; 4+ messages in thread
From: Dave Hansen @ 2025-11-12 19:13 UTC (permalink / raw)
  To: Nikolay Borisov, x86; +Cc: dave.hansen, mhocko, asit.k.mallick, linux-kernel

On 11/12/25 11:05, Nikolay Borisov wrote:
> At SUSE we've been releasing our kernels with TSX enabled for the past 6
> years and some customers have started to rely on it. Furthermore, the last
> known vulnerability concerning TSX was TAA (CVE-2019-11135) and a
> significant amount time has passed since then without anyone reporting any
> issues. Intel has released numerous processors which do not have the
> TAA vulnerability (Cooper/Ice Lake, Sapphire/Emerald/Granite Rappids)
> yet TSX remains being disabled by default.
> 
> The main aim of this patch is to reduce the divergence between SUSE's
> configuration and the upstream by switching the default TSX mode to
> auto. I believe this strikes the right balance between keeping it
> enabled where appropriate (i.e every machine which doesn't contain the
> TAA vulnerability) and disabling it preventively.

This seems pretty sane to me. TSX is far less scary than it once was. It
seemed to be a key part of a bunch of the speculation gadgets at some
point, but having it off by default doesn't really seem to have slowed
anyone down.

Plus, this won't even change anyone's builds that has a .config from the
last 5 years.

Does anyone feel differently?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RESEND PATCH v2] x86/tsx: Set default TSX mode to auto
  2025-11-12 19:13 ` Dave Hansen
@ 2025-12-09  7:01   ` Nikolay Borisov
  0 siblings, 0 replies; 4+ messages in thread
From: Nikolay Borisov @ 2025-12-09  7:01 UTC (permalink / raw)
  To: Dave Hansen, x86; +Cc: dave.hansen, mhocko, asit.k.mallick, linux-kernel



On 12.11.25 г. 21:13 ч., Dave Hansen wrote:
> On 11/12/25 11:05, Nikolay Borisov wrote:
>> At SUSE we've been releasing our kernels with TSX enabled for the past 6
>> years and some customers have started to rely on it. Furthermore, the last
>> known vulnerability concerning TSX was TAA (CVE-2019-11135) and a
>> significant amount time has passed since then without anyone reporting any
>> issues. Intel has released numerous processors which do not have the
>> TAA vulnerability (Cooper/Ice Lake, Sapphire/Emerald/Granite Rappids)
>> yet TSX remains being disabled by default.
>>
>> The main aim of this patch is to reduce the divergence between SUSE's
>> configuration and the upstream by switching the default TSX mode to
>> auto. I believe this strikes the right balance between keeping it
>> enabled where appropriate (i.e every machine which doesn't contain the
>> TAA vulnerability) and disabling it preventively.
> 
> This seems pretty sane to me. TSX is far less scary than it once was. It
> seemed to be a key part of a bunch of the speculation gadgets at some
> point, but having it off by default doesn't really seem to have slowed
> anyone down.
> 
> Plus, this won't even change anyone's builds that has a .config from the
> last 5 years.
> 
> Does anyone feel differently?

So at the end of the day what is the status of this, will it get merged?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [tip: x86/cpu] x86/tsx: Set default TSX mode to auto
  2025-11-12 19:05 [RESEND PATCH v2] x86/tsx: Set default TSX mode to auto Nikolay Borisov
  2025-11-12 19:13 ` Dave Hansen
@ 2026-01-06 17:27 ` tip-bot2 for Nikolay Borisov
  1 sibling, 0 replies; 4+ messages in thread
From: tip-bot2 for Nikolay Borisov @ 2026-01-06 17:27 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: Nikolay Borisov, Dave Hansen, x86, linux-kernel

The following commit has been merged into the x86/cpu branch of tip:

Commit-ID:     f8c7600d468bdb6e44ed3b3247c6e53f5be5d8de
Gitweb:        https://git.kernel.org/tip/f8c7600d468bdb6e44ed3b3247c6e53f5be5d8de
Author:        Nikolay Borisov <nik.borisov@suse.com>
AuthorDate:    Wed, 12 Nov 2025 21:05:48 +02:00
Committer:     Dave Hansen <dave.hansen@linux.intel.com>
CommitterDate: Tue, 06 Jan 2026 09:23:30 -08:00

x86/tsx: Set default TSX mode to auto

At SUSE we've been releasing our kernels with TSX enabled for the past 6
years and some customers have started to rely on it. Furthermore, the last
known vulnerability concerning TSX was TAA (CVE-2019-11135) and a
significant amount time has passed since then without anyone reporting any
issues. Intel has released numerous processors which do not have the
TAA vulnerability (Cooper/Ice Lake, Sapphire/Emerald/Granite Rappids)
yet TSX remains being disabled by default.

The main aim of this patch is to reduce the divergence between SUSE's
configuration and the upstream by switching the default TSX mode to
auto. I believe this strikes the right balance between keeping it
enabled where appropriate (i.e every machine which doesn't contain the
TAA vulnerability) and disabling it preventively.

Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Link: https://patch.msgid.link/20251112190548.750746-1-nik.borisov@suse.com
---
 arch/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 8052729..f1c98a9 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1816,7 +1816,7 @@ config ARCH_PKEY_BITS
 choice
 	prompt "TSX enable mode"
 	depends on CPU_SUP_INTEL
-	default X86_INTEL_TSX_MODE_OFF
+	default X86_INTEL_TSX_MODE_AUTO
 	help
 	  Intel's TSX (Transactional Synchronization Extensions) feature
 	  allows to optimize locking protocols through lock elision which

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-01-06 17:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-12 19:05 [RESEND PATCH v2] x86/tsx: Set default TSX mode to auto Nikolay Borisov
2025-11-12 19:13 ` Dave Hansen
2025-12-09  7:01   ` Nikolay Borisov
2026-01-06 17:27 ` [tip: x86/cpu] " tip-bot2 for Nikolay Borisov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox