The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Nikolay Borisov <nik.borisov@suse.com>
To: Yosry Ahmed <yosry@kernel.org>, Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/7] KVM: x86: Move supported EFER bits to kvm_caps
Date: Fri, 10 Jul 2026 15:56:52 +0300	[thread overview]
Message-ID: <b7f92bcf-c36f-4ec1-868d-b88a14fc7ec2@suse.com> (raw)
In-Reply-To: <20260706195413.1966458-7-yosry@kernel.org>



On 7/6/26 22:54, Yosry Ahmed wrote:
> Supported EFER bits naturally fits into kvm_caps because it needs to be
> recomputed during vendor init (e.g. to account for EFER.SVME being
> allowed/disallowed based on nested being enabled/disabled).
> 
> Move efer_supported_bits into kvm_caps as supported_efer_bits (for
> naming consistency), and reinitialize it at the beginning of
> kvm_setup_efer_caps(), removing the need to clear unsupported bits in
> vendor code (e.g. EFER.SVME).
> 
> As the bitmask is now globally visible as part of kvm_caps, there's
> little use for helpers to enable/disable specific bits, so drop them and
> open-code updates to kvm_caps.supported_efer_bits.
> 
> No functional change intended.
> 
> Suggested-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Yosry Ahmed <yosry@kernel.org>

Reviewed-by: Nikolay Borisov <nik.borisov@suse.com>

<snip>

  reply	other threads:[~2026-07-10 12:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 19:54 [PATCH v2 0/7] KVM: x86: EFER validity fixes and cleanups Yosry Ahmed
2026-07-06 19:54 ` [PATCH v2 1/7] KVM: x86: Check EFER validity on KVM_SET_SREGS* Yosry Ahmed
2026-07-06 19:54 ` [PATCH v2 2/7] KVM: SVM: Disallow EFER.SVME and EFER.LSMLE if nested is disabled Yosry Ahmed
2026-07-06 19:54 ` [PATCH v2 3/7] KVM: x86: Disallow EFER.LME and EFER.LMA if long mode is not supported Yosry Ahmed
2026-07-06 19:54 ` [PATCH v2 4/7] KVM: x86: Add a per-vendor callback to setup EFER caps Yosry Ahmed
2026-07-07 21:56   ` Sean Christopherson
2026-07-07 22:29     ` Yosry Ahmed
2026-07-08 14:01       ` Sean Christopherson
2026-07-08 19:12         ` Yosry Ahmed
2026-07-08 20:56           ` Sean Christopherson
2026-07-08 21:34             ` Yosry Ahmed
2026-07-06 19:54 ` [PATCH v2 5/7] KVM: x86: Reverse the polarity of efer_reserved_bits Yosry Ahmed
2026-07-10 10:23   ` Nikolay Borisov
2026-07-06 19:54 ` [PATCH v2 6/7] KVM: x86: Move supported EFER bits to kvm_caps Yosry Ahmed
2026-07-10 12:56   ` Nikolay Borisov [this message]
2026-07-06 19:54 ` [PATCH v2 7/7] KVM: selftests: Extend set_sregs test to cover EFER Yosry Ahmed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7f92bcf-c36f-4ec1-868d-b88a14fc7ec2@suse.com \
    --to=nik.borisov@suse.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=yosry@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox