* [PATCH] arm64: defconfig: Drop duplicate CONFIG_OMAP_USB2 entry
@ 2025-10-14 18:20 Prabhakar
2025-10-14 22:00 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Prabhakar @ 2025-10-14 18:20 UTC (permalink / raw)
To: Geert Uytterhoeven, Krzysztof Kozlowski, Arnd Bergmann,
Nishanth Menon, Bjorn Andersson
Cc: linux-kernel, linux-renesas-soc, Prabhakar, Biju Das,
Fabrizio Castro, Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
CONFIG_OMAP_USB2 is already enabled as a module in the default defconfig
since commit 8a703a728a745 ("arm64: defconfig: Enable USB2 PHY Driver").
Remove the duplicate entry to fix the following warning:
arch/arm64/configs/defconfig:1705:warning: override: reassigning to symbol OMAP_USB2
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
arch/arm64/configs/defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index e401915e2f2f..478ca72c0aeb 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1702,7 +1702,6 @@ CONFIG_PHY_UNIPHIER_USB3=y
CONFIG_PHY_TEGRA_XUSB=y
CONFIG_PHY_AM654_SERDES=m
CONFIG_PHY_J721E_WIZ=m
-CONFIG_OMAP_USB2=m
CONFIG_PHY_XILINX_ZYNQMP=m
CONFIG_ARM_CCI_PMU=m
CONFIG_ARM_CCN=m
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: defconfig: Drop duplicate CONFIG_OMAP_USB2 entry
2025-10-14 18:20 [PATCH] arm64: defconfig: Drop duplicate CONFIG_OMAP_USB2 entry Prabhakar
@ 2025-10-14 22:00 ` Krzysztof Kozlowski
2025-10-14 22:03 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-14 22:00 UTC (permalink / raw)
To: Prabhakar, Geert Uytterhoeven, Krzysztof Kozlowski, Arnd Bergmann,
Nishanth Menon, Bjorn Andersson
Cc: linux-kernel, linux-renesas-soc, Biju Das, Fabrizio Castro,
Lad Prabhakar
On 14/10/2025 20:20, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> CONFIG_OMAP_USB2 is already enabled as a module in the default defconfig
> since commit 8a703a728a745 ("arm64: defconfig: Enable USB2 PHY Driver").
> Remove the duplicate entry to fix the following warning:
>
> arch/arm64/configs/defconfig:1705:warning: override: reassigning to symbol OMAP_USB2
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> arch/arm64/configs/defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index e401915e2f2f..478ca72c0aeb 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1702,7 +1702,6 @@ CONFIG_PHY_UNIPHIER_USB3=y
> CONFIG_PHY_TEGRA_XUSB=y
> CONFIG_PHY_AM654_SERDES=m
> CONFIG_PHY_J721E_WIZ=m
> -CONFIG_OMAP_USB2=m
I don't understand. There is no such line in defconfig. Which next are
you referring to? Was it just broken in Renesas tree?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: defconfig: Drop duplicate CONFIG_OMAP_USB2 entry
2025-10-14 22:00 ` Krzysztof Kozlowski
@ 2025-10-14 22:03 ` Krzysztof Kozlowski
2025-10-15 9:01 ` Lad, Prabhakar
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-14 22:03 UTC (permalink / raw)
To: Prabhakar, Geert Uytterhoeven, Krzysztof Kozlowski, Arnd Bergmann,
Nishanth Menon, Bjorn Andersson
Cc: linux-kernel, linux-renesas-soc, Biju Das, Fabrizio Castro,
Lad Prabhakar, michal.simek@amd.com
On 15/10/2025 00:00, Krzysztof Kozlowski wrote:
> On 14/10/2025 20:20, Prabhakar wrote:
>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>
>> CONFIG_OMAP_USB2 is already enabled as a module in the default defconfig
>> since commit 8a703a728a745 ("arm64: defconfig: Enable USB2 PHY Driver").
>> Remove the duplicate entry to fix the following warning:
>>
>> arch/arm64/configs/defconfig:1705:warning: override: reassigning to symbol OMAP_USB2
>>
>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>> ---
>> arch/arm64/configs/defconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index e401915e2f2f..478ca72c0aeb 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -1702,7 +1702,6 @@ CONFIG_PHY_UNIPHIER_USB3=y
>> CONFIG_PHY_TEGRA_XUSB=y
>> CONFIG_PHY_AM654_SERDES=m
>> CONFIG_PHY_J721E_WIZ=m
>> -CONFIG_OMAP_USB2=m
>
> I don't understand. There is no such line in defconfig. Which next are
> you referring to? Was it just broken in Renesas tree?
>
Ah, no, it got broken by Michal. You should add proper fixes tag which
results in automatic Cc.
@Michal,
Are you sure your commit did not introduce more of such issues?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: defconfig: Drop duplicate CONFIG_OMAP_USB2 entry
2025-10-14 22:03 ` Krzysztof Kozlowski
@ 2025-10-15 9:01 ` Lad, Prabhakar
0 siblings, 0 replies; 4+ messages in thread
From: Lad, Prabhakar @ 2025-10-15 9:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Geert Uytterhoeven, Krzysztof Kozlowski, Arnd Bergmann,
Nishanth Menon, Bjorn Andersson, linux-kernel, linux-renesas-soc,
Biju Das, Fabrizio Castro, Lad Prabhakar, michal.simek@amd.com
On Tue, Oct 14, 2025 at 11:03 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 15/10/2025 00:00, Krzysztof Kozlowski wrote:
> > On 14/10/2025 20:20, Prabhakar wrote:
> >> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >>
> >> CONFIG_OMAP_USB2 is already enabled as a module in the default defconfig
> >> since commit 8a703a728a745 ("arm64: defconfig: Enable USB2 PHY Driver").
> >> Remove the duplicate entry to fix the following warning:
> >>
> >> arch/arm64/configs/defconfig:1705:warning: override: reassigning to symbol OMAP_USB2
> >>
> >> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >> ---
> >> arch/arm64/configs/defconfig | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> >> index e401915e2f2f..478ca72c0aeb 100644
> >> --- a/arch/arm64/configs/defconfig
> >> +++ b/arch/arm64/configs/defconfig
> >> @@ -1702,7 +1702,6 @@ CONFIG_PHY_UNIPHIER_USB3=y
> >> CONFIG_PHY_TEGRA_XUSB=y
> >> CONFIG_PHY_AM654_SERDES=m
> >> CONFIG_PHY_J721E_WIZ=m
> >> -CONFIG_OMAP_USB2=m
> >
> > I don't understand. There is no such line in defconfig. Which next are
> > you referring to? Was it just broken in Renesas tree?
> >
> Ah, no, it got broken by Michal. You should add proper fixes tag which
> results in automatic Cc.
>
Sorry I missed that, I'll add the below and send a v2.
Fixes: 91fe3315cdf9f ("arm64: defconfig: Enable missing AMD/Xilinx drivers")
Cheers,
Prabhakar
> @Michal,
>
> Are you sure your commit did not introduce more of such issues?
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-15 9:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-14 18:20 [PATCH] arm64: defconfig: Drop duplicate CONFIG_OMAP_USB2 entry Prabhakar
2025-10-14 22:00 ` Krzysztof Kozlowski
2025-10-14 22:03 ` Krzysztof Kozlowski
2025-10-15 9:01 ` Lad, Prabhakar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox