From: Krzysztof Kozlowski <krzk@kernel.org>
To: Woodrow Douglass <wdouglass@carnegierobotics.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] regulator: pf530x: Add a driver for the NXP PF5300 Regulator
Date: Thu, 4 Sep 2025 07:44:33 +0200 [thread overview]
Message-ID: <b893b98a-59f8-4b0a-b42a-66046bfa7435@kernel.org> (raw)
In-Reply-To: <20250902-pf530x-v4-1-4727f112424e@carnegierobotics.com>
On 03/09/2025 22:03, Woodrow Douglass wrote:
> This driver allows reading some regulator settings and adjusting
> output voltage. It is based on information from the datasheet
> at https://www.nxp.com/docs/en/data-sheet/PF5300.pdf
>
> Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>
> ---
> MAINTAINERS | 6 +
> drivers/regulator/Kconfig | 12 ++
> drivers/regulator/Makefile | 1 +
> drivers/regulator/pf530x-regulator.c | 378 +++++++++++++++++++++++++++++++++++
> 4 files changed, 397 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6dcfbd11efef..2c2d165a40ff 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18291,6 +18291,12 @@ F: Documentation/devicetree/bindings/clock/*imx*
> F: drivers/clk/imx/
> F: include/dt-bindings/clock/*imx*
>
> +NXP PF5300/PF5301/PF5302 PMIC REGULATOR DEVICE DRIVER
> +M: Woodrow Douglass <wdouglass@carnegierobotics.com>
> +S: Maintained
> +F: Documentation/devicetree/bindings/regulator/nxp,pf530x-regulator.yaml
There is no such file at this stage.... but if you fix order, it would
be. Anyway, please be sure your patchsets are properly bisectable.
Please organize the patch documenting compatible (DT bindings) before
their user.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-04 5:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 20:03 [PATCH v4 0/2] regulator: pf530x: NXP PF530x regulator driver Woodrow Douglass
2025-09-03 20:03 ` [PATCH v4 1/2] regulator: pf530x: Add a driver for the NXP PF5300 Regulator Woodrow Douglass
2025-09-04 5:44 ` Krzysztof Kozlowski [this message]
2025-09-03 20:03 ` [PATCH v4 2/2] regulator: pf530x: dt-bindings: nxp,pf530x-regulator Woodrow Douglass
2025-09-03 23:27 ` Rob Herring (Arm)
2025-09-04 5:44 ` Krzysztof Kozlowski
2025-09-04 11:33 ` Mark Brown
2025-09-04 12:58 ` Woody Douglass
2025-09-04 13:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b893b98a-59f8-4b0a-b42a-66046bfa7435@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wdouglass@carnegierobotics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox