From: Krzysztof Kozlowski <krzk@kernel.org>
To: Woody Douglass <wdouglass@carnegierobotics.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] regulator: pf530x: dt-bindings: nxp,pf530x-regulator
Date: Thu, 4 Sep 2025 15:05:55 +0200 [thread overview]
Message-ID: <82674a79-75eb-4bdf-8ae2-b687719e2dcc@kernel.org> (raw)
In-Reply-To: <45ab7df9-f547-47c8-817d-c3f7be600300@carnegierobotics.com>
On 04/09/2025 14:58, Woody Douglass wrote:
>>> +description: |
>>> + The PF5300, PF5301, and PF5302 integrate high-performance buck converters,
>>> + 12 A, 8 A, and 15 A, respectively, to power high-end automotive and industrial
>>> + processors. With adaptive voltage positioning and a high-bandwidth loop, they
>>> + offer transient regulation to minimize capacitor requirements.
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - nxp,pf5300
>>> + - nxp,pf5301
>>> + - nxp,pf5302
>>
>> Still compatibility not expressed.
>>
>
> I'm sorry for the misunderstanding here -- I did reply (as Mark Brown mentioned in his
> reply to this email) in the cover letter for v3 of this patch (this message
> https://lore.kernel.org/lkml/20250902-pf530x-v3-0-4242e7687761@carnegierobotics.com/).
> Mark is right, I don't really understand what you're asking for, and other bindings for
> regulators seem to list off each compatible model in the way that I have. I have prepared
> a v5 of this patchset that incorporates the various comments, but I'll wait for some
> clarification here before submitting it.
Quick look at the driver suggests devices are fully compatible, so you
should express it with dedicated and fallback compatibles. See
example-schema or my OSSE25 beginners talk.
It might be that devices are not compatible, then it is enough to
explain that briefly (why they are not compatible) in the commit msg.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-09-04 13:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 20:03 [PATCH v4 0/2] regulator: pf530x: NXP PF530x regulator driver Woodrow Douglass
2025-09-03 20:03 ` [PATCH v4 1/2] regulator: pf530x: Add a driver for the NXP PF5300 Regulator Woodrow Douglass
2025-09-04 5:44 ` Krzysztof Kozlowski
2025-09-03 20:03 ` [PATCH v4 2/2] regulator: pf530x: dt-bindings: nxp,pf530x-regulator Woodrow Douglass
2025-09-03 23:27 ` Rob Herring (Arm)
2025-09-04 5:44 ` Krzysztof Kozlowski
2025-09-04 11:33 ` Mark Brown
2025-09-04 12:58 ` Woody Douglass
2025-09-04 13:05 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82674a79-75eb-4bdf-8ae2-b687719e2dcc@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wdouglass@carnegierobotics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox