* Re: [PATCH] selftests/mm: khugepaged: remove str_dup() usage
2026-08-25 11:20 [PATCH] selftests/mm: khugepaged: remove str_dup() usage David Hildenbrand (Arm)
@ 2026-08-25 11:23 ` Lorenzo Stoakes (ARM)
2026-08-25 11:57 ` Zi Yan
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Lorenzo Stoakes (ARM) @ 2026-08-25 11:23 UTC (permalink / raw)
To: David Hildenbrand (Arm)
Cc: Andrew Morton, Zi Yan, Baolin Wang, Liam R. Howlett, Nico Pache,
Ryan Roberts, Dev Jain, Barry Song, Lance Yang, Usama Arif,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Shuah Khan, linux-mm, linux-kselftest, linux-kernel
On Tue, Aug 25, 2026 at 01:20:59PM +0200, David Hildenbrand (Arm) wrote:
> We don't check str_dup() return value and never free it. While both
> things are irrelevant in practice, let's just clean it up by working on
> argv[0] directly and avoiding the str_dup().
>
> Nobody after us needs these parts of the argv[0] string anyway.
>
> This patch is inspired by previous work from Anshuman Tewari [1].
>
> Link: https://lore.kernel.org/r/20260821114416.12255-1-anshumantewari123@gmail.com [1]
> Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
LGTM so:
Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
> tools/testing/selftests/mm/khugepaged.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/selftests/mm/khugepaged.c
> index 1d2d6bd72fd2a..83d27d069c413 100644
> --- a/tools/testing/selftests/mm/khugepaged.c
> +++ b/tools/testing/selftests/mm/khugepaged.c
> @@ -1227,7 +1227,7 @@ static void parse_test_type(int argc, char **argv)
> return;
> }
>
> - buf = strdup(argv[0]);
> + buf = argv[0];
> token = strsep(&buf, ":");
>
> if (!strcmp(token, "all")) {
>
> ---
>
> base-commit: 169393fff5d1ec2690934067eeb95544ff5ebdd7
>
> change-id: 20260825-remove_str_dup-bb089e93094f
>
> --
>
> Cheers,
>
> David
>
--
Cheers, Lorenzo
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] selftests/mm: khugepaged: remove str_dup() usage
2026-08-25 11:20 [PATCH] selftests/mm: khugepaged: remove str_dup() usage David Hildenbrand (Arm)
2026-08-25 11:23 ` Lorenzo Stoakes (ARM)
@ 2026-08-25 11:57 ` Zi Yan
2026-08-25 12:47 ` Lance Yang
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Zi Yan @ 2026-08-25 11:57 UTC (permalink / raw)
To: David Hildenbrand (Arm), Andrew Morton, Lorenzo Stoakes,
Baolin Wang, Liam R. Howlett, Nico Pache, Ryan Roberts, Dev Jain,
Barry Song, Lance Yang, Usama Arif, Vlastimil Babka,
Mike Rapoport, Suren Baghdasaryan, Michal Hocko, Shuah Khan
Cc: linux-mm, linux-kselftest, linux-kernel
On Tue Aug 25, 2026 at 7:20 AM EDT, David Hildenbrand (Arm) wrote:
> We don't check str_dup() return value and never free it. While both
> things are irrelevant in practice, let's just clean it up by working on
> argv[0] directly and avoiding the str_dup().
>
> Nobody after us needs these parts of the argv[0] string anyway.
>
> This patch is inspired by previous work from Anshuman Tewari [1].
>
> Link: https://lore.kernel.org/r/20260821114416.12255-1-anshumantewari123@gmail.com [1]
> Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
> ---
> tools/testing/selftests/mm/khugepaged.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
LGTM.
Reviewed-by: Zi Yan <ziy@nvidia.com>
--
Best Regards,
Yan, Zi
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] selftests/mm: khugepaged: remove str_dup() usage
2026-08-25 11:20 [PATCH] selftests/mm: khugepaged: remove str_dup() usage David Hildenbrand (Arm)
2026-08-25 11:23 ` Lorenzo Stoakes (ARM)
2026-08-25 11:57 ` Zi Yan
@ 2026-08-25 12:47 ` Lance Yang
2026-08-25 13:18 ` Dev Jain
2026-08-25 13:41 ` Usama Arif
4 siblings, 0 replies; 6+ messages in thread
From: Lance Yang @ 2026-08-25 12:47 UTC (permalink / raw)
To: David Hildenbrand (Arm)
Cc: Mike Rapoport, Ryan Roberts, Lorenzo Stoakes, Zi Yan, linux-mm,
Michal Hocko, Usama Arif, Dev Jain, Shuah Khan, Barry Song,
Liam R. Howlett, linux-kselftest, linux-kernel,
Suren Baghdasaryan, Vlastimil Babka, Baolin Wang, Nico Pache,
Andrew Morton
On 2026/8/25 19:20, David Hildenbrand (Arm) wrote:
> We don't check str_dup() return value and never free it. While both
> things are irrelevant in practice, let's just clean it up by working on
> argv[0] directly and avoiding the str_dup().
>
> Nobody after us needs these parts of the argv[0] string anyway.
>
> This patch is inspired by previous work from Anshuman Tewari [1].
>
> Link: https://lore.kernel.org/r/20260821114416.12255-1-anshumantewari123@gmail.com [1]
> Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
> ---
Reviewed-by: Lance Yang <lance.yang@linux.dev>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selftests/mm: khugepaged: remove str_dup() usage
2026-08-25 11:20 [PATCH] selftests/mm: khugepaged: remove str_dup() usage David Hildenbrand (Arm)
` (2 preceding siblings ...)
2026-08-25 12:47 ` Lance Yang
@ 2026-08-25 13:18 ` Dev Jain
2026-08-25 13:41 ` Usama Arif
4 siblings, 0 replies; 6+ messages in thread
From: Dev Jain @ 2026-08-25 13:18 UTC (permalink / raw)
To: David Hildenbrand (Arm), Andrew Morton, Lorenzo Stoakes, Zi Yan,
Baolin Wang, Liam R. Howlett, Nico Pache, Ryan Roberts,
Barry Song, Lance Yang, Usama Arif, Vlastimil Babka,
Mike Rapoport, Suren Baghdasaryan, Michal Hocko, Shuah Khan
Cc: linux-mm, linux-kselftest, linux-kernel
On 25/08/26 4:50 pm, David Hildenbrand (Arm) wrote:
> We don't check str_dup() return value and never free it. While both
> things are irrelevant in practice, let's just clean it up by working on
> argv[0] directly and avoiding the str_dup().
>
> Nobody after us needs these parts of the argv[0] string anyway.
>
> This patch is inspired by previous work from Anshuman Tewari [1].
>
> Link: https://lore.kernel.org/r/20260821114416.12255-1-anshumantewari123@gmail.com [1]
> Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
> ---
LGTM
Reviewed-by: Dev Jain <dev.jain@arm.com>
> tools/testing/selftests/mm/khugepaged.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/selftests/mm/khugepaged.c
> index 1d2d6bd72fd2a..83d27d069c413 100644
> --- a/tools/testing/selftests/mm/khugepaged.c
> +++ b/tools/testing/selftests/mm/khugepaged.c
> @@ -1227,7 +1227,7 @@ static void parse_test_type(int argc, char **argv)
> return;
> }
>
> - buf = strdup(argv[0]);
> + buf = argv[0];
> token = strsep(&buf, ":");
>
> if (!strcmp(token, "all")) {
>
> ---
>
> base-commit: 169393fff5d1ec2690934067eeb95544ff5ebdd7
>
> change-id: 20260825-remove_str_dup-bb089e93094f
>
> --
>
> Cheers,
>
> David
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] selftests/mm: khugepaged: remove str_dup() usage
2026-08-25 11:20 [PATCH] selftests/mm: khugepaged: remove str_dup() usage David Hildenbrand (Arm)
` (3 preceding siblings ...)
2026-08-25 13:18 ` Dev Jain
@ 2026-08-25 13:41 ` Usama Arif
4 siblings, 0 replies; 6+ messages in thread
From: Usama Arif @ 2026-08-25 13:41 UTC (permalink / raw)
To: David Hildenbrand (Arm), Andrew Morton, Lorenzo Stoakes, Zi Yan,
Baolin Wang, Liam R. Howlett, Nico Pache, Ryan Roberts, Dev Jain,
Barry Song, Lance Yang, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Shuah Khan
Cc: linux-mm, linux-kselftest, linux-kernel
On 25/08/2026 12:20, David Hildenbrand (Arm) wrote:
> We don't check str_dup() return value and never free it. While both
> things are irrelevant in practice, let's just clean it up by working on
> argv[0] directly and avoiding the str_dup().
>
> Nobody after us needs these parts of the argv[0] string anyway.
>
> This patch is inspired by previous work from Anshuman Tewari [1].
>
> Link: https://lore.kernel.org/r/20260821114416.12255-1-anshumantewari123@gmail.com [1]
> Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
> ---
> tools/testing/selftests/mm/khugepaged.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Usama Arif <usama.arif@linux.dev>
^ permalink raw reply [flat|nested] 6+ messages in thread