* [PATCH] iommu: remove useless parameter in iommu_bus_init().
@ 2022-09-30 7:02 Yu Zhang
2022-09-30 8:04 ` Baolu Lu
0 siblings, 1 reply; 3+ messages in thread
From: Yu Zhang @ 2022-09-30 7:02 UTC (permalink / raw)
To: joro, will, robin.murphy; +Cc: iommu, linux-kernel
Parameter 'ops' is no longer used by iommu_bus_init(), after
commit 8cec63e52966 ("iommu: Remove iommu_callback_data").
So just remove it.
Signed-off-by: Yu Zhang <yu.c.zhang@linux.intel.com>
---
drivers/iommu/iommu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 3a808146b50f..bedda1e0f016 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -1775,7 +1775,7 @@ int bus_iommu_probe(struct bus_type *bus)
return ret;
}
-static int iommu_bus_init(struct bus_type *bus, const struct iommu_ops *ops)
+static int iommu_bus_init(struct bus_type *bus)
{
struct notifier_block *nb;
int err;
@@ -1836,7 +1836,7 @@ int bus_set_iommu(struct bus_type *bus, const struct iommu_ops *ops)
bus->iommu_ops = ops;
/* Do IOMMU specific setup for this bus-type */
- err = iommu_bus_init(bus, ops);
+ err = iommu_bus_init(bus);
if (err)
bus->iommu_ops = NULL;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu: remove useless parameter in iommu_bus_init().
2022-09-30 7:02 [PATCH] iommu: remove useless parameter in iommu_bus_init() Yu Zhang
@ 2022-09-30 8:04 ` Baolu Lu
2022-09-30 9:09 ` Yu Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Baolu Lu @ 2022-09-30 8:04 UTC (permalink / raw)
To: Yu Zhang, joro, will, robin.murphy; +Cc: baolu.lu, iommu, linux-kernel
On 2022/9/30 15:02, Yu Zhang wrote:
> Parameter 'ops' is no longer used by iommu_bus_init(), after
> commit 8cec63e52966 ("iommu: Remove iommu_callback_data").
>
> So just remove it.
>
> Signed-off-by: Yu Zhang <yu.c.zhang@linux.intel.com>
> ---
> drivers/iommu/iommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 3a808146b50f..bedda1e0f016 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -1775,7 +1775,7 @@ int bus_iommu_probe(struct bus_type *bus)
> return ret;
> }
>
> -static int iommu_bus_init(struct bus_type *bus, const struct iommu_ops *ops)
> +static int iommu_bus_init(struct bus_type *bus)
> {
> struct notifier_block *nb;
> int err;
> @@ -1836,7 +1836,7 @@ int bus_set_iommu(struct bus_type *bus, const struct iommu_ops *ops)
> bus->iommu_ops = ops;
>
> /* Do IOMMU specific setup for this bus-type */
> - err = iommu_bus_init(bus, ops);
> + err = iommu_bus_init(bus);
> if (err)
> bus->iommu_ops = NULL;
>
bus_set_iommu() has been retired. All patches are just queued in
linux-next and will show up in v6.1-rc1.
Best regards,
baolu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu: remove useless parameter in iommu_bus_init().
2022-09-30 8:04 ` Baolu Lu
@ 2022-09-30 9:09 ` Yu Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Yu Zhang @ 2022-09-30 9:09 UTC (permalink / raw)
To: Baolu Lu; +Cc: joro, will, robin.murphy, iommu, linux-kernel
On Fri, Sep 30, 2022 at 04:04:41PM +0800, Baolu Lu wrote:
> On 2022/9/30 15:02, Yu Zhang wrote:
> > Parameter 'ops' is no longer used by iommu_bus_init(), after
> > commit 8cec63e52966 ("iommu: Remove iommu_callback_data").
> >
> > So just remove it.
> >
> > Signed-off-by: Yu Zhang <yu.c.zhang@linux.intel.com>
> > ---
> > drivers/iommu/iommu.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> > index 3a808146b50f..bedda1e0f016 100644
> > --- a/drivers/iommu/iommu.c
> > +++ b/drivers/iommu/iommu.c
> > @@ -1775,7 +1775,7 @@ int bus_iommu_probe(struct bus_type *bus)
> > return ret;
> > }
> > -static int iommu_bus_init(struct bus_type *bus, const struct iommu_ops *ops)
> > +static int iommu_bus_init(struct bus_type *bus)
> > {
> > struct notifier_block *nb;
> > int err;
> > @@ -1836,7 +1836,7 @@ int bus_set_iommu(struct bus_type *bus, const struct iommu_ops *ops)
> > bus->iommu_ops = ops;
> > /* Do IOMMU specific setup for this bus-type */
> > - err = iommu_bus_init(bus, ops);
> > + err = iommu_bus_init(bus);
> > if (err)
> > bus->iommu_ops = NULL;
>
> bus_set_iommu() has been retired. All patches are just queued in
> linux-next and will show up in v6.1-rc1.
Oh. Sorry for the disturbance.
B.R.
Yu
>
> Best regards,
> baolu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-30 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-30 7:02 [PATCH] iommu: remove useless parameter in iommu_bus_init() Yu Zhang
2022-09-30 8:04 ` Baolu Lu
2022-09-30 9:09 ` Yu Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox