[PATCH] dmaengine: ptdma: Remove dead code from pt_dmaengine_register()

[PATCH] dmaengine: ptdma: Remove dead code from pt_dmaengine_register()

[Eder Zulian]

devm_kasprintf() is used to allocate and format a string and the
returned pointer is assigned to 'cmd_cache_name'. However, the variable
'cmd_cache_name' is not effectively used.

Remove the dead code.

Signed-off-by: Eder Zulian <ezulian@redhat.com>
---
 drivers/dma/amd/ptdma/ptdma-dmaengine.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/dma/amd/ptdma/ptdma-dmaengine.c b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
index 715ac3ae067b..3a8014fb9cb4 100644
--- a/drivers/dma/amd/ptdma/ptdma-dmaengine.c
+++ b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
@@ -565,7 +565,6 @@ int pt_dmaengine_register(struct pt_device *pt)
 	struct ae4_device *ae4 = NULL;
 	struct pt_dma_chan *chan;
 	char *desc_cache_name;
-	char *cmd_cache_name;
 	int ret, i;
 
 	if (pt->ver == AE4_DMA_VERSION)
@@ -581,12 +580,6 @@ int pt_dmaengine_register(struct pt_device *pt)
 	if (!pt->pt_dma_chan)
 		return -ENOMEM;
 
-	cmd_cache_name = devm_kasprintf(pt->dev, GFP_KERNEL,
-					"%s-dmaengine-cmd-cache",
-					dev_name(pt->dev));
-	if (!cmd_cache_name)
-		return -ENOMEM;
-
 	desc_cache_name = devm_kasprintf(pt->dev, GFP_KERNEL,
 					 "%s-dmaengine-desc-cache",
 					 dev_name(pt->dev));
-- 
2.49.0

Re: [PATCH] dmaengine: ptdma: Remove dead code from pt_dmaengine_register()

[Nathan Lynch]

Eder Zulian <ezulian@redhat.com> writes:
> devm_kasprintf() is used to allocate and format a string and the
> returned pointer is assigned to 'cmd_cache_name'. However, the variable
> 'cmd_cache_name' is not effectively used.
>
> Remove the dead code.
>
> Signed-off-by: Eder Zulian <ezulian@redhat.com>

While I work at AMD, I don't work on this driver and I defer to
Basavaraj. But it's easy to verify that cmd_cache_name is indeed
unused.

BTW it looks like struct pt_device->dma_cmd_cache could also be
discarded.

Reviewed-by: Nathan Lynch <nathan.lynch@amd.com>

> ---
>  drivers/dma/amd/ptdma/ptdma-dmaengine.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/dma/amd/ptdma/ptdma-dmaengine.c b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> index 715ac3ae067b..3a8014fb9cb4 100644
> --- a/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> +++ b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> @@ -565,7 +565,6 @@ int pt_dmaengine_register(struct pt_device *pt)
>  	struct ae4_device *ae4 = NULL;
>  	struct pt_dma_chan *chan;
>  	char *desc_cache_name;
> -	char *cmd_cache_name;
>  	int ret, i;
>  
>  	if (pt->ver == AE4_DMA_VERSION)
> @@ -581,12 +580,6 @@ int pt_dmaengine_register(struct pt_device *pt)
>  	if (!pt->pt_dma_chan)
>  		return -ENOMEM;
>  
> -	cmd_cache_name = devm_kasprintf(pt->dev, GFP_KERNEL,
> -					"%s-dmaengine-cmd-cache",
> -					dev_name(pt->dev));
> -	if (!cmd_cache_name)
> -		return -ENOMEM;
> -
>  	desc_cache_name = devm_kasprintf(pt->dev, GFP_KERNEL,
>  					 "%s-dmaengine-desc-cache",
>  					 dev_name(pt->dev));
> -- 
> 2.49.0

Re: [PATCH] dmaengine: ptdma: Remove dead code from pt_dmaengine_register()

[Basavaraj Natikar]

On 4/11/2025 10:24 PM, Eder Zulian wrote:
> devm_kasprintf() is used to allocate and format a string and the
> returned pointer is assigned to 'cmd_cache_name'. However, the variable
> 'cmd_cache_name' is not effectively used.
>
> Remove the dead code.
>
> Signed-off-by: Eder Zulian <ezulian@redhat.com>
> ---
>   drivers/dma/amd/ptdma/ptdma-dmaengine.c | 7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/drivers/dma/amd/ptdma/ptdma-dmaengine.c b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> index 715ac3ae067b..3a8014fb9cb4 100644
> --- a/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> +++ b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> @@ -565,7 +565,6 @@ int pt_dmaengine_register(struct pt_device *pt)
>   	struct ae4_device *ae4 = NULL;
>   	struct pt_dma_chan *chan;
>   	char *desc_cache_name;
> -	char *cmd_cache_name;
>   	int ret, i;
>   
>   	if (pt->ver == AE4_DMA_VERSION)
> @@ -581,12 +580,6 @@ int pt_dmaengine_register(struct pt_device *pt)
>   	if (!pt->pt_dma_chan)
>   		return -ENOMEM;
>   
> -	cmd_cache_name = devm_kasprintf(pt->dev, GFP_KERNEL,
> -					"%s-dmaengine-cmd-cache",
> -					dev_name(pt->dev));
> -	if (!cmd_cache_name)
> -		return -ENOMEM;
> -
>   	desc_cache_name = devm_kasprintf(pt->dev, GFP_KERNEL,
>   					 "%s-dmaengine-desc-cache",
>   					 dev_name(pt->dev));

Looks good to me.

Acked-by: Basavaraj Natikar<Basavaraj.Natikar@amd.com>

Thanks,
--
Basavaraj

Re: [PATCH] dmaengine: ptdma: Remove dead code from pt_dmaengine_register()

[Vinod Koul]

On Fri, 11 Apr 2025 18:54:51 +0200, Eder Zulian wrote:
> devm_kasprintf() is used to allocate and format a string and the
> returned pointer is assigned to 'cmd_cache_name'. However, the variable
> 'cmd_cache_name' is not effectively used.
> 
> Remove the dead code.
> 
> 
> [...]

Applied, thanks!

[1/1] dmaengine: ptdma: Remove dead code from pt_dmaengine_register()
      commit: 862f3c49a86b85f314c09437d0afd1afc2c02fdd

Best regards,
-- 
~Vinod