[PATCH] arm64: dts: qcom: qcs8300: Add support for camss

[PATCH] arm64: dts: qcom: qcs8300: Add support for camss

[Wenmeng Liu]

This change enables camera driver for QCS8300 RIDE board.

---
Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
---
This patch series depends on patch series:
- https://lore.kernel.org/all/20250214095611.2498950-1-quic_vikramsa@quicinc.com/
- https://lore.kernel.org/all/20250211-sa8775p_tpg-v1-1-3f76c5f8431f@quicinc.com/
- https://lore.kernel.org/all/20250217-qcs8300_tpg-v1-1-6e0f4dd3ad1f@quicinc.com/
- https://lore.kernel.org/all/20250214094747.2483058-1-quic_vikramsa@quicinc.com/
---
---
 arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
index 3ff8f398cad31a36fa46060855b075c8c2020aa7..97281d6d7376a406e5c31466e175358b10441256 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
@@ -207,6 +207,10 @@ vreg_l9c: ldo9 {
 	};
 };
 
+&camss {
+	status = "ok";
+};
+
 &ethernet0 {
 	phy-mode = "2500base-x";
 	phy-handle = <&phy0>;

---
base-commit: b16751cc36fc42deedf4726683423e19939c1044
change-id: 20250520-qcs8300-camss-ffc2032c365a

Best regards,
-- 
Wenmeng Liu <quic_wenmliu@quicinc.com>

Re: [PATCH] arm64: dts: qcom: qcs8300: Add support for camss

[Krzysztof Kozlowski]

On 20/05/2025 11:40, Wenmeng Liu wrote:
> This change enables camera driver for QCS8300 RIDE board.
> 
> ---
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> This patch series depends on patch series:
> - https://lore.kernel.org/all/20250214095611.2498950-1-quic_vikramsa@quicinc.com/
> - https://lore.kernel.org/all/20250211-sa8775p_tpg-v1-1-3f76c5f8431f@quicinc.com/
> - https://lore.kernel.org/all/20250217-qcs8300_tpg-v1-1-6e0f4dd3ad1f@quicinc.com/
> - https://lore.kernel.org/all/20250214094747.2483058-1-quic_vikramsa@quicinc.com/
No, please stop for now and see my other comments. You cannot send patch
which depends on 4 different patchsets! This is making merging
impossible and puts effort on maintainer to track these dependencies.

Plus this was not even tested.

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: qcs8300: Add support for camss

[Krzysztof Kozlowski]

On 20/05/2025 11:45, Krzysztof Kozlowski wrote:
> On 20/05/2025 11:40, Wenmeng Liu wrote:
>> This change enables camera driver for QCS8300 RIDE board.
>>
>> ---
>> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
>> ---
>> This patch series depends on patch series:
>> - https://lore.kernel.org/all/20250214095611.2498950-1-quic_vikramsa@quicinc.com/
>> - https://lore.kernel.org/all/20250211-sa8775p_tpg-v1-1-3f76c5f8431f@quicinc.com/
>> - https://lore.kernel.org/all/20250217-qcs8300_tpg-v1-1-6e0f4dd3ad1f@quicinc.com/
>> - https://lore.kernel.org/all/20250214094747.2483058-1-quic_vikramsa@quicinc.com/
> No, please stop for now and see my other comments. You cannot send patch
> which depends on 4 different patchsets! This is making merging
> impossible and puts effort on maintainer to track these dependencies.
> 
> Plus this was not even tested.
> 
... and:

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

I suggest to read your internal guideline before posting. It is quite
comprehensive.

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: qcs8300: Add support for camss

[Wenmeng Liu]

On 2025/5/20 17:47, Krzysztof Kozlowski wrote:
> On 20/05/2025 11:45, Krzysztof Kozlowski wrote:
>> On 20/05/2025 11:40, Wenmeng Liu wrote:
>>> This change enables camera driver for QCS8300 RIDE board.
>>>
>>> ---
>>> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
>>> ---
>>> This patch series depends on patch series:
>>> - https://lore.kernel.org/all/20250214095611.2498950-1-quic_vikramsa@quicinc.com/
>>> - https://lore.kernel.org/all/20250211-sa8775p_tpg-v1-1-3f76c5f8431f@quicinc.com/
>>> - https://lore.kernel.org/all/20250217-qcs8300_tpg-v1-1-6e0f4dd3ad1f@quicinc.com/
>>> - https://lore.kernel.org/all/20250214094747.2483058-1-quic_vikramsa@quicinc.com/
>> No, please stop for now and see my other comments. You cannot send patch
>> which depends on 4 different patchsets! This is making merging
>> impossible and puts effort on maintainer to track these dependencies.
>>
>> Plus this was not even tested.
>>
> ... and:
> 
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
> 
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> 
> I suggest to read your internal guideline before posting. It is quite
> comprehensive.
> 
> Best regards,
> Krzysztof


Thank you for the reminder, Will make sure to pay attention to it.

Thanks,
Wenmeng

Re: [PATCH] arm64: dts: qcom: qcs8300: Add support for camss

[Loic Poulain]

On Tue, May 20, 2025 at 11:40 AM Wenmeng Liu <quic_wenmliu@quicinc.com> wrote:
>
> This change enables camera driver for QCS8300 RIDE board.
>
> ---
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> This patch series depends on patch series:
> - https://lore.kernel.org/all/20250214095611.2498950-1-quic_vikramsa@quicinc.com/
> - https://lore.kernel.org/all/20250211-sa8775p_tpg-v1-1-3f76c5f8431f@quicinc.com/
> - https://lore.kernel.org/all/20250217-qcs8300_tpg-v1-1-6e0f4dd3ad1f@quicinc.com/
> - https://lore.kernel.org/all/20250214094747.2483058-1-quic_vikramsa@quicinc.com/
> ---
> ---
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index 3ff8f398cad31a36fa46060855b075c8c2020aa7..97281d6d7376a406e5c31466e175358b10441256 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -207,6 +207,10 @@ vreg_l9c: ldo9 {
>         };
>  };
>
> +&camss {
> +       status = "ok";
> +};

Same comment as for qcs615, what is the reason for enabling camss
without an actual sensor? If it's for testing via TPG, I'm not sure
why it should be enabled on this specific board.

Regards,
Loic