public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] mfd: intel-lpss: Add Intel Nova Lake-H PCI IDs
@ 2026-03-12 16:39 Ilpo Järvinen
  2026-03-13  9:09 ` Andy Shevchenko
  0 siblings, 1 reply; 6+ messages in thread
From: Ilpo Järvinen @ 2026-03-12 16:39 UTC (permalink / raw)
  To: Andy Shevchenko, Lee Jones, linux-kernel
  Cc: Ilpo Järvinen, Saranya Gopal

Add Intel Nova Lake-H LPSS PCI IDs.

Signed-off-by: Saranya Gopal <saranya.gopal@intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
 drivers/mfd/intel-lpss-pci.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index 713a5bfb1a3c..a9452ac92fb2 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -633,6 +633,19 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
 	{ PCI_VDEVICE(INTEL, 0xa879), (kernel_ulong_t)&ehl_i2c_info },
 	{ PCI_VDEVICE(INTEL, 0xa87a), (kernel_ulong_t)&ehl_i2c_info },
 	{ PCI_VDEVICE(INTEL, 0xa87b), (kernel_ulong_t)&ehl_i2c_info },
+	/* NVL-H */
+	{ PCI_VDEVICE(INTEL, 0xd325), (kernel_ulong_t)&bxt_uart_info },
+	{ PCI_VDEVICE(INTEL, 0xd326), (kernel_ulong_t)&bxt_uart_info },
+	{ PCI_VDEVICE(INTEL, 0xd327), (kernel_ulong_t)&tgl_spi_info },
+	{ PCI_VDEVICE(INTEL, 0xd330), (kernel_ulong_t)&tgl_spi_info },
+	{ PCI_VDEVICE(INTEL, 0xd347), (kernel_ulong_t)&tgl_spi_info },
+	{ PCI_VDEVICE(INTEL, 0xd350), (kernel_ulong_t)&ehl_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0xd351), (kernel_ulong_t)&ehl_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0xd352), (kernel_ulong_t)&bxt_uart_info },
+	{ PCI_VDEVICE(INTEL, 0xd378), (kernel_ulong_t)&ehl_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0xd379), (kernel_ulong_t)&ehl_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0xd37a), (kernel_ulong_t)&ehl_i2c_info },
+	{ PCI_VDEVICE(INTEL, 0xd37b), (kernel_ulong_t)&ehl_i2c_info },
 	/* PTL-H */
 	{ PCI_VDEVICE(INTEL, 0xe325), (kernel_ulong_t)&bxt_uart_info },
 	{ PCI_VDEVICE(INTEL, 0xe326), (kernel_ulong_t)&bxt_uart_info },

base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] mfd: intel-lpss: Add Intel Nova Lake-H PCI IDs
  2026-03-12 16:39 [PATCH 1/1] mfd: intel-lpss: Add Intel Nova Lake-H PCI IDs Ilpo Järvinen
@ 2026-03-13  9:09 ` Andy Shevchenko
  2026-03-13  9:41   ` Ilpo Järvinen
  0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2026-03-13  9:09 UTC (permalink / raw)
  To: Ilpo Järvinen; +Cc: Lee Jones, linux-kernel, Saranya Gopal

On Thu, Mar 12, 2026 at 06:39:58PM +0200, Ilpo Järvinen wrote:
> Add Intel Nova Lake-H LPSS PCI IDs.

> Signed-off-by: Saranya Gopal <saranya.gopal@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

This seems incorrect. Either missed proper From: or Co-developed-by.
Who is Saranya?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] mfd: intel-lpss: Add Intel Nova Lake-H PCI IDs
  2026-03-13  9:09 ` Andy Shevchenko
@ 2026-03-13  9:41   ` Ilpo Järvinen
  2026-03-13  9:54     ` Andy Shevchenko
  0 siblings, 1 reply; 6+ messages in thread
From: Ilpo Järvinen @ 2026-03-13  9:41 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Lee Jones, LKML, Saranya Gopal

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

On Fri, 13 Mar 2026, Andy Shevchenko wrote:

> On Thu, Mar 12, 2026 at 06:39:58PM +0200, Ilpo Järvinen wrote:
> > Add Intel Nova Lake-H LPSS PCI IDs.
> 
> > Signed-off-by: Saranya Gopal <saranya.gopal@intel.com>
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> 
> This seems incorrect. Either missed proper From: or Co-developed-by.
> Who is Saranya?

I'll add Co-developed-by. I was pointed to an internal patch from Saranya 
that added these which I used as basis but I had to make many tweaks to 
it.

-- 
 i.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] mfd: intel-lpss: Add Intel Nova Lake-H PCI IDs
  2026-03-13  9:41   ` Ilpo Järvinen
@ 2026-03-13  9:54     ` Andy Shevchenko
  2026-03-13  9:56       ` Ilpo Järvinen
  0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2026-03-13  9:54 UTC (permalink / raw)
  To: Ilpo Järvinen; +Cc: Lee Jones, LKML, Saranya Gopal

On Fri, Mar 13, 2026 at 11:41:30AM +0200, Ilpo Järvinen wrote:
> On Fri, 13 Mar 2026, Andy Shevchenko wrote:
> > On Thu, Mar 12, 2026 at 06:39:58PM +0200, Ilpo Järvinen wrote:
> > > Add Intel Nova Lake-H LPSS PCI IDs.
> > 
> > > Signed-off-by: Saranya Gopal <saranya.gopal@intel.com>
> > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > 
> > This seems incorrect. Either missed proper From: or Co-developed-by.
> > Who is Saranya?
> 
> I'll add Co-developed-by. I was pointed to an internal patch from Saranya
> that added these which I used as basis but I had to make many tweaks to
> it.

So, it's basically should be their From: and your Co-developed-by if I'm
reading this correctly.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] mfd: intel-lpss: Add Intel Nova Lake-H PCI IDs
  2026-03-13  9:54     ` Andy Shevchenko
@ 2026-03-13  9:56       ` Ilpo Järvinen
  2026-03-13 10:01         ` Andy Shevchenko
  0 siblings, 1 reply; 6+ messages in thread
From: Ilpo Järvinen @ 2026-03-13  9:56 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Lee Jones, LKML, Saranya Gopal

[-- Attachment #1: Type: text/plain, Size: 852 bytes --]

On Fri, 13 Mar 2026, Andy Shevchenko wrote:

> On Fri, Mar 13, 2026 at 11:41:30AM +0200, Ilpo Järvinen wrote:
> > On Fri, 13 Mar 2026, Andy Shevchenko wrote:
> > > On Thu, Mar 12, 2026 at 06:39:58PM +0200, Ilpo Järvinen wrote:
> > > > Add Intel Nova Lake-H LPSS PCI IDs.
> > > 
> > > > Signed-off-by: Saranya Gopal <saranya.gopal@intel.com>
> > > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > 
> > > This seems incorrect. Either missed proper From: or Co-developed-by.
> > > Who is Saranya?
> > 
> > I'll add Co-developed-by. I was pointed to an internal patch from Saranya
> > that added these which I used as basis but I had to make many tweaks to
> > it.
> 
> So, it's basically should be their From: and your Co-developed-by if I'm
> reading this correctly.

Whatever, I'll do that way then.

-- 
 i.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] mfd: intel-lpss: Add Intel Nova Lake-H PCI IDs
  2026-03-13  9:56       ` Ilpo Järvinen
@ 2026-03-13 10:01         ` Andy Shevchenko
  0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2026-03-13 10:01 UTC (permalink / raw)
  To: Ilpo Järvinen; +Cc: Lee Jones, LKML, Saranya Gopal

On Fri, Mar 13, 2026 at 11:56:39AM +0200, Ilpo Järvinen wrote:
> On Fri, 13 Mar 2026, Andy Shevchenko wrote:
> > On Fri, Mar 13, 2026 at 11:41:30AM +0200, Ilpo Järvinen wrote:
> > > On Fri, 13 Mar 2026, Andy Shevchenko wrote:
> > > > On Thu, Mar 12, 2026 at 06:39:58PM +0200, Ilpo Järvinen wrote:

...

> > > > > Signed-off-by: Saranya Gopal <saranya.gopal@intel.com>
> > > > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > > 
> > > > This seems incorrect. Either missed proper From: or Co-developed-by.
> > > > Who is Saranya?
> > > 
> > > I'll add Co-developed-by. I was pointed to an internal patch from Saranya
> > > that added these which I used as basis but I had to make many tweaks to
> > > it.
> > 
> > So, it's basically should be their From: and your Co-developed-by if I'm
> > reading this correctly.
> 
> Whatever, I'll do that way then.

Sounds good, thanks!


-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-03-13 10:01 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-12 16:39 [PATCH 1/1] mfd: intel-lpss: Add Intel Nova Lake-H PCI IDs Ilpo Järvinen
2026-03-13  9:09 ` Andy Shevchenko
2026-03-13  9:41   ` Ilpo Järvinen
2026-03-13  9:54     ` Andy Shevchenko
2026-03-13  9:56       ` Ilpo Järvinen
2026-03-13 10:01         ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox