Re: [PATCH v15 5/7] soc: qcom: rpmh: Invoke rpmh_flush() for dirty caches

[Maulik Shah <mkshah@codeaurora.org>]

Hi,

On 4/3/2020 1:43 AM, Doug Anderson wrote:
> Hi,
>
> On Tue, Mar 31, 2020 at 6:20 AM Maulik Shah <mkshah@codeaurora.org> wrote:
>> +/**
>> + * rpmh_rsc_ctrlr_is_busy: Check if any of the AMCs are busy.
> nit: this is still not quite kerneldoc format.  Specifically, the
> above should be:
>
> * rpmh_rsc_ctrlr_is_busy() - Check if any of the AMCs are busy
>
> You may think I'm being nit picky, but try running:
>
> scripts/kernel-doc -rst drivers/soc/qcom/rpmh-rsc.c
>
> Now search the output for "Check if any of the AMCs are busy".  It
> won't be there as you have formatted it.  If you fix it to the proper
> format then it shows up.  I'm not saying that you should fix up all
> functions at once but if you're adding new functions why not make them
> compliant?
>
>
> Other than the kerneldoc nitpick which could happen later in a cleanup
> series for the whole driver at once, this patch looks fine to me now.
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Thanks for the review Doug.

I will fix this in v16 to update as per kernel doc format.

Thanks,
Maulik

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation