public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Taniya Das <tdas@codeaurora.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Rajendra Nayak <quic_rjendra@quicinc.com>
Subject: Re: [PATCH 3/3] dt-bindings: clock: qcom,gcc-sc7280: document CX power domain
Date: Sat, 8 Apr 2023 16:04:02 +0200	[thread overview]
Message-ID: <bc933ae8-af3a-b147-3fbf-e6b8bfb1d1ea@linaro.org> (raw)
In-Reply-To: <20230408134820.76050-3-krzysztof.kozlowski@linaro.org>



On 8.04.2023 15:48, Krzysztof Kozlowski wrote:
> The GCC clock controller needs CX power domain, at least according to
> DTS:
> 
>   sc7280-herobrine-crd-pro.dtb: clock-controller@100000: Unevaluated properties are not allowed ('power-domains' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
+CC Rajendra

Same question as with 7180

Konrad
>  .../devicetree/bindings/clock/qcom,gcc-sc7280.yaml         | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sc7280.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sc7280.yaml
> index 947b47168cec..ff0b18bbb0fc 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sc7280.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sc7280.yaml
> @@ -43,6 +43,10 @@ properties:
>        - const: ufs_phy_tx_symbol_0_clk
>        - const: usb3_phy_wrapper_gcc_usb30_pipe_clk
>  
> +  power-domains:
> +    items:
> +      - description: CX domain
> +
>  required:
>    - compatible
>    - clocks
> @@ -56,6 +60,8 @@ unevaluatedProperties: false
>  examples:
>    - |
>      #include <dt-bindings/clock/qcom,rpmh.h>
> +    #include <dt-bindings/power/qcom-rpmpd.h>
> +
>      clock-controller@100000 {
>        compatible = "qcom,gcc-sc7280";
>        reg = <0x00100000 0x1f0000>;
> @@ -71,6 +77,7 @@ examples:
>                       "pcie_1_pipe_clk", "ufs_phy_rx_symbol_0_clk",
>                       "ufs_phy_rx_symbol_1_clk", "ufs_phy_tx_symbol_0_clk",
>                       "usb3_phy_wrapper_gcc_usb30_pipe_clk";
> +      power-domains = <&rpmhpd SC7280_CX>;
>        #clock-cells = <1>;
>        #reset-cells = <1>;
>        #power-domain-cells = <1>;

  reply	other threads:[~2023-04-08 14:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-08 13:48 [PATCH 1/3] dt-bindings: clock: qcom,gcc-sm8250: add missing bi_tcxo_ao clock Krzysztof Kozlowski
2023-04-08 13:48 ` [PATCH 2/3] dt-bindings: clock: qcom,gcc-sc7180: document CX power domain Krzysztof Kozlowski
2023-04-08 14:03   ` Konrad Dybcio
2023-04-11  4:56     ` Rajendra Nayak
2023-04-11 11:27       ` Konrad Dybcio
2023-04-11 13:31         ` Rajendra Nayak
2023-04-11 13:45           ` Konrad Dybcio
2023-04-12  5:42             ` Rajendra Nayak
2023-04-12 10:34               ` Konrad Dybcio
2023-04-12 15:16   ` Rob Herring
2023-04-08 13:48 ` [PATCH 3/3] dt-bindings: clock: qcom,gcc-sc7280: " Krzysztof Kozlowski
2023-04-08 14:04   ` Konrad Dybcio [this message]
2023-04-12 15:17   ` Rob Herring
2023-04-08 14:00 ` [PATCH 1/3] dt-bindings: clock: qcom,gcc-sm8250: add missing bi_tcxo_ao clock Konrad Dybcio
2023-04-10 19:33 ` Stephen Boyd
2023-04-12 15:15 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc933ae8-af3a-b147-3fbf-e6b8bfb1d1ea@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_rjendra@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tdas@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox