From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: Fix test_async_driver_probe if NUMA is disabled
Date: Mon, 09 Dec 2019 12:59:36 -0800 [thread overview]
Message-ID: <bda264051bc86ad9674c655f3a0c91326088bcdd.camel@linux.intel.com> (raw)
In-Reply-To: <20191209204440.GA1584@roeck-us.net>
On Mon, 2019-12-09 at 12:44 -0800, Guenter Roeck wrote:
> On Wed, Dec 04, 2019 at 09:18:28AM -0800, Alexander Duyck wrote:
> > > I thought the code is specifically checking devices which it previously
> > > created, which are well defined and understood test devices. After all,
> > > the check is in the test driver's probe function. Guess I really don't
> > > understand the code. Please take my patch as bug report, and submit
> > > whatever fix you think is correct.
> >
> > Sorry I had overlooked that this is the test code.
> >
> > I suppose it should be fine since we specify the node ID for all instances
> > where we register an asychronous test device.
> >
>
> That isn't exacly an endorsement. Would you mind submitting a patch
> that is acceptable for you ? I'll be more than happy to test it.
>
> Thanks,
> Guenter
It isn't really worth the trouble.
I would have been concerned if the patch was in something other than test
code, and I hasn't paid close attention to the specific file being edited.
Your patch is more than enough to address the original issue you reported.
Thanks.
Acked-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
prev parent reply other threads:[~2019-12-09 20:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 20:24 [PATCH] driver core: Fix test_async_driver_probe if NUMA is disabled Guenter Roeck
2019-11-27 21:24 ` Alexander Duyck
2019-11-27 22:42 ` Guenter Roeck
2019-11-27 23:13 ` Alexander Duyck
2019-11-28 0:33 ` Guenter Roeck
2019-12-04 17:18 ` Alexander Duyck
2019-12-09 20:44 ` Guenter Roeck
2019-12-09 20:59 ` Alexander Duyck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bda264051bc86ad9674c655f3a0c91326088bcdd.camel@linux.intel.com \
--to=alexander.h.duyck@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox